From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BAED303C88 for ; Mon, 9 Feb 2026 08:42:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770626526; cv=none; b=Kbgc+r0gVWMLE8j97UDOAbx5lDIhN+QcTacWxK2QTLhNOMmJdI8bZkI5QwoEYsF74F08SSBEH2KNwSTRo6drb51kjmeT01K0mP+xS9EJyobqKjwRu3rci3gZW1UEr/dIBL/QTxtf+LwyT3avccwwEZ5AFaK8nkBTxLf9Otn9xcw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770626526; c=relaxed/simple; bh=LiYrdmZmpe82t7dlcM/f2AMhXxkyP+KlPiuEiIfS8hQ=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=J6NP3uCtgENqsAOVf3LAZMm/4ZrxzsXZH6rRP4plEMf9Leu7UxJr2I0VK1oWR7LM/j3GJ7G1ql+2SC+6kugGkuTq9g5gp+sWsDO9GUg+DL7l4mPasj38COjxW+DsOZZiCHalOKSH/e0DNExMwQQhktnpRx/90UywPrH29PFcT0c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=L1SfwTvo; arc=none smtp.client-ip=209.85.167.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="L1SfwTvo" Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-59e4989dacdso1843074e87.1 for ; Mon, 09 Feb 2026 00:42:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770626525; x=1771231325; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=cxn1uhOmh76vKJ6SWls1H47L/AWVvPiIPbvQPRDKQr8=; b=L1SfwTvoILdLWiZEM/WKIu+DQDmpBcgpgVzijYVryHfxXYLyZL6r9PF38UtqFncL/r 6VwnOF5DGaQvbsKi5OEqR1RphjDzg8DqV7PvATylt823RkiVHPJP/Lmzdse1VkXJtltF /HR91rKSFkNGMmzzjqrYi0M/M/kvV61HeNNXwsJOjUpiIKInZC0NFW3tENP39PvexJ5g i7/aMqKhMazjSagPySl7jQTHNRUcbpAspxydL8WFvYnAgHfRBGaRWC6vd8MdyhFvmBuP j3HfPxeuK1oleeJpuJo4YY/C0AFEPg9OIfB9jsPRIdxaF3Jvtrx+YBaTNgauwtAXGTPp Xveg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770626525; x=1771231325; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cxn1uhOmh76vKJ6SWls1H47L/AWVvPiIPbvQPRDKQr8=; b=RC+aovZPGxZMzfT7EhGTt3tSCOlY3iRy79gdPT0Gvcz2MIPhiCcUeU9EwLBeDNQIhD AUu3/eJTmMqDnajGdRiHBXccPTxsdb/shmmxzRGpPahWD6yuqnj84y/ZqmIOPiMcsE3T lCooa8j0HFxWGKDcO/bGlbOxQycGaOT34JBYfSDCXIi78GrIpdd1l28DkStNf0lMAx/Z GsxaYR8d6GvD/m2mlC1BBNA8kOFcPudQRuohFkT7L/Xm/RlD/dRpmXdF5ZQTWftueFOP EJnfHmxAflUpxDLFaWx+d8FQujT15U8CIDgRSpQ4lpkqqmCcUmJr36o9V1N82L6VStaz S04g== X-Forwarded-Encrypted: i=1; AJvYcCVOo+3omXGkMt5G6lkriJQNcsLJzOz/1CrbdhI8TOrPlZZWgjUXUDa3muM1+RCgn1+XEXNFAgXcNxZjYdM=@vger.kernel.org X-Gm-Message-State: AOJu0YyuggJj4hYk0KcuydImVAt67GPzlQcVDGT37+ZwAQeHx4lM4st/ ZFqtmgkeDblMZoDHry6Hn1+b4BTYtCp10wp6scWN1B2lADI/OmZ8ZRqT X-Gm-Gg: AZuq6aJk2iblO5FqDskRKotiLKrMaA8H1fZp9Cs/ddYG3i+Q9ZVgywrpPMnqW2Vd03z 6uKjzzNcHh1bOHnuJHDoH0XQ6z21vdK4K/mi8mniGCE2HH4+Ko/YTM+S5JNufhG2Ox0Kf3DlDLs Ie3n+apzSP53dw7DTpXdns2Xpd8HNeVuRMVYBLI2GtbID7pM7zoMtUuy5z9nh317LeQ8aLDM3O/ 5C0Oa8xFojZHW7RhDejF0LmwcQ0rOiNvd1sa1b14mj4RY9+oa2q8CPTxpN2oo1vgbyru+XlRWPa O1FD0Xdg1h4UiyhWY0n6bXow0IA5Kn/GH+Rvpfoe0ewWV8n9ifEggMzXvWUJ+jboqgKZsNnwyT8 d+QAvBl2ZpJ52vQiE0R79om0tKXDUuwpqRjP6Vg5dIiFj7Z6LmL8xv5R3X8oUCmyb6I+V8tJIl6 WGas+6akX82X1K0Y/ASE2b X-Received: by 2002:a05:6512:32c8:b0:59b:9ff8:468e with SMTP id 2adb3069b0e04-59e45156946mr3840197e87.31.1770626524350; Mon, 09 Feb 2026 00:42:04 -0800 (PST) Received: from ehlo.thunderbird.net ([178.137.105.239]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59e44d29a48sm2425411e87.62.2026.02.09.00.42.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Feb 2026 00:42:03 -0800 (PST) Date: Mon, 09 Feb 2026 10:42:02 +0200 From: Svyatoslav Ryhel To: Andy Shevchenko CC: Jonathan Cameron , David Lechner , =?ISO-8859-1?Q?Nuno_S=E1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Torokhov , Lee Jones , Pavel Machek , Liam Girdwood , Mark Brown , Dixit Parmar , Tony Lindgren , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v2_10/11=5D_mfd=3A_motorola-c?= =?US-ASCII?Q?pcap=3A_diverge_configuration_per-board?= User-Agent: K-9 Mail for Android In-Reply-To: References: <20260206172845.145407-1-clamor95@gmail.com> <20260206172845.145407-11-clamor95@gmail.com> Message-ID: <5AA39777-F5C8-4AD5-A5C2-47265C8213F5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable 9 =D0=BB=D1=8E=D1=82=D0=BE=D0=B3=D0=BE 2026=E2=80=AF=D1=80=2E 10:18:57 GMT= +02:00, Andy Shevchenko =D0=BF=D0=B8=D1= =88=D0=B5: >On Sun, Feb 08, 2026 at 05:19:49PM +0200, Svyatoslav Ryhel wrote: >> 8 =D0=BB=D1=8E=D1=82=D0=BE=D0=B3=D0=BE 2026=E2=80=AF=D1=80=2E 14:54:53 = GMT+02:00, Andy Shevchenko =D0=BF=D0=B8= =D1=88=D0=B5: >> >On Fri, Feb 06, 2026 at 07:28:44PM +0200, Svyatoslav Ryhel wrote: > >=2E=2E=2E > >> >> -static const struct of_device_id cpcap_of_match[] =3D { >> >> - { =2Ecompatible =3D "motorola,cpcap", }, >> >> - { =2Ecompatible =3D "st,6556002", }, >> >> - {}, >> >> -}; >> >> -MODULE_DEVICE_TABLE(of, cpcap_of_match); >> >> - >> >> static const struct spi_device_id cpcap_spi_ids[] =3D { >> >> { =2Ename =3D "cpcap", }, >> >> { =2Ename =3D "6556002", }, >> >> + { =2Ename =3D "mapphone-cpcap", }, >> >> {}, >> >> }; >> > >> >This also needs to be converted to use driver data=2E >>=20 >> I can do that, but is it needed? > >For the consistency's sake=2E >Also brief look at MFD SPI drivers I see that most of them use driver dat= a=2E >All that is redundancy? Maybe clean them up as well to show the point? > >> This id table, if I understand correctly, is here solely to silence war= nings >> about missing spi id table=2E Driver itself does not use it in any way = and will >> never use since all available devices that use this driver rely solely = on the >> device tree, all possible future devices will be relying on device tree= too >> due to obvious reasons=2E > >Then maybe SPI should be fixed to avoid this table to be present? (But do= n't >waste your time, it will be a rabbit hole=2E) > >> >> MODULE_DEVICE_TABLE(spi, cpcap_spi_ids); > >=2E=2E=2E > >> And please, may you contain all your reviewing in one iteration=2E Then= both of >> us will spend less time working on the patch=2E Thank you! > >It's an impossible request, you should understand that=2E If you want, us= e AI >or your robot colleagues for that, I'm just a human being, I can't see >everything at once=2E > Ability to see only nits and don't see the possible issues seems to be a t= alent=2E >