From: "Jan Beulich" <JBeulich@suse.com>
To: "Boris Ostrovsky" <boris.ostrovsky@oracle.com>
Cc: "xen-devel" <xen-devel@lists.xenproject.org>,
"Juergen Gross" <jgross@suse.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [Xen-devel] [PATCH v2 1/2] xen/PVH: Set up GS segment for stack canary
Date: Mon, 14 May 2018 06:50:52 -0600 [thread overview]
Message-ID: <5AF9862C02000078001C27B5@prv1-mh.provo.novell.com> (raw)
In-Reply-To: <20180509203318.2611-2-boris.ostrovsky@oracle.com>
>>> On 09.05.18 at 22:33, <boris.ostrovsky@oracle.com> wrote:
> @@ -64,6 +67,17 @@ ENTRY(pvh_start_xen)
> mov %eax,%es
> mov %eax,%ss
>
> + /* Set base address in stack canary descriptor. */
> + movl _pa(gdt_start),%eax
> + movl $_pa(canary),%ecx
> + movw %cx, (PVH_GDT_ENTRY_CANARY * 8) + 0(%eax)
> + shrl $16, %ecx
> + movb %cl, (PVH_GDT_ENTRY_CANARY * 8) + 2(%eax)
> + movb %ch, (PVH_GDT_ENTRY_CANARY * 8) + 5(%eax)
Is this meaningful / correct for the 64-bit case? I'd rather expect you to
write the GS base address MSR there.
Jan
next prev parent reply other threads:[~2018-05-14 12:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-09 20:33 [PATCH v2 0/2] PVH GDT fixes Boris Ostrovsky
2018-05-09 20:33 ` [PATCH v2 1/2] xen/PVH: Set up GS segment for stack canary Boris Ostrovsky
2018-05-14 12:50 ` Jan Beulich [this message]
2018-05-14 18:27 ` [Xen-devel] " Boris Ostrovsky
2018-05-09 20:33 ` [PATCH v2 2/2] xen/PVH: Make GDT selectors PVH-specific Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5AF9862C02000078001C27B5@prv1-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®