From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=91.218.175.3 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794557323; b=oBeq4auoPfAb9e30taKD+pprF2gekWrwnEH0TFT27kefr7c1NXWmXHQReQJa/hBd6CaC 2mpxHCDLz3SpBvhKSArNL7WFv1j1m7RxUdh5MsYqw8j081fJebGUvkw447Hb2oJQHR+/Q Dx6xZ0rWU+y+EcYQdunX5JJ8K+hSmkv6WF9n+aLamWnl10w6Fiq2EsBXTupxNor7cWgeu ev56BNmLJKi8hN54qzI1DG3k+lK6pm+5trCb/9b4f27qyCjoQVpBvB/ui484SXQbUNXjm hLUN7bdAlDXp/sMKWdZDCLPlVuR38fm1yY/Mm5UlvcIfocyj8yf5aVgcbP+nlXZkruQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794557323; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:Date:From:To:CC:Subject:In-Reply-To: References:Message-ID:MIME-Version:Content-Type: Content-Transfer-Encoding; bh=1Y2cQB3BVXv6mmYBPxoBD+Yr8Vd+mIrf0QBlAR5e7vw=; b=YcP7sF0wL7npF6zD6T2/FdSKMZCFq6xDP+6woq/PTpvjakRBscCoH8OxyUaDWBAMfADu gd+1soCfECtQJ6G4KCeKdQp2SDNTZM4wrPXLor+V64fKECSo4fv/phVGzK/KAG+Zpyp+A rkZYb9T4tQbm/AWuO9ISWf+ot8oc4Qq8FJcycgKRg6VtTZnYx/M49Gaaq+LSyoz/nrvXX ppm2nUvg0jN6t8wbCqZq+HmG4rrPkQ9uXdPHJmh/0GljR0WbXfIJ2zNB9ODheGfUioOFM R8W3QR6lD0Val7JBH3zoMiw5RhnSyDyJ6SfjbLxZe/PtQeE7T7/RjkkjyuXGpSnSzEQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=L8Tuuz43; arc=none smtp.remote-ip=91.218.175.3 Received: from mta0.migadu.com (out-3.mta0.migadu.com [91.218.175.3]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7AD88606A331 for ; Fri, 13 Nov 2026 08:08:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 7AD88606A331 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=L8Tuuz43 X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=U0ANUG2udK2hGqFK0evotqu0SJAXMSB+359C0HtCWDw=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1794557320; v=1; x=1795162120; b=L8Tuuz4378qEOmTr14r9l1ahaZvogPtVsZdB5kOH7FPRIyd9CoJBtxxDF4DQMgIvx+eVbaoL bIsENcyqtDvGpXQGSqX4i8KzoqM7bGXdaW9p0+jsWIrxbsYmSqsl+WAVzlMODVoiT8ch7rZBX7R zS9G99Ri3JcDrmSMGRqeem7U= X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id c75314dfffcc5fc6; Fri, 13 Nov 2026 08:08:40 +0000 X-Mizu-Trace-ID: c75314dfffcc5fc6 X-Migadu-Flow: FLOW_OUT Date: Fri, 13 Nov 2026 09:08:35 +0100 From: Luka Gejak To: Ho Jie Feng , Ping-Ke Shih CC: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Bitterblue Smith Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_rtw-next_v3_1/5=5D_wifi=3A_rtw88=3A_88?= =?US-ASCII?Q?12a=2C_8814a=3A_enable_STBC_for_HT_transmissions?= In-Reply-To: <20261112173246.3201729-2-hjf3108@gmail.com> References: <20261112173246.3201729-1-hjf3108@gmail.com> <20261112173246.3201729-2-hjf3108@gmail.com> Message-ID: <5B401960-03A0-4433-9607-ED5149E31844@linux.dev> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Hi Jie Feng, Thanks for adding the 8822c note. One question below. On November 12, 2026 6:32:40 PM GMT+01:00, Ho Jie Feng wrote: > 8812a and 8814a support STBC, enable it. The hardware seems to support it. The vendor driver reports TX STBC for both chips unless they are 1T1R or 1T2R. But it keeps HT STBC TX off by default, os_dep/linux/os_intfs.c in the 8812au driver has int rtw_stbc_cap = 0x13; and rtw_ht_use_default_setting() only enables HT STBC TX for BIT5, which is not set there. VHT STBC TX (BIT1) is on. In rtw88 only 8822c has it, from 81a68a1424ba ("rtw88: 8822c: add tx stbc support under HT mode"), while 8822b stays off although it is 2T2R as well. As far as I can see, a VHT peer already gets STBC through the VHT TX STBC capability we advertise for rf_path_num > 1, so this patch only changes HT peers, for example any AP on 2.4 GHz, where we don't advertise VHT. Did you test it there or with an HT only AP? The numbers in the cover letter would only show this patch if the test was done that way. Best regards, Luka Gejak