From: jiangyiwen <jiangyiwen@huawei.com>
To: piaojun <piaojun@huawei.com>, <akpm@linux-foundation.org>,
<ericvh@gmail.com>, <rminnich@sandia.gov>, <lucho@ionkov.net>
Cc: <linux-kernel@vger.kernel.org>, <v9fs-developer@lists.sourceforge.net>
Subject: Re: [PATCH] net/9p/client.c: add missing '\n' at the end of p9_debug()
Date: Tue, 10 Jul 2018 15:19:03 +0800 [thread overview]
Message-ID: <5B445DE7.3070607@huawei.com> (raw)
In-Reply-To: <5B44589A.50302@huawei.com>
On 2018/7/10 14:56, piaojun wrote:
> In p9_client_getattr_dotl(), we should add '\n' at the end of printing
> log.
>
> Signed-off-by: Jun Piao <piaojun@huawei.com>
Reviewed-by: Yiwen Jiang <jiangyiwen@huawei.com>
> ---
> net/9p/client.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/9p/client.c b/net/9p/client.c
> index 5c13431..8bc8b3e 100644
> --- a/net/9p/client.c
> +++ b/net/9p/client.c
> @@ -1790,7 +1790,7 @@ struct p9_stat_dotl *p9_client_getattr_dotl(struct p9_fid *fid,
> "<<< st_mtime_sec=%lld st_mtime_nsec=%lld\n"
> "<<< st_ctime_sec=%lld st_ctime_nsec=%lld\n"
> "<<< st_btime_sec=%lld st_btime_nsec=%lld\n"
> - "<<< st_gen=%lld st_data_version=%lld",
> + "<<< st_gen=%lld st_data_version=%lld\n",
> ret->st_result_mask, ret->qid.type, ret->qid.path,
> ret->qid.version, ret->st_mode, ret->st_nlink,
> from_kuid(&init_user_ns, ret->st_uid),
>
prev parent reply other threads:[~2018-07-10 7:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 6:56 piaojun
2018-07-10 7:19 ` jiangyiwen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5B445DE7.3070607@huawei.com \
--to=jiangyiwen@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=ericvh@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=piaojun@huawei.com \
--cc=rminnich@sandia.gov \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome