From: "Jan Beulich" <JBeulich@suse.com>
To: "Juergen Gross" <jgross@suse.com>
Cc: "the arch/x86 maintainers" <x86@kernel.org>, <tglx@linutronix.de>,
"Linux Virtualization"
<virtualization@lists.linux-foundation.org>,
"xen-devel" <xen-devel@lists.xenproject.org>,
"Boris Ostrovsky" <boris.ostrovsky@oracle.com>,
<mingo@redhat.com>, <rusty@rustcorp.com.au>,
<linux-kernel@vger.kernel.org>,
"Alok Kataria" <akataria@vmware.com>, <hpa@zytor.com>
Subject: Re: [Xen-devel] [PATCH 04/10] x86/paravirt: use a single ops structure
Date: Fri, 10 Aug 2018 06:06:12 -0600 [thread overview]
Message-ID: <5B6D7FB402000078001DCF30@prv1-mh.provo.novell.com> (raw)
In-Reply-To: <20180810115252.18213-5-jgross@suse.com>
>>> On 10.08.18 at 13:52, <jgross@suse.com> wrote:
> --- a/arch/x86/hyperv/mmu.c
> +++ b/arch/x86/hyperv/mmu.c
> @@ -228,9 +228,9 @@ void hyperv_setup_mmu_ops(void)
>
> if (!(ms_hyperv.hints & HV_X64_EX_PROCESSOR_MASKS_RECOMMENDED)) {
> pr_info("Using hypercall for remote TLB flush\n");
> - pv_mmu_ops.flush_tlb_others = hyperv_flush_tlb_others;
> + pv_ops.pv_mmu_ops.flush_tlb_others = hyperv_flush_tlb_others;
Taking just this as example, why not
pv_ops.mmu.flush_tlb_others = hyperv_flush_tlb_others;
? Both pv_ and _ops are redundant on the field names.
Jan
next prev parent reply other threads:[~2018-08-10 12:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-10 11:52 [PATCH 00/10] x86/paravirt: several cleanups Juergen Gross
2018-08-10 11:52 ` [PATCH 01/10] x86/paravirt: make paravirt_patch_call() and paravirt_patch_jmp() static Juergen Gross
2018-08-10 11:52 ` [PATCH 02/10] x86/paravirt: remove clobbers parameter from paravirt patch functions Juergen Gross
2018-08-10 11:52 ` [PATCH 03/10] x86/paravirt: remove clobbers from struct paravirt_patch_site Juergen Gross
2018-08-10 11:52 ` [PATCH 04/10] x86/paravirt: use a single ops structure Juergen Gross
2018-08-10 12:06 ` Jan Beulich [this message]
[not found] ` <5B6D7FB402000078001D?= =?UTF-8?Q?CF30@suse.com>
2018-08-10 12:30 ` [Xen-devel] " Juergen Gross
2018-08-10 11:52 ` [PATCH 05/10] x86/paravirt: remove unused paravirt bits Juergen Gross
2018-08-10 11:52 ` [PATCH 06/10] x86/paravirt: introduce new config option PARAVIRT_XXL Juergen Gross
2018-08-10 14:22 ` Boris Ostrovsky
2018-08-10 14:44 ` Juergen Gross
2018-08-10 11:52 ` [PATCH 07/10] x86/paravirt: move items in pv_info under PARAVIRT_XXL umbrella Juergen Gross
2018-08-10 11:52 ` [PATCH 08/10] x86/paravirt: move the Xen-only pv_cpu_ops under the " Juergen Gross
2018-08-10 11:52 ` [PATCH 09/10] x86/paravirt: move the Xen-only pv_irq_ops " Juergen Gross
2018-08-10 11:52 ` [PATCH 10/10] x86/paravirt: move the Xen-only pv_mmu_ops " Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5B6D7FB402000078001DCF30@prv1-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=akataria@vmware.com \
--cc=boris.ostrovsky@oracle.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
--cc=virtualization@lists.linux-foundation.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®