From: zhong jiang <zhongjiang@huawei.com>
To: <dvhart@infradead.org>, <andy@infradead.org>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drviers: intel_ips: remove the unneeded null pointer check before debugfs_remove_recursive
Date: Fri, 17 Aug 2018 11:51:49 +0800 [thread overview]
Message-ID: <5B764655.7000803@huawei.com> (raw)
In-Reply-To: <1534476719-13480-1-git-send-email-zhongjiang@huawei.com>
subect: drviers/drivers will repost, please ingore the patch. Thanks
On 2018/8/17 11:31, zhong jiang wrote:
> debugfs_remove_recursive has taken the null pointer into account.
> just remove the null check before debugfs_remove_recursive.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> drivers/platform/x86/intel_ips.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/intel_ips.c b/drivers/platform/x86/intel_ips.c
> index c5ece7e..1c3127c 100644
> --- a/drivers/platform/x86/intel_ips.c
> +++ b/drivers/platform/x86/intel_ips.c
> @@ -1311,8 +1311,7 @@ static int ips_debugfs_open(struct inode *inode, struct file *file)
>
> static void ips_debugfs_cleanup(struct ips_driver *ips)
> {
> - if (ips->debug_root)
> - debugfs_remove_recursive(ips->debug_root);
> + debugfs_remove_recursive(ips->debug_root);
> return;
> }
>
prev parent reply other threads:[~2018-08-17 3:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-17 3:31 zhong jiang
2018-08-17 3:51 ` zhong jiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5B764655.7000803@huawei.com \
--to=zhongjiang@huawei.com \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome