From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752836Ab3GXSEp (ORCPT ); Wed, 24 Jul 2013 14:04:45 -0400 Received: from mga02.intel.com ([134.134.136.20]:33418 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751153Ab3GXSEo convert rfc822-to-8bit (ORCPT ); Wed, 24 Jul 2013 14:04:44 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.89,736,1367996400"; d="scan'208";a="375797120" From: "Winkler, Tomas" To: Greg KH CC: "arnd@arndb.de" , "linux-kernel@vger.kernel.org" , "Ovsyanikov, Natalia" Subject: RE: [char-misc-next 2/3] mei: adding sysfs fw_status attribute Thread-Topic: [char-misc-next 2/3] mei: adding sysfs fw_status attribute Thread-Index: AQHOiIb0dT8QWA0joUSnTutOsRQJK5l0Aa0g///P94CAAE2lEA== Date: Wed, 24 Jul 2013 18:04:33 +0000 Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B1AE73993@HASMSX106.ger.corp.intel.com> References: <1374680517-30894-1-git-send-email-tomas.winkler@intel.com> <1374680517-30894-3-git-send-email-tomas.winkler@intel.com> <20130724160008.GA17083@kroah.com> <5B8DA87D05A7694D9FA63FD143655C1B1AE738C0@HASMSX106.ger.corp.intel.com> <20130724162605.GA9700@kroah.com> In-Reply-To: <20130724162605.GA9700@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.184.70.13] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > > > Just to make sure, is this what you're suggesting ? > > > > device->groups = mei_attr_groups > > mei_misc_device.parent = device; > > ret = misc_register(&mei_misc_device); > > Yes, that should work. If not, please let me know, the code underwent some > changes in 3.11-rc2. I don' t see the file being created. Not sure if the misc_register setup the parent sysfs as well. Thanks Tomas