From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750994AbdAOHTK (ORCPT ); Sun, 15 Jan 2017 02:19:10 -0500 Received: from mga11.intel.com ([192.55.52.93]:53893 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750792AbdAOHTJ (ORCPT ); Sun, 15 Jan 2017 02:19:09 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,232,1477983600"; d="scan'208";a="1083166513" From: "Winkler, Tomas" To: Greg Kroah-Hartman , Paul Menzel CC: Jan Niehusmann , "Usyskin, Alexander" , "linux-kernel@vger.kernel.org" , "Chen, Yu C" , "Sarvela, Tomi P" , Thorsten Leemhuis , Daniel Blueman , "Brown, Len" Subject: RE: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer Thread-Topic: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer Thread-Index: AQHSa5Fjn7EKOu/NSEyf5LxpmjBVEaEyLxAAgADSYAD//+54gIAAKuWAgAAwiRD//+lKAIADDLAAgAH+hYCAAAN8gIAA5Ijg Date: Sun, 15 Jan 2017 07:19:03 +0000 Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B5437C2D3@hasmsx108.ger.corp.intel.com> References: <1484090841-16483-1-git-send-email-tomas.winkler@intel.com> <20170110224956.GA2897@x61s.reliablesolutions.de> <5B8DA87D05A7694D9FA63FD143655C1B5437A09D@hasmsx108.ger.corp.intel.com> <5B8DA87D05A7694D9FA63FD143655C1B5437A315@hasmsx108.ger.corp.intel.com> <20170113130018.GA896@kroah.com> <5549d8c0527412390d71236d80dff419@molgen.mpg.de> <20170114193959.GA30750@kroah.com> In-Reply-To: <20170114193959.GA30750@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDYzNTNiZGEtOWQ0NC00NzkwLTg2MzItZTY3NjBkMzE4MWYzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InRDWWN0cFZRckdaR3hFa0VUMFNpVHhtUUI5Qjc4cmdxZTBuNkxWVFZNUEE9In0= x-originating-ip: [10.184.70.11] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v0F7JFep018604 > Subject: Re: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT > and newer > > On Sat, Jan 14, 2017 at 08:27:31PM +0100, Paul Menzel wrote: > > Dear Greg, > > > > > > On 2017-01-13 14:00, Greg Kroah-Hartman wrote: > > > On Wed, Jan 11, 2017 at 03:26:06PM +0100, Paul Menzel wrote: > > > > > > On 01/11/17 15:12, Winkler, Tomas wrote: > > > > > > > > > > > On 01/11/17 10:24, Winkler, Tomas wrote: > > > > > > > > > > > > > > > > > > On Wed, Jan 11, 2017 at 01:27:21AM +0200, Tomas Winkler > wrote: > > > > > > > > > > On older platforms the command should be just ignored > > > > > > > > > > by the firmware but some older platforms misbehave so > > > > > > > > > > it's safer to send the command only if required. > > > > > > > > > > > > > > > > > > Thanks! This fixes suspend-to-ram for me (on a Thinkpad x201s). > > > > > > > > > > > > > > > > What about Dell XPS13? > > > > > > > > > > > > > > With Linus' master branch from today, and Greg's > > > > > > > char-misc-linus merged > > > > > > > (Merge: 807b93e995d1 546cf3ef9c92), the regression is still there. > > > > > > > > > > > > Hmm, this should work on KBL.... > > > > > > > > > > > > > I am now building a Linux kernel image with the two commits > > > > > > > touching > > > > > > > `bus- fixup.c` reverted. > > > > > > > > > > > > Thanks for the effort. > > > > > > > > > > > > > Do you want me to open a separate bug report for that, or > > > > > > > continue debugging in the existing report [1], which is currently > marked as resolved? > > > > > > > > > > > > Let's get some more data, shouldn't take long time. > > > > > > > > > > > > > > Do you have Kaby Lake devices sitting around for testing? > > > > > > > > > > > > We will of course try to reproduce the issue locally. > > > > > > > > > > Paul, currently we cannot reproduce this issue on Kaby Lake > > > > > platforms on our side, > > > > > > > > It looks like it’s a different issue. Reverting the two commits > > > > touching `bus-fixup.c`, did not help. > > > > > > > > > we would be great for more debug data from your side. > > > > > You can get more info by enabling mode debug logs > > > > > > > > > > echo -n 'module mei +lfp' > > > > > > /sys/kernel/debug/dynamic_debug/control > > > > > echo -n 'module mei_me +lfp' > > > > > > /sys/kernel/debug/dynamic_debug/control > > > > > > > > I am currently bisecting to find the culprit. 13 steps will take > > > > some time though. > > > > > > I can duplicate this on my laptop here as well :( > > > > Which system do you have? > > A Dell XPS13, don't know what cpu type it is, here's the output of one cpu from > /proc/cpuinfo > > processor : 3 > vendor_id : GenuineIntel > cpu family : 6 > model : 78 > model name : Intel(R) Core(TM) i7-6560U CPU @ 2.20GHz > stepping : 3 > microcode : 0x8a > cpu MHz : 712.207 > cache size : 4096 KB > physical id : 0 > siblings : 4 > core id : 1 > cpu cores : 2 > apicid : 3 > initial apicid : 3 > fpu : yes > fpu_exception : yes > cpuid level : 22 > wp : yes > flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca > cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx > pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl > xtopology nonstop_tsc aperfmperf eagerfpu pni pclmulqdq dtes64 monitor > ds_cpl vmx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid sse4_1 sse4_2 x2apic > movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm > 3dnowprefetch epb intel_pt tpr_shadow vnmi flexpriority ept vpid fsgsbase > tsc_adjust bmi1 avx2 smep bmi2 erms invpcid mpx rdseed adx smap clflushopt > xsaveopt xsavec xgetbv1 xsaves dtherm ida arat pln pts hwp hwp_notify > hwp_act_window hwp_epp > bugs : > bogomips : 4419.34 > clflush size : 64 > cache_alignment : 64 > address sizes : 39 bits physical, 48 bits virtual > power management: > > > > Did you get anywhere with your bisection? > > > > Sorry, I replied to a different message with my status. > > > > Please see my status below. I’ll have access to the machine on Monday > again. > > > > ``` > > $ git bisect log > > git bisect start > > # good: [69973b830859bc6529a7a0468ba0d80ee5117826] Linux 4.9 git > > bisect good 69973b830859bc6529a7a0468ba0d80ee5117826 > > # good: [69973b830859bc6529a7a0468ba0d80ee5117826] Linux 4.9 git > > bisect good 69973b830859bc6529a7a0468ba0d80ee5117826 > > # bad: [a121103c922847ba5010819a3f250f1f7fc84ab8] Linux 4.10-⁠rc3 git > > bisect bad a121103c922847ba5010819a3f250f1f7fc84ab8 > > # bad: [72cca7baf4fba777b8ab770b902cf2e08941773f] Merge tag > > 'staging-4.10-rc1' of > > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging > > git bisect bad 72cca7baf4fba777b8ab770b902cf2e08941773f > > # good: [b8d2798f32785398fcd1c48ea80c0c6c5ab88537] Merge tag 'clk-for- > linus' > > of git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux > > git bisect good b8d2798f32785398fcd1c48ea80c0c6c5ab88537 > > # good: [9439b3710df688d853eb6cb4851256f2c92b1797] Merge tag 'drm- > for-v4.10' > > of git://people.freedesktop.org/~airlied/linux > > git bisect good 9439b3710df688d853eb6cb4851256f2c92b1797 > > ``` > > > > You are close! I'll try bisection tomorrow if I have some spare time. > > thanks, Greg, is that same Laptop mode as Paul's, you've experience the issue on? Thanks Tomas