From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753190AbeCFIeM convert rfc822-to-8bit (ORCPT ); Tue, 6 Mar 2018 03:34:12 -0500 Received: from mga11.intel.com ([192.55.52.93]:53538 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752894AbeCFIeK (ORCPT ); Tue, 6 Mar 2018 03:34:10 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,430,1515484800"; d="scan'208";a="39561108" From: "Winkler, Tomas" To: Jarkko Sakkinen , Jason Gunthorpe CC: Jason Gunthorpe , "Usyskin, Alexander" , "linux-integrity@vger.kernel.org" , "linux-security-module@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH 3/3] tpm_crb: use __le64 annotated variable for response buffer address Thread-Topic: [PATCH 3/3] tpm_crb: use __le64 annotated variable for response buffer address Thread-Index: AQHTs7KLZZhpVtGdmECDIyA6qJ9KhKPBe78AgAFFgICAACHOcA== Date: Tue, 6 Mar 2018 08:34:03 +0000 Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B9422F07F@hasmsx108.ger.corp.intel.com> References: <20180304121205.16934-1-tomas.winkler@intel.com> <20180304121205.16934-3-tomas.winkler@intel.com> <20180305130320.GC3425@linux.intel.com> <20180306082821.GB5705@linux.intel.com> In-Reply-To: <20180306082821.GB5705@linux.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjBiNGY4ZDUtMTEwOS00MDFlLTg5OTQtYmZkOGQzNGE3OTlkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiI3SngyQlRjVWNUeGJuRlwvS0tWTjMrS0FLRGtcL2NGenVDU3l3cWk0NVoxMDRcL0hIUHNPUG9BdHlWdHd4M2ZxY09PIn0= dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.12.116.226] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Mon, Mar 05, 2018 at 03:03:20PM +0200, Jarkko Sakkinen wrote: > > On Sun, Mar 04, 2018 at 02:12:05PM +0200, Tomas Winkler wrote: > > > This suppresses sparse warning > > > drivers/char/tpm/tpm_crb.c:558:18: warning: cast to restricted > > > __le64 > > > > > > Signed-off-by: Tomas Winkler > > > --- > > > drivers/char/tpm/tpm_crb.c | 5 +++-- > > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > The guideline is that you should describe what is wrong rather than > > copy-paste the sparse message. > > Jason, didn't yo give the feedback to some patch 1-2 years ago that instead > of copy-pasting parse error one should write a clear commit msg or is this > OK? I think you are reading wrongly the rule, the title explains the issue and in addition I'm adding exact sparse warning. this is usually required. What is wrong is putting something like 'Fix sparse error' or "Fix warning' into patch subject. So the imperative here is 'adding annotation' and not a 'fixing a sparse message'. Thanks Tomas