From: zhong jiang <zhongjiang@huawei.com>
To: <rjw@rjwysocki.net>, <lenb@kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-acpi@vger.kernel.org>,
<jkosina@suse.cz>, <rafael.j.wysocki@intel.com>,
<rusty@rustcorp.com.au>
Subject: Re: [PATCH] acpi: remove a meaningless null check before debugfs_remove
Date: Thu, 6 Sep 2018 22:28:27 +0800 [thread overview]
Message-ID: <5B91398B.8060702@huawei.com> (raw)
In-Reply-To: <1534589360-64938-1-git-send-email-zhongjiang@huawei.com>
+to maintainers
On 2018/8/18 18:49, zhong jiang wrote:
> debugfs_remove has taken null pointer into account. So it is safe
> to remove the check before debugfs_remove.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> drivers/acpi/custom_method.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/custom_method.c b/drivers/acpi/custom_method.c
> index e967c11..4451877 100644
> --- a/drivers/acpi/custom_method.c
> +++ b/drivers/acpi/custom_method.c
> @@ -92,8 +92,7 @@ static int __init acpi_custom_method_init(void)
>
> static void __exit acpi_custom_method_exit(void)
> {
> - if (cm_dentry)
> - debugfs_remove(cm_dentry);
> + debugfs_remove(cm_dentry);
> }
>
> module_init(acpi_custom_method_init);
next prev parent reply other threads:[~2018-09-06 14:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-18 10:49 zhong jiang
2018-09-06 14:28 ` zhong jiang [this message]
2018-09-14 8:37 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5B91398B.8060702@huawei.com \
--to=zhongjiang@huawei.com \
--cc=jkosina@suse.cz \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rjw@rjwysocki.net \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome