From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.221.54 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794983078; b=l/oWApFQ6jrwBf7pVA3tJXx1g8pbAnoHMo3u9seWYAuH9heOGqJUDblPrpflcfPofFwO uLp1lqCp3n3PT+/+5zi22nr4Ldx5I+x541786RAJSWqLAUCLA1vsS1o0AQoeP/JQk3fAy xb+yt+zu9Lvoxep0BcZ2eURASuaPgT5EwThAqnOnbwlFTOgJn/YuwKI3B54p5kum6bGaj xMRJdBuXTwmso704i094q6sWcivpKHKxzpXm7v3SBwhgNt7h79iNf4bkebVqBuGSThfPv jxoSa5TVJoYd54TM0JfCokYLsNRYUeW64p64tff2DNdOwx2G4ify86N8pSMXtRGCgPA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794983078; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Content-Type:Content-Transfer-Encoding:From:Mime-Version:Subject:Date: Message-Id:References:Cc:In-Reply-To:To:X-Mailer; bh=na/KvaP9r6HHnCtVPiRJkOHiqbHZrFGDFwAb0LX3mh0=; b=pKXzZp1C42kQ/84oSce81WNUjELp2jj3OBHjHKsuiPxjOCwmmRfdDDPE0Y/Zy7TEOVWk QvdVF8/BPDoo/860er0nVLOCfOOJQXCbFaz42eeO03g5+cHXZOYReUtWUAHpPUwlqVcGJ m/myAZsNmlPj+eOGm6bbS8pAQ/Fhf263LyapJ3aIUiOdYHdaQpq4AN0AVXgrWz0bl+Ucu CZAgKZB4ed7Yhga/YOnx5KFg6mcNSkTUK150EDlIiApG8Btciq1m3Sdr0ZdlRtmN8XkKD oynMN7//wx0ehlmy7gi1+denEOZDwe3DtDQio7/xTN203oTHecLbqBiQHMmpH8o4mUQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=AztHoGjR; arc=none smtp.remote-ip=209.85.221.54 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9C37606A325 for ; Wed, 18 Nov 2026 06:24:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org C9C37606A325 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=AztHoGjR Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-498f5fa4f70so453677f8f.0 for ; Tue, 17 Nov 2026 22:24:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794983076; x=1795587876; darn=vger.kernel.org; h=to:in-reply-to:cc:references:message-id:date:subject:mime-version :from:content-transfer-encoding:content-type:from:to:cc:subject:date :message-id:reply-to:content-type; bh=na/KvaP9r6HHnCtVPiRJkOHiqbHZrFGDFwAb0LX3mh0=; b=AztHoGjRjFnPNy5DkAr00cNJqNbqzrXZSUaXAuai7KIeM8cqlWxyYmJoZp+NzNNzAX EP2Ue1M6w+ySbbDzoVCysgvgkynYoMX9NoCZ3uspbrx9bjdjAGXvKwnMZwNx4qvt4Vnw i6I9Z+b2DPJOh2Kz+TYg7vl45VpSabfQWg7OI4QSJ8Nln2pO9VUxqjZt8HSRP3tLA6cy 8glPMVNCJeE1+OqCEcuWGuVxetJ7/b959CY2XItoIpOVdeEFe1u/vQQyiNQsby6KdGU0 zo8Ad7d8jIu3MGdeCwcklXRk+5C7RP3vk2OMYEQW3qlbpm1aCwFRBLYVo4PkTg3QEisb lRRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794983076; x=1795587876; h=to:in-reply-to:cc:references:message-id:date:subject:mime-version :from:content-transfer-encoding:content-type:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=na/KvaP9r6HHnCtVPiRJkOHiqbHZrFGDFwAb0LX3mh0=; b=q/F0tR6M/xS71koQfkoSXxm8oode/ajqgBdoHr9do54t3LapHMWW/HLyunlcmBgD1+ Un1oYdZYvwbIXAI16ayWrQJXbCP9C6HEVY/hzW//aA+bIux23n/YGV4A7iexb0DQpJLB WrhnStNqH02TP7D0punlYj0X32NRwayJIYi6JaHUFE3vixCwchrjMU+w/WDjTBGsbKtF qTGxuiGXdmaHw2LloB+jZS1rVOpcMmXpkjMfkU3M/d9QKB65SJOMDywQ/cX1P3BfxRtk Ya6jiJO+TsGWBRqM52Ox2FKD5nK4T3u8s3XupphiGyx4KiymzH+tAheD2axmqyPBibSf 0Qbw== X-Forwarded-Encrypted: i=1; AL+hErEOyCEkex8yUKsR/M2L7cPz4BszmYAvNVFiRO39VHHAxwBkkWLBOAmxJUeL1CjW+FusrTpES5WWqvVjvpI=@vger.kernel.org X-Gm-Message-State: APuU4Z9h8nCIovJjTbxc23wdMfh9SX8/GbG/AQUbiY87y3QcsA/MilM2 fFrd1kfjJ3Xt3xgqsSBMIW29vmhKGR69zdg1PGsM/SuovSMgFA2+oJ4q X-Gm-Gg: AZFdTZdGM9AnS5/nEBr8L/27sXefNDAgbDU9002q68ri7+OPkmGCud0ZL7/ONGQsvn/ whNmF7rJTLvqGv/dtQcNUHnfUYwH9WwUEL38om59xh82G6C4t54oLEvHQi3O/Bov0sf2SAJV9ER B6jjz57E8gsFRb5sFAf6WnsjAANdnWG7rCOpkBYrZWShiv8wvrxS8ejjKTRhsDxw5gOR8PkpHaG Kc6C2aGWUcHz1kP5tNGZMUd2Ycf8BYtg/ITfHj7taxFceBo5F05fKdgsKOKss/vepoRiq5tb7QF rPZ+tH8/GGiYs99L82y3bW1BsT3jizEwfRncrjrR1GoqCNXYxe+7R+Tw6xQo+tB0dhmBh8b5Ud5 hspssXAAyoGRrCtUD//J9YtpzKKhByymxwnGFcc2nHQQV4WQmMFnhchzOxQcZyt3OahK3nmDUL1 TpN8Nj1Gr0ArgudRZkL6uLa+0pneOqEda2jZUohA2rG4/1RUXKRnzw1JYTXSOe/j27G/5QB0W5D wWLezuTHkFCrxNgpwfN5ShGoSt0qJVj0R3/ViXtodTf8rXpqXdRFO03Pm8S6jYFoCZ08IYnqYhu xNB/0kVCU3eCxuIS39meRFi45Mj6PP18UaRXqx0tOsgjBAZrot2iRLksdjWdpCzqXU5+PUvBTrX Kbelv/v4pm1L+HDxa6T9E3S4UtY1yeMAgU1g= X-Received: by 2002:a05:6000:4812:b0:490:6fbc:9457 with SMTP id ffacd0b85a97d-4a63c18831bmr3346488f8f.41.1794983075935; Tue, 17 Nov 2026 22:24:35 -0800 (PST) Received: from smtpclient.apple ([2a05:b100:188e:3c00:e0ee:5dba:4f48:db8d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4a654997681sm2289481f8f.15.2026.11.17.22.24.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2026 22:24:34 -0800 (PST) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: teolyub@gmail.com X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 (1.0) Subject: Re: [PATCH 1/2] platform/x86: dell: Add new dell-wmi-pega driver Date: Wed, 18 Nov 2026 06:24:22 +0000 Message-Id: <5C8178E2-6BDF-4110-82FA-0AA4628DEFB6@gmail.com> References: <848ebb18-b9bf-4747-9403-fa8da4fba2ad@gmx.de> Cc: =?utf-8?Q?Ilpo_J=C3=A4rvinen?= , Hans de Goede , platform-driver-x86@vger.kernel.org, LKML In-Reply-To: <848ebb18-b9bf-4747-9403-fa8da4fba2ad@gmx.de> To: Armin Wolf X-Mailer: iPhone Mail (24A446) Hi all - please proceed with the patch and thank you all for your work! Sent from my mighty iPhone 13 mini > On 17 Nov 2026, at 22:31, Armin Wolf wrote: >=20 > =EF=BB=BFAm 17.11.26 um 23:17 schrieb Ilpo J=C3=A4rvinen: >>> On Tue, 17 Nov 2026, Armin Wolf wrote: >>> A user has reported that the WMI hotkey events on Dell All-In-One >>> machines need to be manually enabled on some models thru a separate >>> WMI device. This WMI device seems to be present on many other models >>> but has no effect on them. >> Can you rephrase this to not textually depend on "user" or "user's >> report", just state what the problem is, not how you became aware of it. >>> Add a small driver for enabling support for this WMI device. This >>> enables the HDMI Input key on the Dell OptiPlex 7400 All-in-One >>> machine. >>>=20 >>> Reported-by: Teodora >>> Closes: https://lore.kernel.org/platform-driver-x86/0TZENT.54P2IBFQRED22= @gmail.com >>> Tested-by: Teodora >>> Signed-off-by: Armin Wolf >>> --- >>> Documentation/wmi/devices/dell-wmi-pega.rst | 82 ++++++++++++++++++ >>> MAINTAINERS | 6 ++ >>> drivers/platform/x86/dell/Kconfig | 13 +++ >>> drivers/platform/x86/dell/Makefile | 1 + >>> drivers/platform/x86/dell/dell-wmi-pega.c | 93 +++++++++++++++++++++ >>> 5 files changed, 195 insertions(+) >>> create mode 100644 Documentation/wmi/devices/dell-wmi-pega.rst >>> create mode 100644 drivers/platform/x86/dell/dell-wmi-pega.c >>>=20 >>> diff --git a/Documentation/wmi/devices/dell-wmi-pega.rst b/Documentation= /wmi/devices/dell-wmi-pega.rst >>> new file mode 100644 >>> index 000000000000..935c8511594b >>> --- /dev/null >>> +++ b/Documentation/wmi/devices/dell-wmi-pega.rst >>> @@ -0,0 +1,82 @@ >>> +.. SPDX-License-Identifier: GPL-2.0-or-later >>> + >>> +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D >>> +Dell All-In-One Series Platform Integration (dell-wmi-pega) >>> +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D >>> + >>> +Introduction >>> +------------ >>> + >>> +Many Dell All-In-One devices contain a WMI device for notifying the und= erlying platform >>> +of various OS-specific events like power up, shutdown and backlight bri= ghtness control. >>> + >>> +Not implementing support for this WMI device might prevent hotkeys expo= sed over WMI from >>> +working on some models. >>> + >>> +WMI interface description >>> +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D >>> + >>> +The WMI interface description can be decoded from the embedded binary M= OF (bmof) >>> +data using the `bmfdec `_ utility: >>> + >>> +:: >>> + >>> + [WMI, Dynamic, Provider("WmiProv"), Locale("MS\\0x409"), >>> + Description("Class used to operate method - WMBC"), >>> + guid("{2D703EE8-36AC-4F88-BDB5-7556CE6B2946}") : ToInstance] >>> + class AcpiOSD_WMBC_method : WMIMethod { >>> + >>> + [key, read] >>> + string InstanceName; >>> + >>> + [read] >>> + boolean Active; >>> + >>> + [WmiMethodId(1), Implemented, read, write, >>> + Description("Invoked by AP when system up.")] >>> + void PegaOemNotificationStartUp([out, Description("Return Value")] u= int32 RetVal); >>> + >>> + [WmiMethodId(2), Implemented, read, write, >>> + Description("Invoked by AP when system is going to off state.")] >>> + void PegaOemNotificationStop([out, Description("Return Value")] uint= 32 RetVal); >>> + >>> + [WmiMethodId(3), Implemented, read, write, >>> + Description("Invoked by Application to tune up brightness.")] >>> + void PegaOemNotificationBrightnessUP([out, Description("Return Value= ")] uint32 RetVal); >>> + >>> + [WmiMethodId(4), Implemented, read, write, >>> + Description("Invoked by Application to tune down brightness.")] >>> + void PegaOemNotificationBrightnessDown([out, Description("Return Val= ue")] uint32 RetVal); >>> + >>> + [WmiMethodId(5), Implemented, read, write, Description("Reserved.")]= >>> + void PegaOemNotificationRSVD1([out, Description("Return Value")] uin= t32 RetVal); >>> + >>> + [WmiMethodId(6), Implemented, read, write, Description("Reserved.")]= >>> + void PegaOemNotificationRSVD2([out, Description("Return Value")] uin= t32 RetVal); >>> + }; >>> + >>> +The return value of each WMI method should be equal to the WMI method I= D. >>> + >>> +WMI method PegaOemNotificationStartUp() >>> +--------------------------------------- >>> + >>> +Notifies the platform that the OS is operational. On some models this W= MI method also enables >>> +reporting of hotkey events over WMI. >>> + >>> +WMI method PegaOemNotificationStop() >>> +------------------------------------ >>> + >>> +Notifies the platform that the OS is shutting down. >>> + >>> +WMI method PegaOemNotificationBrightnessUP() >>> +-------------------------------------------- >>> + >>> +Notifies the platform that the user wants to increase the backlight bri= ghtness. This WMI method >>> +usually only forwards this request to the acpi-video driver, so the del= l-wmi-pega driver does >>> +not use it. >> Could these paragraphs be reflowed to 80 chars as long textual lines are >> harder to read (eye movement required). >=20 > Sure, will do. >=20 >>> +WMI method PegaOemNotificationBrightnessDown() >>> +---------------------------------------------- >>> + >>> +Notifies the platform that the user wants to decrease the backlight bri= ghtness. See >>> +``PegaOemNotificationBrightnessUP()`` for details. >>> diff --git a/MAINTAINERS b/MAINTAINERS >>> index bd31e734669e..fb9a80f96900 100644 >>> --- a/MAINTAINERS >>> +++ b/MAINTAINERS >>> @@ -7534,6 +7534,12 @@ M: Pali Roh=C3=A1r >>> S: Maintained >>> F: drivers/platform/x86/dell/dell-wmi-base.c >>> +DELL WMI PEGA DRIVER >>> +M: Armin Wolf >>> +S: Odd Fixes >>> +F: Documentation/wmi/devices/dell-wmi-pega.rst >>> +F: drivers/platform/x86/dell/dell-wmi-pega.c >>> + >>> DELL WMI SYSMAN DRIVER >>> M: Prasanth Ksr >>> L: Dell.Client.Kernel@dell.com >>> diff --git a/drivers/platform/x86/dell/Kconfig b/drivers/platform/x86/de= ll/Kconfig >>> index 9f0016056d7e..289379383ccb 100644 >>> --- a/drivers/platform/x86/dell/Kconfig >>> +++ b/drivers/platform/x86/dell/Kconfig >>> @@ -228,6 +228,7 @@ config DELL_WMI_AIO >>> depends on ACPI_WMI >>> depends on INPUT >>> select INPUT_SPARSEKMAP >>> + imply DELL_WMI_PEGA >>> help >>> Say Y here if you want to support WMI-based hotkeys on Dell >>> All-In-One machines. >>> @@ -262,6 +263,18 @@ config DELL_WMI_LED >>> This adds support for the Latitude 2100 and similar >>> notebooks that have an external LED. >>> +config DELL_WMI_PEGA >>> + tristate "Dell WMI AIO Platform Support" >>> + default m >>> + depends on ACPI_WMI >>> + help >>> + This option adds support for WMI-based platform integration on De= ll All-In-One machines. >>> + This driver is necessary for enabling the delivery of hotkey even= ts to the dell-wmi-aio >>> + driver on some machines. >>> + >>> + To compile this drivers as a module, choose M here: the module wi= ll be called >>> + dell-wmi-pega. >>> + >>> config DELL_WMI_SYSMAN >>> tristate "Dell WMI-based Systems management driver" >>> default m >>> diff --git a/drivers/platform/x86/dell/Makefile b/drivers/platform/x86/d= ell/Makefile >>> index 470874c6e6e6..46c91c240a2c 100644 >>> --- a/drivers/platform/x86/dell/Makefile >>> +++ b/drivers/platform/x86/dell/Makefile >>> @@ -27,5 +27,6 @@ obj-$(CONFIG_DELL_WMI_AIO) +=3D dell-wmi-ai= o.o >>> obj-$(CONFIG_DELL_WMI_DESCRIPTOR) +=3D dell-wmi-descriptor.o >>> obj-$(CONFIG_DELL_WMI_DDV) +=3D dell-wmi-ddv.o >>> obj-$(CONFIG_DELL_WMI_LED) +=3D dell-wmi-led.o >>> +obj-$(CONFIG_DELL_WMI_PEGA) +=3D dell-wmi-pega.o >>> obj-$(CONFIG_DELL_WMI_SYSMAN) +=3D dell-wmi-sysman/ >>> obj-$(CONFIG_DELL_DW5826E_RESET) +=3D dell-dw5826e-reset.o >>> diff --git a/drivers/platform/x86/dell/dell-wmi-pega.c b/drivers/platfor= m/x86/dell/dell-wmi-pega.c >>> new file mode 100644 >>> index 000000000000..ddb1b6cc6b1c >>> --- /dev/null >>> +++ b/drivers/platform/x86/dell/dell-wmi-pega.c >>> @@ -0,0 +1,93 @@ >>> +// SPDX-License-Identifier: GPL-2.0-or-later >>> +/* >>> + * WMI platform integration for Dell All-In-One series. >>> + * >>> + * Copyright (C) 2026 Armin Wolf >>> + * >>> + * Based on earlier work by Teodora . >>> + */ >>> + >>> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt >>> + >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >> What for is this? >> I suspect direct device.h include isn't necessary either (and it's >> anyway guaranteed to come through wmi.h). >=20 > Good question, i copied it from one of the other WMI drivers. >=20 > I will remove both includes in the next revision. >=20 >>> +#include >>> +#include >>> +#include >>> +#include >>> + >>> +#define PEGA_GUID "2D703EE8-36AC-4F88-BDB5-7556CE6B2946" >>> + >>> +enum dell_pega_method { >>> + DELL_PEGA_NOTIFICATION_STARTUP =3D 0x01, >>> + DELL_PEGA_NOTIFICATION_STOP =3D 0x02, >>> + DELL_PEGA_NOTIFICATION_BRIGHTNESS_UP =3D 0x03, >>> + DELL_PEGA_NOTIFICATION_BRIGHTNESS_DOWN =3D 0x04, >>> + DELL_PEGA_NOTIFICATION_RESERVED_1 =3D 0x05, >>> + DELL_PEGA_NOTIFICATION_RESERVED_2 =3D 0x06, >>> +}; >>> + >>> +static int dell_wmi_pega_invoke(struct wmi_device *wdev, enum dell_pega= _method method) >>> +{ >>> + struct wmi_buffer input =3D { }; >>> + struct wmi_buffer output; >>> + int ret; >>> + >>> + ret =3D wmidev_invoke_method(wdev, 0x0, method, &input, &output, si= zeof(__le32)); >>> + if (ret < 0) >>> + return ret; >>> + >>> + __le32 *result __free(kfree) =3D output.data; >>> + /* The return value should always be equal to the WMI method ID */ >>> + if (le32_to_cpu(*result) !=3D method) >> Include for le32_to_cpu() >=20 > What would be the correct include for this? >=20 >>> + return -EIO; >>> + >>> + return 0; >>> +} >>> + >>> +static int dell_wmi_pega_probe(struct wmi_device *wdev, const void *con= text) >>> +{ >>> + int ret; >>> + >>> + ret =3D dell_wmi_pega_invoke(wdev, DELL_PEGA_NOTIFICATION_STARTUP);= >>> + if (ret < 0) >>> + dev_err(&wdev->dev, >>> + "Failed to notify platform of startup, some hotkeys might n= ot work\n"); >> braces for multiline constructs. >>> + >>> + return ret; >>> +} >>> + >>> +static void dell_wmi_pega_shutdown(struct wmi_device *wdev) >>> +{ >>> + int ret; >>> + >>> + ret =3D dell_wmi_pega_invoke(wdev, DELL_PEGA_NOTIFICATION_STOP); >>> + if (ret < 0) >>> + dev_warn(&wdev->dev, "Failed to notify platform of shutdown\n")= ; >>> +} >>> + >>> +static const struct wmi_device_id dell_wmi_pega_id_table[] =3D { >>> + { PEGA_GUID, NULL }, >>> + { } >>> +}; >>> +MODULE_DEVICE_TABLE(wmi, dell_wmi_pega_id_table); >>> + >>> +static struct wmi_driver dell_wmi_pega_driver =3D { >>> + .driver =3D { >>> + .name =3D "dell-wmi-pega", >>> + .probe_type =3D PROBE_PREFER_ASYNCHRONOUS, >>> + }, >>> + .id_table =3D dell_wmi_pega_id_table, >>> + .probe =3D dell_wmi_pega_probe, >>> + .remove =3D dell_wmi_pega_shutdown, >>> + .shutdown =3D dell_wmi_pega_shutdown, >>> + .no_singleton =3D true, >>> +}; >>> +module_wmi_driver(dell_wmi_pega_driver); >>> + >>> +MODULE_AUTHOR("Armin Wolf "); >>> +MODULE_DESCRIPTION("Dell All-In-One series platform integration"); >>> +MODULE_LICENSE("GPL"); >> Just the mandatory nitpicking :-), seems fine otherwise. >=20 > Thanks, >=20 > i will wait with sending a v2 until Teodora has tested the second patch. >=20 > Thanks, > Armin Wolf