Re: [PATCH v3 0/2] staging: rtl8723bs: clean up rtw_joinbss_event_prehandle

[Luka Gejak <luka.gejak@linux.dev>]

On March 20, 2026 4:47:15 PM GMT+01:00, "Jose A. Perez de Azpillaga" <azpijr@gmail.com> wrote:
>This series cleans up the rtw_joinbss_event_prehandle function in the
>rtl8723bs staging driver.
>
>The first patch removes dead code guarded by the REJOIN macro, which is
>never defined in the kernel. This simplifies the function before the
>subsequent refactor.
>
>The second patch refactors the function using guard clauses and early
>returns to reduce deep indentation, improving overall readability.
>
>v3:
>- Removed the 'retry' variable which became dead after REJOIN
>  removal.
>- Remoed the 'ignore_joinbss_callback' label and use direct
>  returns.
>- Preserve the original comment for the join_res <= 0 case.
>- Keep the original newline for the netdev_dbg call.
>- Moved the 's5' comment after the spin_unlock_bh call to match
>  original placement.
>
>v2:
>- Split the original patch into a two-patch series.
>- Changed the subject line.
>- Removed all REJOIN-related dead code.
>- Fixed a typo in the ptarget_sta comment.
>- Avoided unnecessary changes.
>
>Jose A. Perez de Azpillaga (2):
>  staging: rtl8723bs: remove dead REJOIN code
>  staging: rtl8723bs: refactor rtw_joinbss_event_prehandle to reduce
>    indentation
>
> drivers/staging/rtl8723bs/core/rtw_mlme.c | 156 ++++++++++------------
> 1 file changed, 69 insertions(+), 87 deletions(-)
>
>--
>2.53.0
>

Small spelling mistake in cover letter ->Remoed instead of Removed, 
however this is in cover letter so it shouldn't be a problem. 
Other than that, it looks good to me.

Reviewed-by: Luka Gejak <luka.gejak@linux.dev>