From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: ARC-Seal: i=1; a=rsa-sha256; t=1517152948; cv=none; d=google.com; s=arc-20160816; b=AiCbB4DFLEZC1JvYNebYAfZjWKrXj7a6jba/eVsK2hwM6KawKyOj+E2XP4lU/fQmlj KfAXeOF9Bgl2/1mL+eUwd70K+fE4XyOcgf3et26CdZQCn/5xLnaw/ban4FqpEMSzqiPc ehAog1IhO2qj4AhErgL00/I7/e0dyQFjR1tsGIvnTE9Wt5fuBsLxFw8eWTYMqtcVVWKm vi82a0Kt5kd6BC1dWgAzRgJg2aw68JeyuKS2qlfFLS+/9orN8vQIDjcwbihOpR5rkkRb 0+c5vqfNSSzBh3aqdjqVoqWs+ak9ZFAZbyiLtbS8GSVTrkGSLh+ef8kfi2DFVoym6HyL Pwew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:dkim-signature :arc-authentication-results; bh=hOUGQj1Hsd+RmxWOzvsSOmVQP56lIYRU0W2rQVFGRKI=; b=RXzDiwtEBuad+Y6+CelytpgjZszoYNmNjfQ9dwptaKb2RVu5nPptJZYXmdVAyvY2mB mcS/JNIdJ1Kk7JTpgQCHCO5EvTKaB+kkD2rpEc8h5w3qcQ4xnB7JIUWhSjZxEeBLLCld nPmd0b8ji1DoqOrpDIOOmiiEvpnWzKQ+TywcfTKKlKDuEsjc9xNRLj6S/YxW2/YfX/bJ mfgpyt70zWFsN6mw5nV/7jl+4zu1XGzcXGhM0fTRncU6/i3XrDsJu83lE5+95wsM/YY/ jygwTJ8b2O5t5sCter7BOt0WGt3Bdti1/+B/vba9g5ufC23OkA+8qtI5gvyPrEfS3inN mm+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amacapital-net.20150623.gappssmtp.com header.s=20150623 header.b=ljqeOSRw; spf=pass (google.com: domain of luto@amacapital.net designates 209.85.220.41 as permitted sender) smtp.mailfrom=luto@amacapital.net Authentication-Results: mx.google.com; dkim=pass header.i=@amacapital-net.20150623.gappssmtp.com header.s=20150623 header.b=ljqeOSRw; spf=pass (google.com: domain of luto@amacapital.net designates 209.85.220.41 as permitted sender) smtp.mailfrom=luto@amacapital.net X-Google-Smtp-Source: AH8x226S1uvjieDIBE++RMbncStcOE02cccPEJtbemV8RfxLrH6LvbQFcoJFiqC1+1iUkVLham7nVg== Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: [PATCH v5 07/12] x86: remove the syscall_64 fast-path From: Andy Lutomirski X-Mailer: iPhone Mail (15C202) In-Reply-To: <20180128092914.dabnzq7arv4bebhn@gmail.com> Date: Sun, 28 Jan 2018 07:22:26 -0800 Cc: Dan Williams , tglx@linutronix.de, linux-arch@vger.kernel.org, kernel-hardening@lists.openwall.com, gregkh@linuxfoundation.org, x86@kernel.org, Ingo Molnar , Andy Lutomirski , "H. Peter Anvin" , torvalds@linux-foundation.org, alan@linux.intel.com, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: <5CF96758-5FD5-49BB-80E8-951AF5AB2B68@amacapital.net> References: <151703971300.26578.1185595719337719486.stgit@dwillia2-desk3.amr.corp.intel.com> <151703975137.26578.11230688940391207602.stgit@dwillia2-desk3.amr.corp.intel.com> <20180128092914.dabnzq7arv4bebhn@gmail.com> To: Ingo Molnar X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590732047884904390?= X-GMAIL-MSGID: =?utf-8?q?1590850169984252136?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: > On Jan 28, 2018, at 1:29 AM, Ingo Molnar wrote: >=20 >=20 > * Dan Williams wrote: >=20 >> Quoting Linus: >>=20 >> "Honestly, I'd rather get rid of the fast-path entirely. Compared to >> all the PTI mess, it's not even noticeable. >>=20 >> And if we ever get CPU's that have this all fixed, we can re-visit >> introducing the fastpath. But this is all very messy and it doesn't >> seem worth it right now. >>=20 >> If we get rid of the fastpath, we can lay out the slow path slightly >> better, and get rid of some of those jump-overs. And we'd get rid of >> the ptregs hooks entirely. >>=20 >> So we can try to make the "slow" path better while at it, but I >> really don't think it matters much now in the post-PTI era. Sadly." >=20 > Please fix the title to have the proper prefix and to reference the functi= on that=20 > is actually modified by the patch, i.e. something like: >=20 > s/ x86: remove the syscall_64 fast-path > / x86/entry/64: Remove the entry_SYSCALL_64() fast-path >=20 > With the title fixed: >=20 > Reviewed-by: Ingo Molnar I have a very similar but not quite identical version I'll send out shortly.= The difference is that I fixed the silly prologue. >=20 > Thanks, >=20 > Ingo