From: "Bae, Chang Seok" <chang.seok.bae@intel.com>
To: Tom Lendacky <thomas.lendacky@amd.com>
Cc: "Christopherson, Sean J" <sean.j.christopherson@intel.com>,
"Andy Lutomirski" <luto@kernel.org>,
Joerg Roedel <joro@8bytes.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
X86 ML <x86@kernel.org>, Thomas Gleixner <tglx@linutronix.de>,
Sasha Levin <sashal@kernel.org>, Borislav Petkov <bp@alien8.de>,
Peter Zijlstra <peterz@infradead.org>,
"Ingo Molnar" <mingo@kernel.org>,
"Hansen, Dave" <dave.hansen@intel.com>,
"Shankar, Ravi V" <ravi.v.shankar@intel.com>
Subject: Re: FSGSBASE causing panic on 5.9-rc1
Date: Thu, 20 Aug 2020 18:43:10 +0000 [thread overview]
Message-ID: <5D0385FC-D535-457A-A0D9-E5F013F301BE@intel.com> (raw)
In-Reply-To: <362f5a45-b808-25ad-b99b-449e05717c4a@amd.com>
> On Aug 20, 2020, at 08:21, Tom Lendacky <thomas.lendacky@amd.com> wrote:
> On 8/20/20 10:10 AM, Sean Christopherson wrote:
>>
>> Pretty sure current->thread.gsbase can be stale, i.e. this needs:
>> current_save_fsgs();
>
> I did try adding current_save_fsgs() in svm_vcpu_load(), saving the current->thread.gsbase value to a new variable in the svm struct. I then used that variable in the wrmsrl below, but it still crashed.
Then, current->thread.gsbase is from __rdgsbase_inactive() which is
user GSBASE.
If you do the wrmsrl below, it overwrites the current GSBASE with the
user value.
>> wrmsrl(MSR_KERNEL_GS_BASE, current->thread.gsbase);
Thanks,
Chang
next prev parent reply other threads:[~2020-08-20 18:43 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 18:07 Tom Lendacky
2020-08-19 18:19 ` Tom Lendacky
2020-08-19 21:25 ` Andy Lutomirski
2020-08-20 0:21 ` Andy Lutomirski
2020-08-20 15:10 ` Sean Christopherson
2020-08-20 15:21 ` Tom Lendacky
2020-08-20 15:55 ` Andy Lutomirski
2020-08-20 16:17 ` Tom Lendacky
2020-08-20 16:30 ` Tom Lendacky
2020-08-20 17:41 ` Paolo Bonzini
2020-08-20 18:34 ` Tom Lendacky
2020-08-20 18:38 ` Jim Mattson
2020-08-20 18:39 ` Jim Mattson
2020-08-20 18:41 ` Tom Lendacky
2020-08-20 19:04 ` Tom Lendacky
2020-08-20 19:05 ` Tom Lendacky
2020-08-20 20:07 ` Dave Hansen
2020-08-20 20:15 ` Tom Lendacky
2020-08-20 20:36 ` Andy Lutomirski
2020-08-20 22:05 ` Sean Christopherson
2020-08-20 22:07 ` Andy Lutomirski
2020-08-20 22:34 ` Sean Christopherson
2020-08-21 0:00 ` Tom Lendacky
2020-08-21 1:56 ` Sean Christopherson
2020-08-20 18:43 ` Bae, Chang Seok [this message]
2020-08-20 13:43 ` Paolo Bonzini
2020-08-20 17:51 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5D0385FC-D535-457A-A0D9-E5F013F301BE@intel.com \
--to=chang.seok.bae@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=ravi.v.shankar@intel.com \
--cc=sashal@kernel.org \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®