mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: zhang warden <zhangwarden@gmail.com>
To: Josh Poimboeuf <jpoimboe@kernel.org>
Cc: Miroslav Benes <mbenes@suse.cz>, Jiri Kosina <jikos@kernel.org>,
	Petr Mladek <pmladek@suse.com>,
	Joe Lawrence <joe.lawrence@redhat.com>,
	live-patching@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests: livepatch: add test case of stack_order sysfs interface
Date: Tue, 8 Oct 2024 09:51:25 +0800	[thread overview]
Message-ID: <5D4255CE-1AA3-41BB-A6CA-784E60560333@gmail.com> (raw)
In-Reply-To: <20241007173909.klwdxcui6slmod2a@treble>


Hi, Josh.
> On Oct 8, 2024, at 01:39, Josh Poimboeuf <jpoimboe@kernel.org> wrote:
> 
> On Mon, Oct 07, 2024 at 10:11:39PM +0800, Wardenjohn wrote:
>> Add test case of stack_order sysfs interface of livepatch.
>> 
>> Signed-off-by: Wardenjohn <zhangwarden@gmail.com>
>> ---
>> .../testing/selftests/livepatch/test-sysfs.sh | 24 +++++++++++++++++++
>> 1 file changed, 24 insertions(+)
>> 
>> diff --git a/tools/testing/selftests/livepatch/test-sysfs.sh b/tools/testing/selftests/livepatch/test-sysfs.sh
>> index 05a14f5a7bfb..81776749a4e3 100755
>> --- a/tools/testing/selftests/livepatch/test-sysfs.sh
>> +++ b/tools/testing/selftests/livepatch/test-sysfs.sh
>> @@ -19,6 +19,7 @@ check_sysfs_rights "$MOD_LIVEPATCH" "enabled" "-rw-r--r--"
>> check_sysfs_value  "$MOD_LIVEPATCH" "enabled" "1"
>> check_sysfs_rights "$MOD_LIVEPATCH" "force" "--w-------"
>> check_sysfs_rights "$MOD_LIVEPATCH" "replace" "-r--r--r--"
>> +check_sysfs_rights "$MOD_LIVEPATCH" "stack_order" "-r--r--r--"
>> check_sysfs_rights "$MOD_LIVEPATCH" "transition" "-r--r--r--"
>> check_sysfs_value  "$MOD_LIVEPATCH" "transition" "0"
>> check_sysfs_rights "$MOD_LIVEPATCH" "vmlinux/patched" "-r--r--r--"
>> @@ -131,4 +132,27 @@ livepatch: '$MOD_LIVEPATCH': completing unpatching transition
>> livepatch: '$MOD_LIVEPATCH': unpatching complete
>> % rmmod $MOD_LIVEPATCH"
>> 
>> +start_test "sysfs test stack_order read"
>> +
>> +load_lp $MOD_LIVEPATCH
>> +
>> +check_sysfs_rights "$MOD_LIVEPATCH" "stack_order" "-r--r--r--"
>> +check_sysfs_value  "$MOD_LIVEPATCH" "stack_order" "1"
> 
> At the very least this should load more than one module so it can verify
> the stack orders match the load order.
> 
> -- 
> Josh

I got it. And I found more test modules in selftests/livepatch/test_modules

I will fix this problem with the modules inside.

Thank you!

Regards.
Wardenjohn.


      reply	other threads:[~2024-10-08  1:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-07 14:11 Wardenjohn
2024-10-07 17:39 ` Josh Poimboeuf
2024-10-08  1:51   ` zhang warden [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5D4255CE-1AA3-41BB-A6CA-784E60560333@gmail.com \
    --to=zhangwarden@gmail.com \
    --cc=jikos@kernel.org \
    --cc=joe.lawrence@redhat.com \
    --cc=jpoimboe@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    --cc=mbenes@suse.cz \
    --cc=pmladek@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®