From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from MW6PR02CU001.outbound.protection.outlook.com (mail-westus2azon11012036.outbound.protection.outlook.com [52.101.48.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 489F86FC3; Sun, 12 Apr 2026 01:37:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.48.36 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775957867; cv=fail; b=pwIaxwdTLCTA2HRhRHSWsthM9QRAAq+eGW6tjdKaGMWh3ILvFQkqZGswtL/zQmOgfh0ZuAQxvJTC3ihzZeQDXwVlRVNR4b8AU7qPO4zZQScxATJSMWIVm5N5LtUVuOIOa72klpkyGGuhTKY8GTYDRZgb3MF/LPtYxIiTkuEt8YI= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775957867; c=relaxed/simple; bh=JbFdLj0c7BtiexBhGoib3+vr8YMJRNizWGenBHgeXsw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=FyF1Lj5Wq/pjCrCca9OoXZ0PJt8kYTqZVwanrvH/4TUWNMhWcUk5ZaW1+8zaNl/6LS0STTKNIe1Fvwn7QE1iKxPyghHnGW9RTOGTY6gXKb7n9ARrmEdGUGodbEy5zkJ299Cd8xLhIgs2+6qFnShTxeIUsN3XXgRM6SR5zOXNq9U= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=oJwkbP6Q; arc=fail smtp.client-ip=52.101.48.36 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="oJwkbP6Q" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tKmFFDICrgmuJ6mKnqB6nZK1ITljHfQ6DqaDZhYtWgb2xKKXYPXcoYAALcRq5WTQs2jlwuLDkwtS6TnhDk51XnDyJFrn7ZIyrSHCaz5PGd2BeAR/D6NoYQxWC2fJiCyRyo9IlBWTwrDzT1G99gAHafdLaPMtNNda3IMYSJqI87RaIX7QuUJRuoCUbFMBWlsJ0t+59juo69J230coVKZPOJitNp+90DOX5FIAtNRZWo+Ho+YrZy0L5lE2/zfP0kBQlcv6V9dKl08KVkkxPsgY8MnzNwghQGvipOwEpYGWYnzvYmnJetIsi92HbLsl+q2Qtm7tMa9CwIX99I6Gq2370g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RO45sYd6Yll3sX7NPzk3T8bKiDYgTE1LYxWhPE0z7Pw=; b=w3R5cxSrtU2GRT4ISUxDy5pTbrlRrJUNyB7/TUm5YYpx53w1gPwOuMDdZVHqm+xjIPJFS7bEgrPjyAGuFXl49iOVZc9MHh6JpsTuoHt2x5XE8fN3w+mCZv8QovxjI/6IWzZ7T7k/uE0QEqMy9r1F4jHz/gJgQmKn1kzaiSFtEclFkEIFhKRWNFIEo0f3y8/QUcS8h4He7juiGGM0fFabQ875h3iqN4oV178D8heaBnQDVw7Y1xXVD7xCQn3Kr1XNmGHoljEBVncMv+0Ea5vQj+WgDPwFC3arSSUODFziybYnJ40YFmPe5mc4HEJcBExW5sqYzHK9RDOrUibpK1o76w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RO45sYd6Yll3sX7NPzk3T8bKiDYgTE1LYxWhPE0z7Pw=; b=oJwkbP6QS6Hkmo+pBZ0gDH5L8EL7I7q343paTzCdk0rYal3l/v12CVKXTZ4u0sKFQSGRB4dAAf5EnV8xmZ8tM7baAegroeKFuR3tvI9aV682SG7JOQChpFva8M6rj3aXBwrXvrfGNauGf9qfwDXuj4mmlkFprg3/IlQWdgc9qucxv3wWL1c4C22IbmAF91qYEPYlMRK1wVZ5jOesO3D6YSFWEG7rJDDMfdPJbXuuJmsOX4LAijuXpApCkKXuf3+GCSN4yzqFchtNDaqOPFftrCEDG7MjSjSAbIjjFLFQcpf0Jv7PcHgIFi0cXLDwoC2zh3+rCAbk3A6BmNxwm12lvQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by IA1PR12MB7709.namprd12.prod.outlook.com (2603:10b6:208:423::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.45; Sun, 12 Apr 2026 01:37:41 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::f01d:73d2:2dda:c7b2]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::f01d:73d2:2dda:c7b2%4]) with mapi id 15.20.9769.044; Sun, 12 Apr 2026 01:37:41 +0000 From: Zi Yan To: Guangshuo Li Cc: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] mm: thp: Fix refcount leak in thpsize_create() error path Date: Sat, 11 Apr 2026 21:37:39 -0400 X-Mailer: MailMate (2.0r6290) Message-ID: <5D47664D-8997-4A3F-A4FB-08144591C5B3@nvidia.com> In-Reply-To: <20260411062152.2092967-1-lgs201920130244@gmail.com> References: <20260411062152.2092967-1-lgs201920130244@gmail.com> Content-Type: text/plain X-ClientProxiedBy: BL1PR13CA0015.namprd13.prod.outlook.com (2603:10b6:208:256::20) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|IA1PR12MB7709:EE_ X-MS-Office365-Filtering-Correlation-Id: 56390c5a-7565-4a71-602c-08de98341634 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|1800799024|366016|18002099003|22082099003|56012099003; X-Microsoft-Antispam-Message-Info: GO9m6xp7D/u+Cgm0Ggj8hqKKnBu8/mwB3Dv/Al/5QpWzQNgSxnL36biv4edm325Zbv5nxuZKdM877UQeOUTHwCSeA9zYaL2jrxRTiyYW3eExy1p/eSlI3JFSYH6w3E+fTC/aZzoGA3FWWufhqlBXH+9gDtJYUMLIGV8nvoD5ADrao+eiPAPdtjHOLW6xFuGOCplZNr/FMlzhBYYZIJjqWd6WckWp50Pg+vsHeV891V/NBRDlqzQS7QF1I0hwI2bC09GmBkZN+SdQoPY4JkKG+AOzJjbKHm6bpvOAp5E/7Vmx6LRfX98fz2tBCAcb/WlAm90ip2yi6M9NVukAKlWaTV8hFtbVZIiT9rxuKx2itcPLS4Qoxk9xDYwtfu1308/iyN4mslzhf/AjUMoplFxH8CWzKdYbLzLpPZVb+7wQfRyRiJW4lM8ZP62/sWEYEKYSSmAx0Q9vwSInUfmbDt3DpAZyCjZFmxLkJJJjLZ8SMjpRez8d5NP9v6LTsZTnX0RHgdDKWR45jRTHCN1kNLatdklMSKpjKFNPeahnc+0LYs+1+AxrQ1HWRbMFBjcMQ7PLUC6ZpHDFj9XbiAA48uCZaQIssJ0ODq3espR+XkviLBiqiAK3A5eILBj2iPimuNgmMkiNpGZumk/2K/5m76f1DUy2Z0fLFaUY9dnnAgDqexcV0fHpFT2tirNWfytMNOVC0cH2Rx7gSoJnrQI9ISJ5aNoZDEDORNe5EwIB07PoQJc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(1800799024)(366016)(18002099003)(22082099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?JaYj5BDFXVvAu9gQtYA6uOlpNG8HWWPGT/q/aEOZYR+W9yIe8/uG87W1pSl/?= =?us-ascii?Q?Qqpn4tjnsAJUYj4svrHhjdOuKyMJZdNPnDUuxLCf98H7b9uox/l/cD7UjGnx?= =?us-ascii?Q?Gj3EzN4XzZHoW6R+bn6I2rR/ByeeyU3sPgp5ShIezYR4i+yYC1DdMYN45P5Y?= =?us-ascii?Q?S6OBubpqAnP3eBE5+2ONufSQb8daL6UP+LNed8XaOExLzb58dT40Zq+uxN6q?= =?us-ascii?Q?P4HEqLmo1k0OJqkTjxLh1T9O8ZOPUINiFh2zVcqXI6tkQSKT0QpGhY/OUaf/?= =?us-ascii?Q?iyBAFbOQsEd6cYVLe8JxN05g3ESTel9F3YCvBzHahPF6tyYwLAkIY0mtnig7?= =?us-ascii?Q?fWb7duaTvP0sAPoRXHueP6kcswXvymRl64Yza8PfTPnp7F1CqtKzUi7wLX8o?= =?us-ascii?Q?U4EfKTYvZkb+B+1NfQPFiy+iqs8ZxJcHuQw3fEqFoHlvz76CwEa23Ii8B7dt?= =?us-ascii?Q?gVtvMwHAmvpvlzprKfQlqS3MA2xgFHpacaUcomht+du6fXnTWwbqKLRSB2BX?= =?us-ascii?Q?QjHFCd2yv4PYigAYISSZeLxZpmabQNtBVo0EXv600W/HChkad3oozGATt7Y3?= =?us-ascii?Q?dTErvY9adUsvQI7WtEgMM06nQ0dJBZod0yXJ2+JRUEkdszsitzqOweLcWUif?= =?us-ascii?Q?WRnuy3DS+UYRFITKPBb89q3All39hJ9MSNH8KvW6M5Vv5aPhG8eCENHwCBV+?= =?us-ascii?Q?DYv7vtjcSlN+Z/75g56j6um+nyIS3z07di95hhbHK8OW72KFzBxDXeA6moIf?= =?us-ascii?Q?32lUP2NgECeyuDrB3n343YWpKZBcFaMEXwldhXFSrit/xpGlsjQuffNhzf53?= =?us-ascii?Q?49DhQSBPKyEptnx3xC+ngLOBZ8ftYoJrg3xXJzmzINWDup07tKjd5/j5Tmc8?= =?us-ascii?Q?UUP5WYtufe0rPFRt+j6iES2gD4DyBYi69UDdn0zI6xX4VWOTcH8TU0ik89LZ?= =?us-ascii?Q?gCzVUCUuxJeKlU/vsjXNCR6fBh6V+ml4I/x5dV+q4Xmjpcd2xJY1Y+McuqY2?= =?us-ascii?Q?N6innB1/+6S3f0DArzPoGtenUTEYpuQw33bxm2zz0t7rW2yLekPVOwUn7s9q?= =?us-ascii?Q?A+igsmaZFZ+ZOSoWiBWtgNoAuQJmQCcC3DhC7ApENJlEVL2p10h1umJ+c85A?= =?us-ascii?Q?B56jrg5dquialnQgdzHumQNdvFFrqWzab+AcpvRyQmaRuRIMBcv5xln7IPc6?= =?us-ascii?Q?ANDfGXUheCjdguOcgEoYFVYHk5+Z7QKKvp1Mvi+FjM4aktlenwS3SJfdV/6j?= =?us-ascii?Q?sBFjKZI8juRhmcxBLP6DPqOOSVn/CBXitKu+qkrYl81GQGLH7sdWJ6y4mAA5?= =?us-ascii?Q?Z3VvXDEqzQvXLvscbg5r+G6l0Jss/qc2QNXMiJKs0AmvCC28wGPcLCuaiVct?= =?us-ascii?Q?2QnRiWD7psaEUlIwi9bkSkTfVnFT5PmPWkJPfJKflFZi5tajfwiT7UUpdmeQ?= =?us-ascii?Q?q7UWcEWe7KeEVC/rTb941LxaR53ajBRnKHaUcnFw2y9CTEfBuUZz3+Kt7pLO?= =?us-ascii?Q?XjVIV8E2YykTkKIG60f2MbXdgt5YRCxdRkpTLdW29qcrCdGAa5DfwZz/26NL?= =?us-ascii?Q?KIShuEJUSNA6IV9aEkS4AaFjyZ0vy9+HgbMDZZ2uhuuC/RXXbz0ZmDvsmJxy?= =?us-ascii?Q?R/MVyxrli3+555TX8mMaCP66MBevFLWd3sbpMYVspNlqSd8oZgEWZhCJ67Ry?= =?us-ascii?Q?loG0FyqqKMvxsslA4VBTfodfxsbmcJFRJoTbHmrqOhdsjUyH?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 56390c5a-7565-4a71-602c-08de98341634 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2026 01:37:41.3272 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IrZX6Bi5/ia6HZIXqnJ2kzOVUGkr2YlXUGpzv8UyNlwBUyd15pse0XQUWxrWA684 X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7709 On 11 Apr 2026, at 2:21, Guangshuo Li wrote: > After kobject_init_and_add(), the lifetime of the embedded struct > kobject is expected to be managed through the kobject core reference > counting. > > In thpsize_create(), if kobject_init_and_add() fails, thpsize is freed > directly with kfree() rather than releasing the kobject reference with > kobject_put(). This may leave the reference count of the embedded struct > kobject unbalanced, resulting in a refcount leak and potentially leading > to a use-after-free. > > Fix this by using kobject_put(&thpsize->kobj) in the failure path and > letting thpsize_release() handle the final cleanup. > > Fixes: 3485b88390b0 ("mm: thp: introduce multi-size THP sysfs interface") > Cc: stable@vger.kernel.org > Signed-off-by: Guangshuo Li > --- > mm/huge_memory.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > LGTM. Reviewed-by: Zi Yan -- Best Regards, Yan, Zi