mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kumar Gala <galak@kernel.crashing.org>
To: Li Yang-R58472 <LeoLi@freescale.com>
Cc: <akpm@linux-foundation.org>, <davem@davemloft.net>,
	<mporter@kernel.crashing.org>, <linux-kernel@vger.kernel.org>,
	<linuxppc-dev@ozlabs.org>, <netdev@vger.kernel.org>,
	"Zhang Wei" <zw@zh-kernel.org>
Subject: Re: [PATCH 1/6] rapidio: add common mapping APIs for RapidIO memory access
Date: Thu, 11 Jun 2009 08:32:24 -0500	[thread overview]
Message-ID: <5D8775BD-9973-4DE8-B442-91FB15F86ACC@kernel.crashing.org> (raw)
In-Reply-To: <3A45394FD742FA419B760BB8D398F9ED483CCD@zch01exm26.fsl.freescale.net>


On Jun 11, 2009, at 4:47 AM, Li Yang-R58472 wrote:

>> On May 12, 2009, at 3:35 AM, Li Yang wrote:
>>
>>> Add the mapping functions used to support direct IO memory access of
>>> rapidIO.
>>>
>>> Signed-off-by: Zhang Wei <zw@zh-kernel.org>
>>> Signed-off-by: Li Yang <leoli@freescale.com>
>>
>> Use inbnd/outbnd instead of inb/outb which make one think of
>> byte level io accessors.
>>
>> As I look at this I don't think this is the correct API.  I
>> think we should be using the DMA mapping API to hide these
>> details.  The concept of mapping like this seems to be more a
>> function of FSL's Address translation/mapping unit (ATMU) than
>> anything specific to the RIO bus standard.
>
> This is a separate RIO block level ATMU.  Although it looks like the
> system level ATMU, system ATMU doesn't have the knowledge of rapidIO
> target device ID.  The mapping need to be dynamic, as it's easy to  
> have
> more RIO devices than the outbound windows.

I understand that.  What I'm saying is the RIO block level ATMU is a  
Freescale specific detail and not part of any standard RIO bus  
programming model.  We have mapping APIs that we can connect to for  
this via the DMA API layer.

- k

  reply	other threads:[~2009-06-11 13:34 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-12  8:35 Li Yang
2009-05-12  8:35 ` [PATCH 2/6] powerpc/fsl_rio: use LAW address from device tree Li Yang
2009-05-12  8:36   ` [PATCH 3/6] powerpc: add memory map support to Freescale RapidIO block Li Yang
2009-05-12  8:36     ` [PATCH 4/6] rionet: add memory access to simulated Ethernet over rapidio Li Yang
2009-05-12  8:36       ` [PATCH 5/6] rio: warn_unused_result warnings fix Li Yang
2009-05-12  8:36         ` [PATCH 6/6] rio: fix section mismatch Li Yang
2009-05-13 22:08           ` Kumar Gala
2009-05-12 22:11         ` [PATCH 5/6] rio: warn_unused_result warnings fix Andrew Morton
2009-06-11  4:34         ` Kumar Gala
2009-05-12 22:10       ` [PATCH 4/6] rionet: add memory access to simulated Ethernet over rapidio Andrew Morton
2009-05-12 22:05     ` [PATCH 3/6] powerpc: add memory map support to Freescale RapidIO block Andrew Morton
2009-05-21 10:43       ` Li Yang
2009-05-13 22:08   ` [PATCH 2/6] powerpc/fsl_rio: use LAW address from device tree Kumar Gala
2009-06-11  4:13 ` [PATCH 1/6] rapidio: add common mapping APIs for RapidIO memory access Kumar Gala
2009-06-11  9:47   ` Li Yang-R58472
2009-06-11 13:32     ` Kumar Gala [this message]
2009-06-12 13:27       ` Li Yang
2009-06-12 13:58         ` Kumar Gala
2009-06-15 10:38           ` Li Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5D8775BD-9973-4DE8-B442-91FB15F86ACC@kernel.crashing.org \
    --to=galak@kernel.crashing.org \
    --cc=LeoLi@freescale.com \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mporter@kernel.crashing.org \
    --cc=netdev@vger.kernel.org \
    --cc=zw@zh-kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®