mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: <Michael.Wu@vatics.com>
To: <jarkko.nikula@linux.intel.com>,
	<andriy.shevchenko@linux.intel.com>,
	<mika.westerberg@linux.intel.com>, <linux-i2c@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Cc: <morgan.chang@vatics.com>
Subject: RE: [PATCH v3] i2c: designware: call i2c_dw_read_clear_intrbits_slave() once
Date: Wed, 28 Oct 2020 05:24:18 +0000	[thread overview]
Message-ID: <5DB475451BAA174CB158B5E897FC1525B1294F5F@MBS07.vivotek.tw> (raw)
In-Reply-To: <a44aacbb-fcb4-f83f-b781-b69f52944f09@linux.intel.com>

Hi,

> On 10/23/20 8:40 AM, Michael Wu wrote:
> > If some bits were cleared by i2c_dw_read_clear_intrbits_slave() in
> > i2c_dw_isr_slave() and not handled immediately, those cleared bits would
> > not be shown again by later i2c_dw_read_clear_intrbits_slave(). They
> > therefore were forgotten to be handled.
> >
> > i2c_dw_read_clear_intrbits_slave() should be called once in an ISR and take
> > its returned state for all later handlings.
> > ---
> >   drivers/i2c/busses/i2c-designware-slave.c | 7 +------
> >   1 file changed, 1 insertion(+), 6 deletions(-)
> >
> Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>

There is another logic issue about the I2C_SLAVE_WRITE_REQUESTED reporting.
May I give patches based on this commit?

Michael Wu

      reply	other threads:[~2020-10-29  1:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-23  5:40 Michael Wu
2020-10-23  6:27 ` Jarkko Nikula
2020-10-28  5:24   ` Michael.Wu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5DB475451BAA174CB158B5E897FC1525B1294F5F@MBS07.vivotek.tw \
    --to=michael.wu@vatics.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=morgan.chang@vatics.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®