From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpbguseast2.qq.com (smtpbguseast2.qq.com [54.204.34.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB8CB15AD9C; Thu, 19 Dec 2024 07:12:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=54.204.34.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734592350; cv=none; b=OvBspgkkEx2Uww0nWwMFDpOUk2eXtYMAEHpNogYl10TjHCrvesm+KCB3tLjeTmPrzVgRVmtz0Ovz8DcNF/daDeiklKRngxXTQdEauuRnD/Jf3CFygJdsVWJoLaD31oX2/e4Aj2ZspXfk70TZ43uhVTzWIAo5FV7HL5ZZGlcf6b8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734592350; c=relaxed/simple; bh=VVmsLsYLgJ6dfYR63bJCgBlqhF8GN4cvCDdBn4Ry0xk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qVHhSXRwt+UKZ7YvXiskpqcmYmu5rIDP9gNywxlbczSJavjQu1Uw/vwFeT0q4cR0pk7u+BJInBAWsDQTQQFxeHmKTSO2D7yHC/kvR8pw4b0x7wqeOlIjqDuYPQcIWXhFb8QoF0OcdpV9cV7hXiYfiF6FOBIJZA5yFRAgqKnXzTg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=uniontech.com; spf=pass smtp.mailfrom=uniontech.com; dkim=pass (1024-bit key) header.d=uniontech.com header.i=@uniontech.com header.b=fxaKyOML; arc=none smtp.client-ip=54.204.34.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=uniontech.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=uniontech.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=uniontech.com header.i=@uniontech.com header.b="fxaKyOML" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uniontech.com; s=onoh2408; t=1734592333; bh=+MEAUGGXL0Erz0WkbnodWUkGrFLvVkbl1vv6+fCRWH8=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=fxaKyOMLOOGnqSd8el5l74CO/L0khgeH1nx37HFK9aMS7GLVYG9c06v5GRS/Lbhsp o7IXjjsDvQnO5mxKS6wIKFzjGaOd6nHrGg4fsgDt1qHzrKIHnz5thT49xDH0dk9S58 xC12j5okfNChsrQJ6R2iZ6sFr/C+O/NEuhkpRQuk= X-QQ-mid: bizesmtpip4t1734592290tjr7r2n X-QQ-Originating-IP: l6hQyAfuhMYTk+SclTpaR6OaKpjGMSd86SRP/orbWPg= Received: from [IPV6:240e:668:120a::253:10f] ( [localhost]) by bizesmtp.qq.com (ESMTP) with id ; Thu, 19 Dec 2024 15:11:24 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 1 X-BIZMAIL-ID: 16436400738179319441 Message-ID: <5DB5DA2260D540B9+359f8cbf-e560-495d-8afe-392573f1171b@uniontech.com> Date: Thu, 19 Dec 2024 15:11:24 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RESEND. PATCH] mt76: mt76u_vendor_request: Do not print error messages when -EPROTO To: Alexander Lobakin Cc: nbd@nbd.name, lorenzo@kernel.org, ryder.lee@mediatek.com, shayne.chen@mediatek.com, sean.wang@mediatek.com, kvalo@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, davem@davemloft.net, andrew+netdev@lunn.ch, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, alexander.deucher@amd.com, gregkh@linuxfoundation.org, rodrigo.vivi@intel.com, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, raoxu@uniontech.com, guanwentao@uniontech.com, zhanjun@uniontech.com, cug_yangyuancong@hotmail.com, lorenzo.bianconi@redhat.com, kvalo@codeaurora.org, sidhayn@gmail.com, lorenzo.bianconi83@gmail.com, sgruszka@redhat.com, keescook@chromium.org, markus.theil@tu-ilmenau.de, gustavoars@kernel.org, stf_xl@wp.pl, romain.perier@gmail.com, apais@linux.microsoft.com, mrkiko.rs@gmail.com, oliver@neukum.org, woojung.huh@microchip.com, helmut.schaa@googlemail.com, mailhol.vincent@wanadoo.fr, dokyungs@yonsei.ac.kr, deren.wu@mediatek.com, daniel@makrotopia.org, sujuan.chen@mediatek.com, mikhail.v.gavrilov@gmail.com, stern@rowland.harvard.edu, linux-usb@vger.kernel.org, leitao@debian.org, dsahern@kernel.org, weiwan@google.com, netdev@vger.kernel.org, horms@kernel.org, andrew@lunn.ch, leit@fb.com, wang.zhao@mediatek.com, chui-hao.chiu@mediatek.com, lynxis@fe80.eu, mingyen.hsieh@mediatek.com, yn.chen@mediatek.com, quan.zhou@mediatek.com, dzm91@hust.edu.cn, gch981213@gmail.com, git@qrsnap.io, jiefeng_li@hust.edu.cn, nelson.yu@mediatek.com, rong.yan@mediatek.com, Bo.Jiao@mediatek.com, StanleyYP.Wang@mediatek.com References: <1E6ABDEA91ADAB1A+20241218090833.140045-1-wangyuli@uniontech.com> Content-Language: en-US From: WangYuli Autocrypt: addr=wangyuli@uniontech.com; keydata= xjMEZoEsiBYJKwYBBAHaRw8BAQdAyDPzcbPnchbIhweThfNK1tg1imM+5kgDBJSKP+nX39DN IVdhbmdZdWxpIDx3YW5neXVsaUB1bmlvbnRlY2guY29tPsKJBBMWCAAxFiEEa1GMzYeuKPkg qDuvxdofMEb0C+4FAmaBLIgCGwMECwkIBwUVCAkKCwUWAgMBAAAKCRDF2h8wRvQL7g0UAQCH 3mrGM0HzOaARhBeA/Q3AIVfhS010a0MZmPTRGVfPbwD/SrncJwwPAL4GiLPEC4XssV6FPUAY 0rA68eNNI9cJLArOOARmgSyJEgorBgEEAZdVAQUBAQdA88W4CTLDD9fKwW9PB5yurCNdWNS7 VTL0dvPDofBTjFYDAQgHwngEGBYIACAWIQRrUYzNh64o+SCoO6/F2h8wRvQL7gUCZoEsiQIb DAAKCRDF2h8wRvQL7sKvAP4mBvm7Zn1OUjFViwkma8IGRGosXAvMUFyOHVcl1RTgFQEAuJkU o9ERi7qS/hbUdUgtitI89efbY0TVetgDsyeQiwU= In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------lzZ32JdsjGIy0QqsKa26e0mC" X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtpip:uniontech.com:qybglogicsvrgz:qybglogicsvrgz8a-1 X-QQ-XMAILINFO: MEkdxmPIchj3Em/0EyE/BletY8gTCmD1eAtlgfYfkcG4m5Hsy/WVzZ/S CiutlnXeV8Xzdwl0dNergFNoBx2VCrxap6AuVbNHf0BVM6dxikFhfesAMNfn6Wi6r2JViqn cXHqkhMqqJ6MM9ZMUi3l3CMSf+2p0mdG4ZDzjOQ1HxVvs2bMa6tlGS3i6lAPHZDAHhYKSs9 ZzOnBgLd/pxu/HGN3zTUAt0nmZ6hgC1jXNB0sz2bwOP8mw8FGznYUDQMe2d/amq2Wx9hNqo 67T+NsAte5xmjh3vMt65ut+JO7Hch+nYUNZjFnLoFvfPx5OT4620NhuSetu6VLPlip2GDiv 4CTMnwz0vkqwRTJq2Q7Gm9x1QQD1WHcxYVmPB2cz+Go7rRUNxL7gkuT8SUkFe/VnnPvOMQ5 pyJRZdRUd8GY20DhCDKCqqiixOFkv0VvEzd/djplhAq2qm7Nt8O7vORVjDKWNCd7nDTVpxV VtT87hg6vzAHxFIHM2633xilC44OIUb50f91Z5K8g6jfttN4F6/Gcqqff6tDm9yosWgpOU0 0YVX5B7DppTvAe83VaR1IiaMdw+pXTuNAnzpfuw6utJ6rc3I8N8t4RebBSMtIuPxHp/cLi/ 36vEVT21oV2DPBYb3g9hHwsK4V8MolM8NDwf5etk/rXNWh30xUQqYgTDyQIf2yuEsbS1p8l 3ATRljk6uy64UxP4UR3DctMEtgbeVciWW7lfFiWf7kvPTFnhhK+ycJnvU6kcMpBLXZ+M0iv kanciHpC4ybHB6jB4552Q6GEvAcPk6S7ZCUivQb/Pr5eXHlmJq2k8LiazkL6vEr8JJ6PqTn m1j5srFm6r9zabFMhbqHeUSXI5ZV9gMaiPOAx9Zdh/7x/YXtMDZonZHt1rG1hrntfwBajhc fFhqenOv/UjCsnMilCnqDUt7OX6NPy1D86Fm/8UaLJU7oE6DD63MnRTocrYihGwMLtoQKC8 V2PNSUwaCamp4rBQorzaIRBbFVgh7+ezm9A6ZiV+77f0q57NXT3v3xqdSt6R+zjnkfXIQEQ O+PDrkv1E9JFCkPYNt+ylKZUJd/gjillLFc6lEOg6AuEiOjYxa/tvPSuGmFv1qtu8liHKI5 eHh5fm+9PaD X-QQ-XMRINFO: NS+P29fieYNw95Bth2bWPxk= X-QQ-RECHKSPAM: 0 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------lzZ32JdsjGIy0QqsKa26e0mC Content-Type: multipart/mixed; boundary="------------t9kOQFUFBryxJS1kEc7YATUG"; protected-headers="v1" From: WangYuli To: Alexander Lobakin Cc: nbd@nbd.name, lorenzo@kernel.org, ryder.lee@mediatek.com, shayne.chen@mediatek.com, sean.wang@mediatek.com, kvalo@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, davem@davemloft.net, andrew+netdev@lunn.ch, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, alexander.deucher@amd.com, gregkh@linuxfoundation.org, rodrigo.vivi@intel.com, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, raoxu@uniontech.com, guanwentao@uniontech.com, zhanjun@uniontech.com, cug_yangyuancong@hotmail.com, lorenzo.bianconi@redhat.com, kvalo@codeaurora.org, sidhayn@gmail.com, lorenzo.bianconi83@gmail.com, sgruszka@redhat.com, keescook@chromium.org, markus.theil@tu-ilmenau.de, gustavoars@kernel.org, stf_xl@wp.pl, romain.perier@gmail.com, apais@linux.microsoft.com, mrkiko.rs@gmail.com, oliver@neukum.org, woojung.huh@microchip.com, helmut.schaa@googlemail.com, mailhol.vincent@wanadoo.fr, dokyungs@yonsei.ac.kr, deren.wu@mediatek.com, daniel@makrotopia.org, sujuan.chen@mediatek.com, mikhail.v.gavrilov@gmail.com, stern@rowland.harvard.edu, linux-usb@vger.kernel.org, leitao@debian.org, dsahern@kernel.org, weiwan@google.com, netdev@vger.kernel.org, horms@kernel.org, andrew@lunn.ch, leit@fb.com, wang.zhao@mediatek.com, chui-hao.chiu@mediatek.com, lynxis@fe80.eu, mingyen.hsieh@mediatek.com, yn.chen@mediatek.com, quan.zhou@mediatek.com, dzm91@hust.edu.cn, gch981213@gmail.com, git@qrsnap.io, jiefeng_li@hust.edu.cn, nelson.yu@mediatek.com, rong.yan@mediatek.com, Bo.Jiao@mediatek.com, StanleyYP.Wang@mediatek.com Message-ID: <359f8cbf-e560-495d-8afe-392573f1171b@uniontech.com> Subject: Re: [RESEND. PATCH] mt76: mt76u_vendor_request: Do not print error messages when -EPROTO References: <1E6ABDEA91ADAB1A+20241218090833.140045-1-wangyuli@uniontech.com> In-Reply-To: --------------t9kOQFUFBryxJS1kEc7YATUG Content-Type: multipart/mixed; boundary="------------yW0HEyhQsnN0e7VNb0LN57Ek" --------------yW0HEyhQsnN0e7VNb0LN57Ek Content-Type: multipart/alternative; boundary="------------v8YpJ2JjzcZFOBmM8z0ncFDr" --------------v8YpJ2JjzcZFOBmM8z0ncFDr Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjAyNC8xMi8xOSAwMDoxMCwgQWxleGFuZGVyIExvYmFraW4gd3JvdGU6DQoNCj4gSXMg aXQgYSBmaXggb3IgYW4gaW1wcm92ZW1lbnQ/DQo+IFlvdSBuZWVkIHRvIHNwZWNpZnkgdGhl IHRhcmdldCB0cmVlLCBlaXRoZXIgJ1BBVENIIG5ldCcgKGZpeGVzKSBvcg0KPiAnUEFUQ0gg bmV0LW5leHQnIChpbXByb3ZlbWVudHMpLg0KIMKgSXQgaXMgYSBmaXggbm90IGFuIGltcHJv dmVtZW50Lg0KPiBIb3cgZG8gb3RoZXIgZHJpdmVycyBoYW5kbGUgdGhpcz8NCj4gQ2FuIC1F UFJPVE8gaGFwcGVuIGluIG90aGVyIGNhc2VzLCBub3Qgb25seSB1bnBsdWdnaW5nLCB3aGlj aCB0aGlzIHBhdGNoDQo+IHdvdWxkIGJyZWFrPw0KPg0KV2hlbiBpbml0aWFsaXppbmcgdGhl IG5ldHdvcmsgY2FyZCwgdW5wbHVnZ2luZyB0aGUgZGV2aWNlIHdpbGwgdHJpZ2dlciANCmFu IC1FUFJPVE8gZXJyb3IuDQoNClRoZSBleGNlcHRpb24gaXMgcHJpbnRlZCBhcyBmb2xsb3dz 77yaDQoNCg0KIMKgwqDCoMKgwqDCoMKgIG10NzZ4MnUgMi0yLjQ6MS4wOiB2ZW5kb3IgcmVx dWVzdCByZXE6NDcgb2ZmOjkwMTggZmFpbGVkOi03MQ0KIMKgwqDCoMKgwqDCoMKgIG10NzZ4 MnUgMi0yLjQ6MS4wOiB2ZW5kb3IgcmVxdWVzdCByZXE6NDcgb2ZmOjkwMTggZmFpbGVkOi03 MQ0KIMKgwqDCoMKgwqDCoMKgIC4uLg0KDQpJdCB3aWxsIGNvbnRpbnVlIHRvIHByaW50IG1v cmUgdGhhbiAyMDAwIHRpbWVzIGZvciBhYm91dCA1IG1pbnV0ZXMsIA0KY2F1c2luZyB0aGUg dXNiIGRldmljZSB0byBiZSB1bmFibGUgdG8gYmUgZGlzY29ubmVjdGVkLiBEdXJpbmcgdGhp cyANCnBlcmlvZCwgdGhlIHVzYiBwb3J0IGNhbm5vdCByZWNvZ25pemUgdGhlIG5ldyBkZXZp Y2UgYmVjYXVzZSB0aGUgb2xkIA0KZGV2aWNlIGhhcyBub3QgZGlzY29ubmVjdGVkLg0KDQpU aGVyZSBtYXkgYmUgb3RoZXIgb3BlcmF0aW5nIG1ldGhvZHMgdGhhdCBjYXVzZSAtRVBST1RP LCBidXQgLUVQUk9UTyBpcyANCmEgbG93LWxldmVsIGhhcmR3YXJlIGVycm9yLiBJdCBpcyB1 bndpc2UgdG8gcmVwZWF0IHZlbmRvciByZXF1ZXN0cyANCmV4cGVjdGluZyB0byByZWFkIGNv cnJlY3QgZGF0YS4gSXQgaXMgYSBiZXR0ZXIgY2hvaWNlIHRvIHRyZWF0IC1FUFJPVE8gDQph bmQgLUVOT0RFViB0aGUgc2FtZSB3YXnjgIINCg0KU2ltaWxhciB0byBjb21taXQg77yIbXQ3 NjogdXNiOiBwcm9jZXNzIFVSQnMgd2l0aCBzdGF0dXMgRVBST1RPIA0KcHJvcGVybHnvvIlk byBubyBzY2hlZHVsZSByeF93b3JrZXIgZm9yIHVyYiBtYXJrZWQgd2l0aCBzdGF0dXMgc2V0 IA0KLUVQUk9UTy4gSSBhbHNvIHJlcHJvZHVjZWQgdGhpcyBzaXR1YXRpb24gd2hlbiBwbHVn Z2luZyBhbmQgdW5wbHVnZ2luZyANCnRoZSBkZXZpY2UsIGFuZCB0aGlzIHBhdGNoIGlzIGVm ZmVjdGl2ZS4NCg0KSnVzdCBkbyBub3QgdmVuZG9yIHJlcXVlc3QgYWdhaW4gZm9yIHVyYiBt YXJrZWQgd2l0aCBzdGF0dXMgc2V0IC1FUFJPVE8gLg0KDQoNClRoYW5rcywNCg0KLS0gDQpX YW5nWXVsaQ0K --------------v8YpJ2JjzcZFOBmM8z0ncFDr Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

On 2024/12/19 00:10, Alexander Lobakin wrote:

Is it a fix or an improvemen=
t?
You need to specify the target tree, either 'PATCH net' (fixes) or
'PATCH net-next' (improvements).
=C2=A0It is a fix not an improvement.
How do other drivers handle =
this?
Can -EPROTO happen in other cases, not only unplugging, which this patch
would break?

When initializing the network card, unplugging the device will trigger an -EPROTO error.

The exception is printed as follows=EF=BC=9A

=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 mt76x2u 2-2.4:1.0: vendor = request req:47 off:9018 failed:-71
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 mt76x2u 2-2.4:1.0: vendor = request req:47 off:9018 failed:-71
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ...
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0

It will continue to print more than 2000 times for about 5 minutes, causing the usb device to be unable to be disconnected.=C2= =A0 During this period, the usb port cannot recognize the new device because the old device has not disconnected.

There may be other operating methods that cause -EPROTO, but -EPROTO is a low-level hardware error. It is unwise to repeat vendor requests expecting to read correct data. It is a better choice to treat -EPROTO and -ENODEV the same way=E3=80=82

Similar to commit =EF=BC=88mt76: usb: process URBs with status EPR= OTO properly=EF=BC=89do no schedule rx_worker for urb marked with statu= s set -EPROTO. I also reproduced this situation when plugging and unplugging the device, and this patch is effective.

Just do not vendor request again for urb marked with status set -EPROTO .


Thanks,

--
WangYuli
--------------v8YpJ2JjzcZFOBmM8z0ncFDr-- --------------yW0HEyhQsnN0e7VNb0LN57Ek Content-Type: application/pgp-keys; name="OpenPGP_0xC5DA1F3046F40BEE.asc" Content-Disposition: attachment; filename="OpenPGP_0xC5DA1F3046F40BEE.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xjMEZoEsiBYJKwYBBAHaRw8BAQdAyDPzcbPnchbIhweThfNK1tg1imM+5kgDBJSK P+nX39DNIVdhbmdZdWxpIDx3YW5neXVsaUB1bmlvbnRlY2guY29tPsKJBBMWCAAx FiEEa1GMzYeuKPkgqDuvxdofMEb0C+4FAmaBLIgCGwMECwkIBwUVCAkKCwUWAgMB AAAKCRDF2h8wRvQL7g0UAQCH3mrGM0HzOaARhBeA/Q3AIVfhS010a0MZmPTRGVfP bwD/SrncJwwPAL4GiLPEC4XssV6FPUAY0rA68eNNI9cJLArOOARmgSyJEgorBgEE AZdVAQUBAQdA88W4CTLDD9fKwW9PB5yurCNdWNS7VTL0dvPDofBTjFYDAQgHwngE GBYIACAWIQRrUYzNh64o+SCoO6/F2h8wRvQL7gUCZoEsiQIbDAAKCRDF2h8wRvQL 7sKvAP4mBvm7Zn1OUjFViwkma8IGRGosXAvMUFyOHVcl1RTgFQEAuJkUo9ERi7qS /hbUdUgtitI89efbY0TVetgDsyeQiwU=3D =3DBlkq -----END PGP PUBLIC KEY BLOCK----- --------------yW0HEyhQsnN0e7VNb0LN57Ek-- --------------t9kOQFUFBryxJS1kEc7YATUG-- --------------lzZ32JdsjGIy0QqsKa26e0mC Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQRrUYzNh64o+SCoO6/F2h8wRvQL7gUCZ2PHHAUDAAAAAAAKCRDF2h8wRvQL7gYX AP0W8PzI7QVqA+31JnDg1CxYYXzmXk/c3NaAuW8VObPOqQD/ab4eOVfD6UTQ2ZoytfW3G7bDgzc+ vn00zaCUbHdmrA4= =1v9C -----END PGP SIGNATURE----- --------------lzZ32JdsjGIy0QqsKa26e0mC--