mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Faisal Latif" <flatif@NetEffect.com>
To: "Christophe Jaillet" <christophe.jaillet@wanadoo.fr>,
	"linux" <linux-kernel@vger.kernel.org>,
	"Nishi Gupta" <ngupta@NetEffect.com>,
	"Glenn Streiff" <gstreiff@NetEffect.com>,
	<general@lists.openfabrics.org>
Cc: "Roland Dreier" <rdreier@cisco.com>
Subject: RE: [PATCH 1/1] infiniband/hw/nes/: avoid unnecessary memset
Date: Tue, 13 May 2008 16:46:47 -0500	[thread overview]
Message-ID: <5E701717F2B2ED4EA60F87C8AA57B7CC080BD82B@venom2> (raw)
In-Reply-To: <20080512213601.626C91C0008F@mwinf2103.orange.fr>

Acked-by Faisal Latif<faisal@neteffect.com>

Thanks
Faisal


> 
> From: Christophe Jaillet <christophe.jaillet@wanadoo.fr>
> 
> Hi, here is a patch against linux/drivers/infiniband/hw/nes/nes_cm.c
> which :
> 
> 1) Remove an explicit memset(.., 0, ...) to a variable allocated with
> kzalloc (i.e. 'listener').
> 
> 
> Note: this patch is based on 'linux-2.6.25.tar.bz2'
> 
> Signed-off-by: Christophe Jaillet <christophe.jaillet@wanadoo.fr>
> 
> ---
> 
> --- linux/drivers/infiniband/hw/nes/nes_cm.c	2008-04-17
> 04:49:44.000000000 +0200
> +++ linux/drivers/infiniband/hw/nes/nes_cm.c.cj	2008-05-12
> 23:31:24.000000000 +0200
> @@ -1587,7 +1587,6 @@ static struct nes_cm_listener *mini_cm_l
>  			return NULL;
>  		}
> 
> -		memset(listener, 0, sizeof(struct nes_cm_listener));
>  		listener->loc_addr = htonl(cm_info->loc_addr);
>  		listener->loc_port = htons(cm_info->loc_port);
>  		listener->reused_node = 0;
> 


  parent reply	other threads:[~2008-05-13 22:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-12 21:35 Christophe Jaillet
2008-05-12 21:38 ` [PATCH] drivers/net/ehea - remove unnecessary memset after kzalloc Joe Perches
2008-05-20 13:53   ` Jan-Bernd Themann
2008-05-22 10:22   ` Jeff Garzik
2008-05-13 21:46 ` Faisal Latif [this message]
2008-05-14 16:36   ` [ofa-general] RE: [PATCH 1/1] infiniband/hw/nes/: avoid unnecessary memset Roland Dreier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5E701717F2B2ED4EA60F87C8AA57B7CC080BD82B@venom2 \
    --to=flatif@neteffect.com \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=general@lists.openfabrics.org \
    --cc=gstreiff@NetEffect.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ngupta@NetEffect.com \
    --cc=rdreier@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®