From: Markus Heiser <markus.heiser@darmarit.de>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>,
Randy Dunlap <rdunlap@infradead.org>
Cc: joonas.lahtinen@linux.intel.com,
Chris Wilson <chris@chris-wilson.co.uk>,
sagar.a.kamble@intel.com, jani.nikula@linux.intel.com,
rodrigo.vivi@intel.com, airlied@linux.ie,
daniel.vetter@intel.com, seanpaul@chromium.org,
Jonathan Corbet <corbet@lwn.net>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
Linux Doc Mailing List <linux-doc@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] docs: fix, intel_guc_loader.c has been moved to intel_guc_fw.c
Date: Tue, 12 Dec 2017 13:11:43 +0100 [thread overview]
Message-ID: <5E91F865-18A3-4C79-8EEE-B228EB188496@darmarit.de> (raw)
In-Reply-To: <op.za4uimy6xaggs7@mwajdecz-mobl1.ger.corp.intel.com>
> Am 12.12.2017 um 13:05 schrieb Michal Wajdeczko <michal.wajdeczko@intel.com>:
>
> On Tue, 12 Dec 2017 12:38:37 +0100, Markus Heiser <markus.heiser@darmarit.de> wrote:
>
>> With commit d9e2e0143c the 'GuC-specific firmware loader' doc
>> section was removed from intel_guc_loader.c without a
>> replacement. So lets remove it from the Kernel-doc::
>>
>> .. kernel-doc:: drivers/gpu/drm/i915/intel_guc_loader.c
>> :doc: GuC-specific firmware loader
>>
>> With commit e8668bbcb0 intel_guc_loader.c was renamed to to
>> intel_guc_fw.c and to name just one, intel_guc_init_hw() was
>> renamed to intel_guc_fw_upload(). Since we get errors in the
>> Sphinx build like:
>>
>> - Error: Cannot open file ./drivers/gpu/drm/i915/intel_guc_loader.c
>>
>> Change the kernel-doc directive from intel_guc_loader.c to
>> intel_guc_fw.c
>>
>> Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
>> ---
>
> Thanks for your patch, but similar fix is already merged here [1]
>
> Michal
>
> [1] https://cgit.freedesktop.org/drm-tip/commit/?id=006c23327f8de8575508c458131b304188d426f7
Thanks for pointing out. I miss the ":doc: GuC-specific firmware loader"
fix in that patch (doc section was removed in d9e2e0143c). Can you or
someone else from @intel fix this also?
Thanks!
-- Markus --
> --
> To unsubscribe from this list: send the line "unsubscribe linux-doc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-12-12 12:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 11:38 Markus Heiser
2017-12-12 12:05 ` Michal Wajdeczko
2017-12-12 12:11 ` Markus Heiser [this message]
2017-12-12 15:23 ` Daniel Vetter
2017-12-12 15:43 ` Markus Heiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5E91F865-18A3-4C79-8EEE-B228EB188496@darmarit.de \
--to=markus.heiser@darmarit.de \
--cc=airlied@linux.ie \
--cc=chris@chris-wilson.co.uk \
--cc=corbet@lwn.net \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.wajdeczko@intel.com \
--cc=rdunlap@infradead.org \
--cc=rodrigo.vivi@intel.com \
--cc=sagar.a.kamble@intel.com \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®