From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751214AbdAaPLS convert rfc822-to-8bit (ORCPT <rfc822;w@1wt.eu>);
        Tue, 31 Jan 2017 10:11:18 -0500
Received: from saturn.retrosnub.co.uk ([178.18.118.26]:35319 "EHLO
        saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750843AbdAaPLD (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 31 Jan 2017 10:11:03 -0500
Date: Tue, 31 Jan 2017 15:01:36 +0000
User-Agent: K-9 Mail for Android
In-Reply-To: <alpine.DEB.2.02.1701310816520.1494@pmeerw.net>
References: <20170130125117.GA9865@andreas> <8051b9f7-ef91-8746-1a13-693ec5cdc9e4@kernel.org> <alpine.DEB.2.02.1701310816520.1494@pmeerw.net>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: 8BIT
Subject: Re: [PATCH v2 2/2] iio: distance: add devantech us ranger srf04
To: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
CC: Andreas Klinger <ak@it-klinger.de>, lars@metafoo.de,
        linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org
From: Jonathan Cameron <jic23@kernel.org>
Message-ID: <5F017199-2372-448C-9A67-B86D8113F984@kernel.org>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 31 January 2017 07:19:16 GMT+00:00, Peter Meerwald-Stadler <pmeerw@pmeerw.net> wrote:
>
>> > +	indio_dev->num_channels = ARRAY_SIZE(srf04_chan_spec);
>> > +
>> > +	return iio_device_register(indio_dev);
>> > +}
>> > +
>> > +static int srf04_remove(struct platform_device *pdev)
>> > +{
>> > +	struct iio_dev *indio_dev = platform_get_drvdata(pdev);
>> > +
>> > +	iio_device_unregister(indio_dev);
>> With nothing else in here, you can use devm_iio_device_register
>> and drop the remove entirely.
>
>can devm_request_irq() and devm_iio_device_register() be used together?
>if both are devm_ we cant't guarantee that iio_device_unregister()
>comes 
>first in _remove()?
>
>these devm_ things...
Yes. It is ordered and guarantees unwind in opposite order for a given Dev structure.
>
>> > +
>> > +	return 0;
>> > +}
>> > +
>> > +static const struct of_device_id of_srf04_match[] = {
>> > +	{ .compatible = "devantech,srf04", },
>> > +	{},
>> > +};
>> > +
>> > +MODULE_DEVICE_TABLE(of, of_srf04_match);
>> > +
>> > +static struct platform_driver srf04_driver = {
>> > +	.probe		= srf04_probe,
>> > +	.remove		= srf04_remove,
>> > +	.driver		= {
>> > +		.name		= "srf04-gpio",
>> > +		.of_match_table	= of_srf04_match,
>> > +	},
>> > +};
>> > +
>> > +module_platform_driver(srf04_driver);
>> > +
>> > +MODULE_AUTHOR("Andreas Klinger <ak@it-klinger.de>");
>> > +MODULE_DESCRIPTION("SRF04 ultrasonic sensor for distance measuring
>using GPIOs");
>> > +MODULE_LICENSE("GPL");
>> > +MODULE_ALIAS("platform:srf04");
>> > 
>> 
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-iio"
>in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> 

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.