From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-177.mta1.migadu.com (out-177.mta1.migadu.com [95.215.58.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9E931A2C04 for ; Sun, 22 Feb 2026 21:22:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771795342; cv=none; b=Ib3GsCGjVVOD3cdMb+wrhCWpV9YPpSwszkWAA76PptcxjS45GD/PhONj0NXdHHlAJqC+D0kPZokWrtkMIJtHCabUhtxJnuzFrjS+MWbXi+lZwQMFTCNXe8sYZ2K+E9XbygReZmkLJM4cz3gAY9cNWyWZJwbLOc1fB2MJXVDEZEc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771795342; c=relaxed/simple; bh=5AjNnwv6JgftztwD+UfHFm1F19G5RTGLl61SgoBEr0I=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=l1bYYpDto3agwsvfJCUMc3uN3Qk9EsK9VBBDWhmeP5kevbxhddbiYnwAR7GlsCrXJ7VZp2UcTI52AA6H/TWfXZoHmtgmSN1oDC7+ScbOD508e42qBz2YElWHXGTBXLjo6Mx700tlz0OIUgWhxkP5AU6d/tgHicqnefycFtMzev4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=SQOcAM6T; arc=none smtp.client-ip=95.215.58.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="SQOcAM6T" Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1771795328; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O1VMmlfM/yqpVE8XtgrCgqPWCKU8Fcqlc9rHbF4ULYw=; b=SQOcAM6TcFcCtLGA2Wuho23hy9K2kvZoUvc0TNrCCJx0vSPfa72iFAs62hP8fOVGIA+Qcf w6E7JmbNGsi7fOgVpSJEsP5hZsV8XgoLYt9nSRhn6OK+ejrC78fB1kHNsUhqpXPwHfOt2n KsmDsBOo4YVR9Dn4hUteq/LGHUJVpzk= Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81.1.4\)) Subject: Re: [PATCH RESEND] autofs: replace manual symlink buffer allocation in autofs_dir_symlink X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Thorsten Blum In-Reply-To: <6b4c95df-1005-4f8d-a350-c4bf3769228c@themaw.net> Date: Sun, 22 Feb 2026 22:22:01 +0100 Cc: autofs@vger.kernel.org, linux-kernel@vger.kernel.org, Christian Brauner Content-Transfer-Encoding: quoted-printable Message-Id: <5F120295-FC54-49A8-8B92-870EAEB0A319@linux.dev> References: <20260127013639.433302-1-thorsten.blum@linux.dev> <6b4c95df-1005-4f8d-a350-c4bf3769228c@themaw.net> To: Ian Kent X-Migadu-Flow: FLOW_OUT On 27. Jan 2026, at 03:14, Ian Kent wrote: > On 27/1/26 09:36, Thorsten Blum wrote: >> The symlink name was previously duplicated using an explicit = kmalloc() >> followed by strcpy(), which is deprecated [1]. Replace this = open-coded >> string duplication with kstrdup(), which allocates and copies the >> symlink name with a single helper function. >>=20 >> Remove the local variable 'size' and set 'i_size' directly using >> strlen(cp), which is equivalent to the previous value of 'size'. >>=20 >> This simplifies the code, uses common string-handling helpers, and >> removes the deprecated use of strcpy(). >>=20 >> Link: = https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy = [1] >> Signed-off-by: Thorsten Blum >> --- >> fs/autofs/root.c | 8 +++----- >> 1 file changed, 3 insertions(+), 5 deletions(-) >>=20 >> [...] >=20 > Looks fine to me. >=20 > Acked by: Ian Kent Your tag is missing a hyphen and tools like b4 don't recognize it like this. Correct would be: Acked-by: Ian Kent > Christian, is there anything else I need to do for this? Thanks, Thorsten