From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA257C3F68F for ; Fri, 13 Dec 2019 07:37:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A06C124656 for ; Fri, 13 Dec 2019 07:37:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725980AbfLMHhU convert rfc822-to-8bit (ORCPT ); Fri, 13 Dec 2019 02:37:20 -0500 Received: from coyote.holtmann.net ([212.227.132.17]:59816 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725468AbfLMHhU (ORCPT ); Fri, 13 Dec 2019 02:37:20 -0500 Received: from marcel-macbook.fritz.box (p4FF9F0D1.dip0.t-ipconnect.de [79.249.240.209]) by mail.holtmann.org (Postfix) with ESMTPSA id F13FBCECF0; Fri, 13 Dec 2019 08:46:28 +0100 (CET) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.40.2.2.4\)) Subject: Re: [PATCH v1 2/2] dt-bindings: net: bluetooth: Add device tree bindings for QCA6390 From: Marcel Holtmann In-Reply-To: Date: Fri, 13 Dec 2019 08:37:17 +0100 Cc: Rob Herring , Mark Rutland , Johan Hedberg , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-arm-msm@vger.kernel.org, bgodavar@codeaurora.org, linux-bluetooth-owner@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: <5F24A10B-D0DB-4FE7-8EB1-1028671599FB@holtmann.org> References: <0101016ef8b923bc-5760b40c-1968-4992-9186-8e3965207236-000000@us-west-2.amazonses.com> <24B540FF-C627-4DF9-9077-247A4A6A3605@holtmann.org> To: Rocky Liao X-Mailer: Apple Mail (2.3608.40.2.2.4) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rocky, >>> Add compatible string for the Qualcomm QCA6390 Bluetooth controller >>> Signed-off-by: Rocky Liao >>> --- >>> Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt | 1 + >>> 1 file changed, 1 insertion(+) >>> diff --git a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt >>> index 68b67d9db63a..87b7f9d22414 100644 >>> --- a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt >>> +++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt >>> @@ -10,6 +10,7 @@ device the slave device is attached to. >>> Required properties: >>> - compatible: should contain one of the following: >>> * "qcom,qca6174-bt" >>> + * "qcom,qca6390-bt" >>> * "qcom,wcn3990-bt" >>> * "qcom,wcn3998-bt" >> now I am confused. Is this a DT platform or ACPI or both? > We need to support both, should I update ACPI part in this doc as well? this patch is fine the, but the other one would be better if you split it in DT and ACPI support. Regards Marcel