From: "Barnabás Czémán" <barnabas.czeman@mainlining.org>
To: Bjorn Andersson <andersson@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Tudor Ambarus <tudor.ambarus@linaro.org>,
Jassi Brar <jassisinghbrar@gmail.com>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
linux-kernel@vger.kernel.org, Luca Weiss <luca@lucaweiss.eu>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Stephan Gerhold <stephan.gerhold@linaro.org>
Subject: Re: [PATCH RESEND v2] rpmsg: qcom_smd: Fix fallback to qcom,ipc parse
Date: Mon, 08 Sep 2025 15:55:09 +0200 [thread overview]
Message-ID: <5F4659D9-F163-4149-8602-F53A8AF41568@mainlining.org> (raw)
In-Reply-To: <20250831-fix-qcom-smd-v2-1-a1c0a59d6a3b@mainlining.org>
Should i resend/reword the commit? This change is important for SoCs like 8917 what are still using qcom,ipc (because of cycling dependency) in the rpm,smd node.
On 31 August 2025 00:39:43 CEST, "Barnabás Czémán" <barnabas.czeman@mainlining.org> wrote:
>mbox_request_channel() returning value was changed in case of error.
>It uses returning value of of_parse_phandle_with_args().
>It is returning with -ENOENT instead of -ENODEV when no mboxes property
>exists.
>
>Fixes: 24fdd5074b20 ("mailbox: use error ret code of of_parse_phandle_with_args()")
>Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
>Reviewed-by: Stephan Gerhold <stephan.gerhold@linaro.org>
>Tested-by: Stephan Gerhold <stephan.gerhold@linaro.org> # msm8939
>Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
>---
>mbox_request_channel() returning value was changed in case of error.
>It uses returning value of of_parse_phandle_with_args().
>It is returning with -ENOENT instead of -ENODEV when no mboxes property
>exists.
>
>ENODEV was checked before fallback to parse qcom,ipc property.
>---
>Changes in v2:
>- Drop already applied patch.
>- qcom_smd: rebase
>- Link to v1: https://lore.kernel.org/r/20250421-fix-qcom-smd-v1-0-574d071d3f27@mainlining.org
>---
> drivers/rpmsg/qcom_smd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/rpmsg/qcom_smd.c b/drivers/rpmsg/qcom_smd.c
>index f0f12e7ad2a61922723c16e45738e93bd432c6c6..42594f5ee4385c0071c91d9a5a05fb8517c82bc0 100644
>--- a/drivers/rpmsg/qcom_smd.c
>+++ b/drivers/rpmsg/qcom_smd.c
>@@ -1368,7 +1368,7 @@ static int qcom_smd_parse_edge(struct device *dev,
> edge->mbox_client.knows_txdone = true;
> edge->mbox_chan = mbox_request_channel(&edge->mbox_client, 0);
> if (IS_ERR(edge->mbox_chan)) {
>- if (PTR_ERR(edge->mbox_chan) != -ENODEV) {
>+ if (PTR_ERR(edge->mbox_chan) != -ENOENT) {
> ret = dev_err_probe(dev, PTR_ERR(edge->mbox_chan),
> "failed to acquire IPC mailbox\n");
> goto put_node;
>
>---
>base-commit: d7af19298454ed155f5cf67201a70f5cf836c842
>change-id: 20250421-fix-qcom-smd-76f7c414a11a
>
>Best regards,
prev parent reply other threads:[~2025-09-08 13:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-30 22:39 Barnabás Czémán
2025-09-08 13:55 ` Barnabás Czémán [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5F4659D9-F163-4149-8602-F53A8AF41568@mainlining.org \
--to=barnabas.czeman@mainlining.org \
--cc=andersson@kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=jassisinghbrar@gmail.com \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=luca@lucaweiss.eu \
--cc=mathieu.poirier@linaro.org \
--cc=stephan.gerhold@linaro.org \
--cc=tudor.ambarus@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®