From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967000AbcKXPd4 (ORCPT ); Thu, 24 Nov 2016 10:33:56 -0500 Received: from mga11.intel.com ([192.55.52.93]:32814 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966416AbcKXPdw (ORCPT ); Thu, 24 Nov 2016 10:33:52 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,543,1473145200"; d="scan'208";a="1089963600" From: "Shaikh, Azhar" To: Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" CC: "stable@vger.kernel.org" , Mika Westerberg , Andy Shevchenko , Lee Jones Subject: RE: [PATCH 4.8 12/67] mfd: intel-lpss: Do not put device in reset state on suspend Thread-Topic: [PATCH 4.8 12/67] mfd: intel-lpss: Do not put device in reset state on suspend Thread-Index: AQHSRmde4K2g4ubH/U+PJcozE7cTtaDoQoMw Date: Thu, 24 Nov 2016 15:30:47 +0000 Message-ID: <5FFFAD06ADE1CA4381B3F0F7C6AF582885E462@ORSMSX109.amr.corp.intel.com> References: <20161124145457.061710350@linuxfoundation.org> <20161124145458.303899557@linuxfoundation.org> In-Reply-To: <20161124145458.303899557@linuxfoundation.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjI0YjQ2YzUtNWEyNy00MDU5LWJjOWYtMjQwZTI3MGI1MGQ2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Iktxa291QkNMSlkyMms1SUJ0TGszYVZUeE1UdWhzYTNtR01DT3grUDEyblU9In0= x-originating-ip: [10.22.254.139] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id uAOFY0Gh030311 Hi Greg, Please pick this patch. No concerns. Regards, Azhar Shaikh -----Original Message----- From: Greg Kroah-Hartman [mailto:gregkh@linuxfoundation.org] Sent: Thursday, November 24, 2016 7:27 AM To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman ; stable@vger.kernel.org; Shaikh, Azhar ; Mika Westerberg ; Andy Shevchenko ; Lee Jones Subject: [PATCH 4.8 12/67] mfd: intel-lpss: Do not put device in reset state on suspend 4.8-stable review patch. If anyone has any objections, please let me know. ------------------ From: Azhar Shaikh commit 274e43edcda6f709aa67e436b3123e45a6270923 upstream. Commit 41a3da2b8e163 ("mfd: intel-lpss: Save register context on suspend") saved the register context while going to suspend and also put the device in reset state. Due to the resetting of device, system cannot enter S3/S0ix states when no_console_suspend flag is enabled. The system and serial console both hang. The resetting of device is not needed while going to suspend. Hence remove this code. Fixes: 41a3da2b8e163 ("mfd: intel-lpss: Save register context on suspend") Signed-off-by: Azhar Shaikh Acked-by: Mika Westerberg Reviewed-by: Andy Shevchenko Signed-off-by: Lee Jones Signed-off-by: Greg Kroah-Hartman --- drivers/mfd/intel-lpss.c | 3 --- 1 file changed, 3 deletions(-) --- a/drivers/mfd/intel-lpss.c +++ b/drivers/mfd/intel-lpss.c @@ -502,9 +502,6 @@ int intel_lpss_suspend(struct device *de for (i = 0; i < LPSS_PRIV_REG_COUNT; i++) lpss->priv_ctx[i] = readl(lpss->priv + i * 4); - /* Put the device into reset state */ - writel(0, lpss->priv + LPSS_PRIV_RESETS); - return 0; } EXPORT_SYMBOL_GPL(intel_lpss_suspend);