From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750994AbdK3Sh1 convert rfc822-to-8bit (ORCPT ); Thu, 30 Nov 2017 13:37:27 -0500 Received: from mga06.intel.com ([134.134.136.31]:53175 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750723AbdK3ShZ (ORCPT ); Thu, 30 Nov 2017 13:37:25 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,341,1508828400"; d="scan'208";a="9003467" From: "Shaikh, Azhar" To: Jarkko Sakkinen CC: "jgunthorpe@obsidianresearch.com" , "peterhuewe@gmx.de" , "linux-security-module@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "tpmdd-devel@lists.sourceforge.net" Subject: RE: [PATCH v6 0/2] Fix corner cases with disabling CLKRUN in tpm_tis Thread-Topic: [PATCH v6 0/2] Fix corner cases with disabling CLKRUN in tpm_tis Thread-Index: AQHTafk7Qf0xjWUknUGu5736T6G/VaMtQGHQ Date: Thu, 30 Nov 2017 18:37:23 +0000 Message-ID: <5FFFAD06ADE1CA4381B3F0F7C6AF582897061B@ORSMSX109.amr.corp.intel.com> References: <1511980791-125269-1-git-send-email-azhar.shaikh@intel.com> <20171130163516.uazhkglg7yfzpuvo@linux.intel.com> In-Reply-To: <20171130163516.uazhkglg7yfzpuvo@linux.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjFlOTg4NzUtNDMxYy00NjBiLWIxOGItODBkOTVmZmJjM2ViIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJoRmIwRHI2bDFQTTBMUjdpQmoraFduOEFod1Z1dE9PREJPNHhmbGZWWmZnbTdZVWRUZGowVE1SZ0JsOGROOXJRIn0= dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.22.254.138] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >-----Original Message----- >From: Jarkko Sakkinen [mailto:jarkko.sakkinen@linux.intel.com] >Sent: Thursday, November 30, 2017 8:35 AM >To: Shaikh, Azhar >Cc: jgunthorpe@obsidianresearch.com; peterhuewe@gmx.de; linux-security- >module@vger.kernel.org; linux-kernel@vger.kernel.org; tpmdd- >devel@lists.sourceforge.net >Subject: Re: [PATCH v6 0/2] Fix corner cases with disabling CLKRUN in tpm_tis > >On Wed, Nov 29, 2017 at 10:39:49AM -0800, Azhar Shaikh wrote: >> Changes from v1: >> - Patch 1: "tpm: Keep CLKRUN enabled throughout the duration of >transmit_cmd()" >> - Add NULL checks before calling clk_toggle callback >> - Use IS_ENABLED instead of ifdef in tpm_tis_clkrun_toggle() >> - Do not call tpm_platform_begin_xfer() and tpm_platform_end_xfer() >> from tpm_tis_clkrun_toggle(). Make them static again. >> >> - Patch 2: "tpm_tis: Move ilb_base_addr to tpm_tis_tcg_phy" >> - This is a new patch in this series as per suggestion from Jason. >> - Is the current implementation ok or I should move the code in >tpm_tis_pnp_remove() >> and tpm_tis_plat_remove() inside tpm_tis_remove(). That way all the >unmapping >> can be done in one place, instead of 3 different places now. Also the >unmapping >> in tpm_tis_init() can be moved to tpm_tis_remove(), since in case of error >> tpm_tis_core_init() calls tpm_tis_remove(). Kindly suggest. >> >> Changes from v2: >> - Patch 1: "tpm: Keep CLKRUN enabled throughout the duration of >transmit_cmd()" >> - No changes >> >> - Patch 2: "tpm_tis: Move ilb_base_addr to tpm_tis_tcg_phy" >> - Updated is_bsw() function to have the #ifdef CONFIG_X86 check within >the function >> itself. Also removed the #ifdef CONFIG_X86 from all other places >> around is_bsw() >> >> Changes from v3: >> - Patch 1: "tpm: Keep CLKRUN enabled throughout the duration of >transmit_cmd()" >> - Change function name from clk_toggle to clk_enable >> - Update the commit message. >> >> - Patch 2: "tpm_tis: Move ilb_base_addr to tpm_tis_tcg_phy" >> - No changes >> >> Changes from v4: >> - The numbering of patches is now interchanged. >> >> - Patch 1: "tpm_tis: Move ilb_base_addr to tpm_tis_data" >> - Had to move ilb_base_addr to tpm_tis_data, from tpm_tis_tcg_phy. >> Since the ioremapping of ilb_base_addr had to be done before any TPM >access, >> hence moved the variable to tpm_tis_data. >> - Also move the ioremapping of ilb_base_addr from tpm_tis_init() to >> tpm_tis_core_init() i.e. before any TPM access is done. >> - Rename marco LPC_CNTRL_REG_OFFSET to LPC_CNTRL_OFFSET >> - Update the commit message. >> >> - Patch 2: "tpm: Keep CLKRUN enabled throughout the duration of >transmit_cmd()" >> - Remove the functions tpm_platform_begin_xfer() and >tpm_platform_end_xfer() >> - Move the code from these functions to tpm_tis_clkrun_enable(). >> >> Changes from v5: >> - Patch 1: "tpm_tis: Move ilb_base_addr to tpm_tis_data" >> - No changes >> >> - Patch 2: "tpm: Keep CLKRUN enabled throughout the duration of >transmit_cmd()" >> - Update the commit message. >> >> Azhar Shaikh (2): >> tpm_tis: Move ilb_base_addr to tpm_tis_data >> tpm: Keep CLKRUN enabled throughout the duration of transmit_cmd() >> >> drivers/char/tpm/tpm-interface.c | 6 ++ >> drivers/char/tpm/tpm_tis.c | 121 ++++++--------------------------------- >> drivers/char/tpm/tpm_tis_core.c | 111 >> +++++++++++++++++++++++++++++++++-- >> drivers/char/tpm/tpm_tis_core.h | 17 ++++++ >> include/linux/tpm.h | 1 + >> 5 files changed, 147 insertions(+), 109 deletions(-) >> >> -- >> 1.9.1 > >I'll go through this next week and test with SPI based TPM that it doesn't break >anything. > Sure! Thank you! >/Jarkko Regards, Azhar Shaikh