From: "Georg Müller" <georgmueller@gmx.net>
To: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH v2 3/3] tools/perf: Fix to get declared file name from clang DWARF5
Date: Fri, 9 Jun 2023 14:21:30 +0200 [thread overview]
Message-ID: <5a00d5a5-7be7-ef8a-4044-9a16249fff25@gmx.net> (raw)
In-Reply-To: <166731052936.2100653.13380621874859467731.stgit@devnote3>
Hi,
Am 01.11.22 um 14:48 schrieb Masami Hiramatsu (Google):
> From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
>
> Fix to get the declared file name even if it uses file index 0
> in DWARF5, using custom die_get_decl_file() function.
>
this patch breaks perf probe on fedora 38.
I was trying to a add a probe to systemd-logind using kernel-6.3.6-200.fc38.x86_64 with kernel-tools-6.3.3-200.fc38.x86_64.
When trying to add a probe, I get the following message:
# perf probe -x /usr/lib/systemd/systemd-logind --funcs="match_unit_removed"
match_unit_removed
Function exists and was found:
# perf probe -x /usr/lib/systemd/systemd-logind match_unit_removed
A function DIE doesn't have decl_line. Maybe broken DWARF?
A function DIE doesn't have decl_line. Maybe broken DWARF?
Probe point 'match_unit_removed' not found.
Error: Failed to add events.
When reverting dc9a5d2ccd5c823cc05cafe75fcf19b682d8152c, I was able to add the probe point:
# ./perf probe -x /usr/lib/systemd/systemd-logind match_unit_removed
Added new event:
probe_systemd:match_unit_removed (on match_unit_removed in /usr/lib/systemd/systemd-logind)
You can now use it in all perf tools, such as:
perf record -e probe_systemd:match_unit_removed -aR sleep 1
Probe point is then visible with and without this commit:
# perf probe -l
probe_systemd:match_unit_removed (on match_unit_removed in /usr/lib/systemd/systemd-logind)
# ./perf probe -l
probe_systemd:match_unit_removed (on match_unit_removed@../src/login/logind-dbus.c in /usr/lib/systemd/systemd-logind)
Best regards,
Georg
next prev parent reply other threads:[~2023-06-09 12:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 13:48 [PATCH v2 0/3] tools/perf: Fix perf probe crash by clang DWARF5 file Masami Hiramatsu (Google)
2022-11-01 13:48 ` [PATCH v2 1/3] tools/perf: Fix to avoid crashing if DW_AT_decl_file is NULL Masami Hiramatsu (Google)
2022-11-01 13:48 ` [PATCH v2 2/3] tools/perf: Fix to use dwarf_attr_integrate for generic attr accessor Masami Hiramatsu (Google)
2022-11-01 13:48 ` [PATCH v2 3/3] tools/perf: Fix to get declared file name from clang DWARF5 Masami Hiramatsu (Google)
2023-06-09 12:21 ` Georg Müller [this message]
2023-06-15 11:42 ` Linux regression tracking #adding (Thorsten Leemhuis)
2023-08-29 13:41 ` Linux regression tracking #update (Thorsten Leemhuis)
2023-06-15 14:02 ` Georg Müller
2023-06-15 20:01 ` [PATCH] perf probe: read DWARF files from the correct CU Georg Müller
2023-06-22 22:04 ` Georg Müller
2023-07-11 12:57 ` Arnaldo Carvalho de Melo
2023-07-11 13:20 ` Masami Hiramatsu
2023-07-11 14:41 ` Arnaldo Carvalho de Melo
2023-06-28 8:23 ` [PATCH v2 0/2] perf probe: fix regression introduced by switch to die_get_decl_file Georg Müller
2023-06-28 8:23 ` [PATCH v2 1/2] perf probe: add test for " Georg Müller
2023-07-27 17:45 ` Ian Rogers
2023-07-28 14:41 ` Georg Müller
2023-06-28 8:23 ` [PATCH v2 2/2] perf probe: read DWARF files from the correct CU Georg Müller
2023-06-28 8:41 ` [PATCH v2 0/2] perf probe: fix regression introduced by switch to die_get_decl_file Linux regression tracking (Thorsten Leemhuis)
2022-11-02 0:03 ` [PATCH v2 0/3] tools/perf: Fix perf probe crash by clang DWARF5 file Namhyung Kim
2022-11-03 12:31 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a00d5a5-7be7-ef8a-4044-9a16249fff25@gmx.net \
--to=georgmueller@gmx.net \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®