From: "Sven Peter" <sven@svenpeter.dev>
To: "Stefan Wahren" <wahrenst@gmx.net>
Cc: "Janne Grunau" <j@jannau.net>,
"Alyssa Rosenzweig" <alyssa@rosenzweig.io>,
"Neal Gompa" <neal@gompa.dev>, "Hector Martin" <marcan@marcan.st>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Sebastian Reichel" <sre@kernel.org>,
"Lee Jones" <lee@kernel.org>, "Marc Zyngier" <maz@kernel.org>,
"Russell King" <rmk+kernel@armlinux.org.uk>,
asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v5 07/10] power: reset: macsmc-reboot: Add driver for rebooting via Apple SMC
Date: Sun, 11 May 2025 12:14:46 +0200 [thread overview]
Message-ID: <5a0263f4-1073-45a8-a8aa-76028a2d0b6e@app.fastmail.com> (raw)
In-Reply-To: <678528db-67bc-4bb7-a866-7b8aeb4f4510@gmx.net>
Hi Stefan,
On Sun, May 11, 2025, at 12:07, Stefan Wahren wrote:
> Hi Sven,
>
> Am 11.05.25 um 10:18 schrieb Sven Peter via B4 Relay:
[...]
>> +/* Helpers to read/write a u8 given a struct nvmem_cell */
>> +static int nvmem_cell_get_u8(struct nvmem_cell *cell)
>> +{
>> + size_t len;
>> + u8 val;
>> + void *ret = nvmem_cell_read(cell, &len);
> in case this series needs a respin, please rename the pointer (e.g.
> buf). This is very unusual, because ret is usually of type int.
That's indeed odd, I'll rename it.
Thanks,
Sven
next prev parent reply other threads:[~2025-05-11 10:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-11 8:18 [PATCH v5 00/10] Apple Mac System Management Controller Sven Peter via B4 Relay
2025-05-11 8:18 ` [PATCH v5 01/10] dt-bindings: gpio: Add Apple Mac SMC GPIO block Sven Peter via B4 Relay
2025-05-14 20:55 ` Rob Herring (Arm)
2025-05-11 8:18 ` [PATCH v5 02/10] dt-bindings: power: reboot: Add Apple Mac SMC Reboot Controller Sven Peter via B4 Relay
2025-05-14 20:56 ` Rob Herring
2025-05-11 8:18 ` [PATCH v5 03/10] dt-bindings: mfd: Add Apple Mac System Management Controller Sven Peter via B4 Relay
2025-05-14 20:55 ` Rob Herring
2025-05-11 8:18 ` [PATCH v5 04/10] soc: apple: rtkit: Make shmem_destroy optional Sven Peter via B4 Relay
2025-05-11 16:42 ` Alyssa Rosenzweig
2025-05-11 8:18 ` [PATCH v5 05/10] mfd: Add Apple Silicon System Management Controller Sven Peter via B4 Relay
2025-05-11 16:51 ` Alyssa Rosenzweig
2025-05-12 11:18 ` Sven Peter
2025-05-11 8:18 ` [PATCH v5 06/10] gpio: Add new gpio-macsmc driver for Apple Macs Sven Peter via B4 Relay
2025-05-11 16:45 ` Alyssa Rosenzweig
2025-05-11 8:18 ` [PATCH v5 07/10] power: reset: macsmc-reboot: Add driver for rebooting via Apple SMC Sven Peter via B4 Relay
2025-05-11 10:07 ` Stefan Wahren
2025-05-11 10:14 ` Sven Peter [this message]
2025-05-11 16:44 ` Alyssa Rosenzweig
2025-05-11 22:16 ` Sebastian Reichel
2025-05-12 15:41 ` Sven Peter
2025-05-11 8:18 ` [PATCH v5 08/10] arm64: dts: apple: t8103: Add SMC node Sven Peter via B4 Relay
2025-05-11 8:18 ` [PATCH v5 09/10] arm64: dts: apple: t8112: " Sven Peter via B4 Relay
2025-05-11 8:18 ` [PATCH v5 10/10] arm64: dts: apple: t600x: " Sven Peter via B4 Relay
2025-05-12 12:25 ` [PATCH v5 00/10] Apple Mac System Management Controller Neal Gompa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a0263f4-1073-45a8-a8aa-76028a2d0b6e@app.fastmail.com \
--to=sven@svenpeter.dev \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=j@jannau.net \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=maz@kernel.org \
--cc=neal@gompa.dev \
--cc=rmk+kernel@armlinux.org.uk \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®