From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CDC61A9F91 for ; Fri, 2 Jan 2026 08:52:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767343927; cv=none; b=uzBNP7rshAvlU5zC3jqf6JM+hFSVSak99K81s38P3wdHdKQaBXnVN2FkulD/pH545Bgq+UsXJVbwQ1rPuj4ZDJfxaEWfeV4hx257UGA3gtq+x/59XHyXyQXX+JLadNJy0MHCfvsQoAeI4c3p73jgdeT67m9FHJ73QWpn4O3qZPA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767343927; c=relaxed/simple; bh=6U3tMw573KBKVPM+3adzNWgRKNdq8KgJbc8EAP4NNCM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TzUNCnWMkA7YX3PMoWMpmO9rFTo5t6QhixuH/3BG2PFjEhHlDU5GbsrPiEmAoAm5ioSvg2UmSfT0R/26kx4vm5fBQ2J77AUKuGhXWeN6oWVxeaEO0Os4FjcwDOZNyprhn+WG0fb6oXiFiIGGrZ36Q9b92UhH3mLSJOPSnhppfJ0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fcpkUn/W; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PjXUUlkv; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fcpkUn/W"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PjXUUlkv" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60288084255250 for ; Fri, 2 Jan 2026 08:52:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= dck1FMH5+529OQZs4upRhnI08b0XarE74F/QtaaToY8=; b=fcpkUn/WOOviTj8X hV6IHFdWfup3NuYa6G/ES6qJ8YVIPJP18uVjCzfzMaf0kuR6mZS9KrSoks0qDl/q 6A1f7GVeohIFuUPSI7skCS72BU7RK1W/EwO/pBKE7ni9Hlk5nDgPkV9JOZX66Npn DwvtMnrM8wkh+U8LrI59MRVRbk9HlUymLqzmMe9r22F0U0l9xAzzWCp5OWQBLP6p NIb3TfrMi8osSM/9t5fUGadJ9+8wDljConpsqtCg7N+d6XAqDPSFtCtDrmE3Mgq2 Jv1DJeHDu+v/jy1kJmwQVYD2C1hBEM48KrTgu+mWAP+oaFCtkq3eliX0Yc/IsJDF sIcVNg== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4be6fjrgb9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 02 Jan 2026 08:52:04 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-34c37b8dc4fso25627286a91.2 for ; Fri, 02 Jan 2026 00:52:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767343923; x=1767948723; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dck1FMH5+529OQZs4upRhnI08b0XarE74F/QtaaToY8=; b=PjXUUlkvXCk95L17/MbgI9EtX7uxchGamPmLa99Exn4zPenWRAZVN3l2gKESbFhQZn kGAI0M5penQ1BdzKt12iuDWGme8X24IcciMdqkufeZc/jBS8cIbgdBjVXbdwGo2hf3UF qCdgCu8CDJcvpQlYxuNgOhCAdqrmr9wYWsx2q6EkTMMxZTvW9OYm+PLl8/J07FfIObTD 7fUOpT8V3PjBYfh1Zrs2SgV13CXBHi/W6a6x4lfvxqjbbY8Kb0+QlyuWwj8DculfUihT oEyjWKBnO5iamma6IcfDXFfVCki5l11Vq9F6bg/lGXuaQiugHyN4wIZS5noOghXFj4FR Mg3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767343923; x=1767948723; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dck1FMH5+529OQZs4upRhnI08b0XarE74F/QtaaToY8=; b=eptaUeZX5cUxAmxRV4hG0b+Qd/FZh8bHKeGxKmPOrJUtgp3tmc7BFgFdtDMqX0KsRc jqJ0K0yHg1LYc4cnX/hZ2Y17U754x9TGbyWPG2+L7cdBvvrQoz1kjkaSF1q9Jjx7CZ/3 paSAjUMdXsF/LoylYTWTubAqFDbmBJrFYOtjWSn/RsY+nRIGXRrA/N02RO3W7k/ga5hD o1hghbY0W0bwo2LutXg8ETGt9K2fdp/kd3AzLuu8WQOXqzCv9so6xf/nQVvXU1OUpBA8 NohTYrUnZFhWUZJlCO8t0JtOgZ249jRxauc7hvnouBujY/rI11zeH8jdUxkBexatEIyB /9SQ== X-Forwarded-Encrypted: i=1; AJvYcCWGmS1loG8Yh6rbbwsbPmXEqbLC7l86SSwEkk8SFYJSM1sqN1cVSL6YLHPIiYr/rnhxBA8G7iuYNjeoROQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yz8XqG2XeFD4nSZ35UUzcYUlbiBxZYm06Y7VI2qu3RIghTkpM0n WFhB7fO87eC00j9bvGidDkXHwo0IfEjp4NH5X7uDQBlh7OyG3HA2RfiP4IH1gfjLMPlDKAKUoib ybfDXE/BKZPrMlF01aQo4pNPp9CTSQqyOvaQapKcS3B3Fqq9RX248Vc/vzr5TyEkTgBlsz9jT5D M= X-Gm-Gg: AY/fxX79soQBAueHT0MvY5a5NhUfN0+WBKs/IzDu9omTcOKzXf8YZMyAGqKuQFQLz4O uV/vzObbcYEeaOOhQXo0jivTJ5tykZyYebjiUKGowFc4lQAFu8e3XsRn2JYWw2UCXqAlvx93EhT 0GhsF6Z9ECwvPDLx1oWSZ0XUKIR05M/NHtR3AxolvlpCes1o0vmgVoMuQRG5BH/EScGyR5hYbOx HWutaymUZrkWrqlnOdBMUkracCIKQ6xnKePgYvYYUY3sUszUY/ixJYncVQlCx5alLIhGWoFaQ7X AqUmIxbxZzw3wBhd/srijWOILQx6++LfGx6Ik/eZ9tRwuzoMQUnT4dV69YGbY68U89WmDKtsSNH R3EQWKPjU3RKdVDlORkz8N6P/LzraS11XncsfTPE= X-Received: by 2002:a17:903:2345:b0:2a0:d629:9035 with SMTP id d9443c01a7336-2a2f220cebfmr410902675ad.3.1767343923354; Fri, 02 Jan 2026 00:52:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IGLcFnsdxPHUvpNPGubhk1FmkA837mfXTLkteNRhMhQ3K+KRE9udt9ClOHUIOhvMwftHA+Y9g== X-Received: by 2002:a17:903:2345:b0:2a0:d629:9035 with SMTP id d9443c01a7336-2a2f220cebfmr410902485ad.3.1767343922783; Fri, 02 Jan 2026 00:52:02 -0800 (PST) Received: from [10.217.223.121] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a2f3c66829sm374713935ad.10.2026.01.02.00.51.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Jan 2026 00:52:02 -0800 (PST) Message-ID: <5a064c67-2c15-4ab9-ad34-a56a2e0ec150@oss.qualcomm.com> Date: Fri, 2 Jan 2026 14:21:57 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] arm64: defconfig: Enable QCOMTEE on Qualcomm SM8650+ To: Bjorn Andersson Cc: Sumit Garg , Bjorn Andersson , Dmitry Baryshkov , Krzysztof Kozlowski , Konrad Dybcio , Jens Wiklander , Amirreza Zarrabi , Arnd Bergmann , Geert Uytterhoeven , op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org References: <20251208-qcom_qcomtee_defconfig-v3-1-b50dcf8ab45e@oss.qualcomm.com> <309e0391-58a3-466b-a113-ab864188f6fe@kernel.org> <05581cbd-dfcc-41ac-9020-b1590b8ed7a8@oss.qualcomm.com> <0a4368bf-40a2-42bb-b538-6e64c11598e3@oss.qualcomm.com> Content-Language: en-US From: Harshal Dev In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=Av7jHe9P c=1 sm=1 tr=0 ts=69578734 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=NEAV23lmAAAA:8 a=FZF5ihgMX_pi5EyomNgA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-ORIG-GUID: Y8kbSqC9HXBsLNgUqNxv5fDUv6yJVLZH X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTAyMDA4MSBTYWx0ZWRfX9oeK02hgPOBA yaHcAXLmd4f6ogM7MbsRxKSdHeIFczvbMAkXrgA6Hum890DjJe2Md0FESD9m5/oSabXQyDMNxdL COV/c/ZxR2iVWgtx7jSb4C3rgCRE2wc/PrlgqN0IQOXiM8D7cJNSI9OowaLM+gcwCOabTIYkgt/ r55uZuH21eZxBaq43dHiIdxsFwknTwdNaqcKKHRyWaP8X1MWJOGudeyJc+fhs9RM0E3nwemPUYS n5OaaBsIC3SCtu4bLAOBhX0RGGKDa5GgBaWle0EoRTt43/3riKabjbDTqtJszaYXoReugZJpVfO RHPkYWZ6b4rOzXYmUJ05Ro73CrsNf/b+n4wGZaoH4Uhfr2wZ9GwG3xriEsfJJIy/8VTHUXB/Vw5 pGc1kOfe+OiiVJyfwUP3v4FC40z8MUBh/7OWdrniM9I188t61ZwjmA3sTJbrnvaLjd98rS/F9kt SGsVLzw0mYtS9a2BZKw== X-Proofpoint-GUID: Y8kbSqC9HXBsLNgUqNxv5fDUv6yJVLZH X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-01_07,2025-12-31_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 phishscore=0 priorityscore=1501 suspectscore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 spamscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601020081 Hi Bjorn, On 12/22/2025 10:26 PM, Bjorn Andersson wrote: > On Mon, Dec 15, 2025 at 04:50:39PM +0530, Harshal Dev wrote: >> Hi all, >> >> On 12/12/2025 6:55 AM, Sumit Garg wrote: >>> On Wed, Dec 10, 2025 at 02:35:19PM +0530, Harshal Dev wrote: >>>> Hi Bjorn, >>>> >>>> On 12/10/2025 9:21 AM, Bjorn Andersson wrote: >>>>> On Mon, Dec 8, 2025 at 10:14 PM Dmitry Baryshkov >>>>> wrote: >>>>>> On Tue, 9 Dec 2025 at 07:58, Krzysztof Kozlowski wrote: >>>>>>> >>>>>>> On 08/12/2025 13:18, Harshal Dev wrote: >>>>>>>> Enable QCOMTEE driver on Qualcomm SM8650+ SoCs to facilitate communication >>>>>>>> with the Qualcomm Trusted Execution Environment (QTEE). >>>>>>>> (No enablement required in DTS files since QCOMTEE device is dynamically >>>>>>>> registered by the QCOM_SCM firmware driver) >>>>>>>> >>>>>>>> Signed-off-by: Harshal Dev >>>>>>>> --- >>>>>>>> Changes in v3: >>>>>>>> - Updated the commit message to reflect the supported Qualcomm platforms. >>>>>>>> - Link to v2: https://lore.kernel.org/r/20251205-qcom_qcomtee_defconfig-v2-1-c92560b0346e@qti.qualcomm.com >>>>>>>> >>>>>>> >>>>>>> I gave you the exact example to follow. Maybe it is not that important >>>>>>> for others, so I will not object, but OTOH it is important for me, thus >>>>>>> I will not give reviewed by. I damn asked VERY CLEARLY: >>>>>>> >>>>>>> "Just mention which UPSTREAM boards (which you called Qualcomm >>>>>>> platforms) use this driver." >>>>>> >>>>>> +1 Here. Defconfig changes mention devices, not SoC families. >>>>>> >>>>> >>>>> I don't agree that you have to mention a specific board, if the >>>>> feature is used by all boards. But I think the commit message should >>>>> make _that_ clear. >>>>> >>>> >>>> Thanks for this input Bjorn. I gather we are now aligned that the board >>>> information is not required. >>>> >>>> Then the other part to this is how to provide information on the particular >>>> SoCs using this. >>>> >>>>> On the contrary, the commit message says that we're enabling >>>>> CONFIG_QCOMTEE because it's used on "SM8560+". What does the plus >>>>> mean? >>>> >>>> I took reference from similar commits merged earlier where the plus seemed >>>> to indicate that all Qualcomm SoCs from 'SM8650' on-wards, that is, SM8750, >>>> SM8850 and so on. It felt that the plus sign is self-explanatory since it >>>> has been used already. But sure, maybe we can be explicit from now on and say >>>> from 'Qualcomm SM8650 onwards'. >>>> >>>> commit c5d02bbaa217b2454ba1ce7528113aa2ecf14f3c >>>> >>>>> Also, the driver isn't enabled "on Qualcomm SM8650+", it's enabled in >>>>> the Am64 defconfig, i.e. it's enabled on all Arm64 boards - the >>>>> question that should be answered by the commit message is "why?". >>>>> >>>> >>>> Even though we are enabling this via the arm64 defconfig, it is not true that >>>> the driver is applicable for all arm64 boards. The simple reason being that >>>> the QTEE firmware OS that the driver communicates with runs only on Qualcomm >>>> SoCs using arm64 CPUs with ARM TrustZone technology. >>>> >>>> This is why I would try to avoid a commit message which claims the the driver >>>> is applicable to all arm64 boards. >>>> >>>> Based on all this, I am thinking perhaps it would be better to say that the >>>> patch enables QCOMTEE driver for Qualcomm SoCs with arm64 CPUs? We could drop >>>> mentions of specific SM8x50 models with HDK/MTP boards since the feature is >>>> agnostic to those? >>> >>> AFAIK, the QCOMTEE driver works on the Qcom SoCs based on arm64 which supports >>> the SMCInvoke protocol. So we should be explicit about it. Regarding >>> mention of reference publicly available boards, I can see how it can be useful >>> for the community to test QTEE based apps. If you can mention say >>> example RB3Gen2 supports QTEE driver at least then it will be helpful. >>> >> >> Based on consolidated feedback on this thread, I am thinking of the following >> commit message, let me know if this is a go from everyone's perspective: >> >> " >> arm64: defconfig: Enable QCOMTEE for Qualcomm SoCs using arm64 CPUs >> >> Enable QCOMTEE driver as a module for Qualcomm SoCs based on arm64 CPUs and >> supporting the SMCInvoke protocol for communication with the Qualcomm Trusted >> Execution Environment (QTEE). >> >> The driver is tested on a Qualcomm RB3Gen2 board by loading and executing a >> Trusted Application via tests hosted at www.github.com/qualcomm/minkipc. >> " > > I don't think this answers Krzysztof's question, and it doesn't address > my concern. > > You're saying that you're enabling the driver for Qualcomm-based Arm64 > SoC which supports SMCInvoke. But as I said, that's not what you're > doing; you are enabling the driver for all Arm64 boards, from all > vendors, regardless of them having SMCInvoke or not. > > The commit message should be in the form of: > > "All QTEE-based Qualcomm targets, since SM1234, provides access to the > secure world through the SMCInvoke interface, which is implemented in > the qcomtee driver. Enable this driver in order to ..." > I agree that the defconfig change effectively enables the driver for all arm64 boards, not just Qualcomm SoC based ones. To clarify this in the commit message, let me explicitly state the following: - Why we are enabling it for all arm64 boards. - From which Qualcomm SoC onwards the driver is applicable to. - What functionality the driver provides. - How it's functionality has been tested and on which board. " arm64: defconfig: Enable QCOMTEE module for QTEE-enabled Qualcomm SoCs All Qualcomm SoCs starting from SM8650 provide access to the Qualcomm Trusted Execution Environment (QTEE) through the SMCInvoke interface, implemented by the QCOMTEE driver. QTEE runs in the Secure World domain on ARM64 CPUs and exposes secure services to Linux running in the Normal World domain. This change enables the QCOMTEE driver as a module to support communication with QTEE. QCOMTEE has been tested on a Qualcomm RB3Gen2 board by loading and executing a Trusted Application via tests hosted at github.com/qualcomm/minkipc. " This should make it clear to all arm64 board vendors that this change, although being done for all arm64 boards, is only applicable to the ones with Qualcomm SoC and QTEE support. Thank you, Harshal > Regards, > Bjorn > >> >> Regards, >> Harshal >> >>> -Sumit >>> >>> [...] >>