From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62792C43142 for ; Sun, 29 Jul 2018 00:17:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0C9C920894 for ; Sun, 29 Jul 2018 00:17:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="JvIG3v1x" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0C9C920894 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731749AbeG2Boe (ORCPT ); Sat, 28 Jul 2018 21:44:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:49910 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731487AbeG2Boe (ORCPT ); Sat, 28 Jul 2018 21:44:34 -0400 Received: from [172.20.7.115] (unknown [209.119.211.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E75D520894; Sun, 29 Jul 2018 00:16:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1532823374; bh=PlkYu9DCajcc9ZCtlcmIyFtY1Qg5pEittvLh8j0JKto=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=JvIG3v1x74azysl/6RKlNJ3OWdeBiDWcADD3ZC8R5Ayms936dCzjKiRWgHsQvxAJd WOWF0WFTmpJ1+/rquus9TXTAGBjO/9cqlh8eNKR8LaiBtx+cYQLlm7KNURSo+Bit2V ra8hCWFuo+GR78TfTVv0Gk2GGgb/izg9rUOHZbjc= Subject: Re: [PATCH v2] pci/aspm: Remove CONFIG_PCIEASPM_DEBUG To: Bjorn Helgaas , Rajat Jain Cc: Bjorn Helgaas , Keith Busch , Vidya Sagar , Philippe Ombredanne , Kees Cook , "Gustavo A. R. Silva" , Ard Biesheuvel , Sinan Kaya , Frederick Lawler , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, mayurkumar.patel@intel.com, rajatxjain@gmail.com, Richard Hughes , Carlos Garnacho , "Rafael J. Wysocki" , Pali Rohar , Takashi Iwai , Andy Whitcroft , Colin Ian King References: <20180508230148.121852-1-rajatja@google.com> <20180510233912.96454-1-rajatja@google.com> <20180727202619.GD173328@bhelgaas-glaptop.roam.corp.google.com> From: Sinan Kaya Message-ID: <5a102163-73bc-c596-8266-186e222e7ceb@kernel.org> Date: Sat, 28 Jul 2018 17:16:13 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180727202619.GD173328@bhelgaas-glaptop.roam.corp.google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/27/2018 1:26 PM, Bjorn Helgaas wrote: > - A link can lead to a multi-function device, and the spec allows > those functions to have different ASPM settings (see PCIe r4.0, > sec 5.4.1). With the sysfs files at the upstream end of the link, > we have no way to configure those functions individually. Even though we can set them individually, there is only one PCIe link for single function as well as multi-function devices. It would be a user mistake to allow individual PCIe functions with different ASPM policies. (maybe, we should enforce it if we are not doing it already).