From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3765B1C5496 for ; Fri, 20 Dec 2024 11:28:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734694110; cv=none; b=osPp/10/4vGMgBGC33A8KVMTL0ZMS/tSLeQgPJTWDhiIXcu5GNMB7nmW3g5vM/p6O+E1jydoXUbs8grJ1XiGhQk/wIKZ6YXerJnJamPufG1KmV1C+DRWRwm+HuBhqcIGzRJ9Ze+8PC/DAq5D1F6M5e4eozCkVNnOSffJ0oFkywM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734694110; c=relaxed/simple; bh=rWozyOKF8nOruOVkNfUo6Dd76MjT/V4zPfUzW/HR6mw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TdVuGRSLAL0W2rvx+QWmT1w+I5DTGqonQagQV0koj+r/lyXuLLga58YLqvhJtELDS/ooZ8MToRsqy4NS2OASei4x0sY2IEvYoIoHnKOL5R3G1GB7IJcFrOfWNHCry0/swVw3Hg1qT3FOn8fdaJ3XU3Bdzjs9ZrgQ63Fet1DiU4c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com; spf=pass smtp.mailfrom=bytedance.com; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b=VyH7r+B/; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bytedance.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b="VyH7r+B/" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2163b0c09afso16466175ad.0 for ; Fri, 20 Dec 2024 03:28:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1734694108; x=1735298908; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=21ChRuu8yrudlhbMUFmroRe43ep4NsuojDzgWxvh1kk=; b=VyH7r+B/rSYi5IZs3YfNl9J9mKglrCS+Cpqw/i/j7IHSOvagp3KqZ6eFiFarBssrJp R44uESv3mIDKLs7P5wmrMdZWQrsjhVE1/yb94tGySWhZ4bM5m8grDc8+J1G1c8BGs/lD vlNwrwhUkCRl1uQBOieirStlRL54gn9c2A9ECMumK/AsLsD0D8B9IVbHtjyiS+rZXi3m R1g7Gu7a19r4HuG6uawQzl6lR/yuPpJe/Ok9mn83sVrBEz7iazvIauDjomColK5ljTsZ ib3q72F1r3DBXbH4UyKEo3E07XY8IJaIHMNNvtn6pTE5EAiso6129c/Y6GHUz9Q08iag 5g9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734694108; x=1735298908; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=21ChRuu8yrudlhbMUFmroRe43ep4NsuojDzgWxvh1kk=; b=flVKFTtCBn/NMdF5E2JC2izyIOX/oIza03hOr1tLADfKz3BdewIf5CC9hgm59o50Ad uKyqaeYg4HI/pUdr6DnVuPn8j05ANIygCtGR8fsTMfCtoRoucC3gwGiG0YONyiHnsCkx V+YeYXYSfmRiY+BP+vTPvJqh3VvHlQo4rY13PrwJ1+DaHSWbXVWcL3UWfAY4uRjtKfOZ eRlkp22O8OH01ci/3LvHjJ08ddBQ39+hbsaczjpQnwm+MapaCXsNYaVXWeszWsH0GEMD KLaXjWfq6owQSmSVfUX6+n9N756RFRGazAIqyt0U0iPCbI5dQgDPzs9LXH/u/eohcw6f TCew== X-Forwarded-Encrypted: i=1; AJvYcCXL8XRq8zk13R6ChEX/OeuDhRbSpazRPeIRfQSD/NW5gd3wkxldsCNxXfhNvr7KpPr//RuwA/hR6DBNo90=@vger.kernel.org X-Gm-Message-State: AOJu0YxTS77typGIPaUPMrJyCAow9qRVVu2hoHGuEOpM9DNS5UPBcrIx GPZZ5K7WVpPo35VwdQbfKNHadzzXvSgaR6gQDpzyAIvStAd+FKnfdPNlyCNszgs= X-Gm-Gg: ASbGncshufTYxGD/rDsaIYAajUd6wsFU/xwCuj/CgEcAoVyfBQEzPnWpuLR2UIVuNrf TfBlS1B1CCzDCD7yGKQeey0opJ2p0t5yrjhxPKtXpgWOQw0vGMJjcIZEWsZqOqZgZpB1w4qGCQU eKdxGpKg1wEA47V4Wf7t2FnyoqcNnDoJWD90hT8QAX9jC0SXJiC2YCi7C2OU9K9CFc2JDPywjHm Rw8Eq08k9SvzdK0G/nV75dgQJ0jeH2nZ9jF1WjySiuGU677d90D51NLvbTdW0ctT6QKP5TPz0f0 noHBxXdK4eEcm6DFUPJoK1wLfDDLTDTIUoCr/jOFJwbLuuKkUgI0VPE= X-Google-Smtp-Source: AGHT+IG2eboPLo+Ew9YrtTCgGSW4HYq6crWyqba1BAZv9J/dD0TlKj3g/rfAwadizDRDrDxkkqmJsg== X-Received: by 2002:a17:903:41c8:b0:215:b058:289c with SMTP id d9443c01a7336-219e6e85beemr28103175ad.8.1734694108275; Fri, 20 Dec 2024 03:28:28 -0800 (PST) Received: from ?IPV6:2409:8a28:f44:3764:680a:144b:d927:5a3b? ([2409:8a28:f44:3764:680a:144b:d927:5a3b]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc96e85csm27002575ad.61.2024.12.20.03.28.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Dec 2024 03:28:27 -0800 (PST) Message-ID: <5a125dc8-4443-4da4-b40f-15c8c80449cb@bytedance.com> Date: Fri, 20 Dec 2024 19:28:20 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 11/15] mm: pgtable: introduce generic __tlb_remove_table() Content-Language: en-US To: Alexander Gordeev Cc: peterz@infradead.org, tglx@linutronix.de, david@redhat.com, jannh@google.com, hughd@google.com, yuzhao@google.com, willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org, lorenzo.stoakes@oracle.com, akpm@linux-foundation.org, rientjes@google.com, vishal.moola@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2024/12/20 19:18, Alexander Gordeev wrote: > On Wed, Dec 18, 2024 at 09:04:47PM +0800, Qi Zheng wrote: >> Several architectures (arm, arm64, riscv, s390 and x86) define exactly the >> same __tlb_remove_table(), just introduce generic __tlb_remove_table() to >> eliminate these duplications. > > s390 is nearly the same, but not exactly (see below). > >> arch/s390/include/asm/tlb.h | 1 - >> arch/s390/mm/pgalloc.c | 7 ------- > ... >> --- a/arch/s390/mm/pgalloc.c >> +++ b/arch/s390/mm/pgalloc.c >> @@ -193,13 +193,6 @@ void page_table_free(struct mm_struct *mm, unsigned long *table) >> pagetable_dtor_free(ptdesc); >> } >> >> -void __tlb_remove_table(void *table) >> -{ >> - struct ptdesc *ptdesc = virt_to_ptdesc(table); >> - >> - pagetable_dtor_free(ptdesc); > > With this change you introduce these duplication in __tlb_remove_table() > and in pagetable_dtor_free(): > > pagetable_dtor(ptdesc); > pagetable_free(ptdesc); > > But I still would prefer to avoid __HAVE_ARCH_TLB_REMOVE_TABLE. > Could it be possible to move pagetable_dtor_free() to asm-generic and > make s390 __tlb_remove_table() version generic? Yes, see my reply to Peter below: https://lore.kernel.org/lkml/3f9a5475-930d-4f45-8fc8-8d2e8a6a08cc@bytedance.com/ I will do it in v3. And I have make pagetable_dtor_free() generic in [PATCH v2 15/15]. > >> -} >> - >> #ifdef CONFIG_TRANSPARENT_HUGEPAGE >> static void pte_free_now(struct rcu_head *head) >> { > > Thanks!