From: Robert Karszniewicz <r.karszniewicz@phytec.de>
To: Christoph Hellwig <hch@lst.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Tejun Heo <tj@kernel.org>
Cc: Siddharth Gupta <sidgup@codeaurora.org>, <linux-kernel@vger.kernel.org>
Subject: Re: restore splice and sendfile support on kernfs
Date: Thu, 21 Jan 2021 18:41:35 +0100 [thread overview]
Message-ID: <5a13228c-6003-2499-a987-23d39f1926cf@phytec.de> (raw)
In-Reply-To: <20210120204631.274206-1-hch@lst.de>
On 1/20/21 9:46 PM, Christoph Hellwig wrote:
> Hi Greg and Tejun,
>
> this fixes a regression in Linux 5.10 that stopped sendfile and splice
> from working on kernfs/sysfs files.
>
> Diffstt:
> file.c | 65 ++++++++++++++++++++++++-----------------------------------------
> 1 file changed, 24 insertions(+), 41 deletions(-)
>
Tested-by: Robert Karszniewicz <r.karszniewicz@phytec.de>
Confirm that it fixes firmwared for me.
Also, I am 100% sure that the commit that actually breaks firmwared for me is
4d03e3cc5982 ("fs: don't allow kernel reads and writes without iter ops")
which is one commit right before
36e2c7421f02 ("fs: don't allow splice read/write without explicit ops")
. I just verified it again.
Thank you,
Robert
prev parent reply other threads:[~2021-01-21 17:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 20:46 Christoph Hellwig
2021-01-20 20:46 ` [PATCH 1/3] kernfs: implement ->read_iter Christoph Hellwig
2021-01-20 20:46 ` [PATCH 2/3] kernfs: implement ->write_iter Christoph Hellwig
2021-01-20 20:46 ` [PATCH 3/3] kernfs: wire up ->splice_read and ->splice_write Christoph Hellwig
2021-01-21 17:30 ` restore splice and sendfile support on kernfs Greg Kroah-Hartman
2021-01-21 17:41 ` Robert Karszniewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a13228c-6003-2499-a987-23d39f1926cf@phytec.de \
--to=r.karszniewicz@phytec.de \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=sidgup@codeaurora.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®