From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f42.google.com (mail-oo1-f42.google.com [209.85.161.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7854353ED7 for ; Wed, 28 Jan 2026 13:28:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769606937; cv=none; b=HcvGShlJCH8vfswsCVhjBtqV6XfBzg2P+vO9iTg796CGSOM4u0nmVUov0tuJFOrmxTF7AAgnqXNHzspFXp4VUFvnsXTeT2Z0TAben8uUGx3+cjfx42z1Sd8xZqBq9KcWf22O1VjjLQXgutA3e6ilW+KAFIPjrxnVYyosbx1eqD8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769606937; c=relaxed/simple; bh=zmxOPeXvnOtchYfum5MfPM2ufP91Bp+oj32pDPeoclk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WYlQz1tlpp/et5Jmb9YKy9A1MsiemrqOLYkSt3VgDonYXLDbQto/T1kHNcfmh6W6X0wja5687LmWdp9jAMI64gFapsU34UlO3OyuuIiRkLlSh5Cqff+RjBw1Lv7WYKg7hSifpuIkYg8/awTVelw2KiD6C92dOLdeISL1x44hGvQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b=NFCpgi5y; arc=none smtp.client-ip=209.85.161.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b="NFCpgi5y" Received: by mail-oo1-f42.google.com with SMTP id 006d021491bc7-6611c3b147eso4370334eaf.2 for ; Wed, 28 Jan 2026 05:28:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20230601.gappssmtp.com; s=20230601; t=1769606935; x=1770211735; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=l7l6hZpxqhowIar9wP3g3p3H24Q2QksV27F6NMf90mY=; b=NFCpgi5yZgnPMtIJAjjco+CiEsHER5KIjfxc+A84u/q1ZZtWm3EUgM/XbT67ImhXvS caJp+27vsUYCjVq5oAbZXYQn5ZfmgCb4wiAtUl5hguNx/MztGnq0tLZ9eNLF3xHY63U5 m7zBewIwaj8GrJLxeC/ET3qFa3/M9EWE1XLCwzEkcrTjpr7MgnjrnCWYTfYkHcIcLNW5 WddOQO/gwLD4Z+FxB7jbt2NAx35jNBq3/pXQFTWye8b5mXCg7nJulqec9QBZKCTxDQ8M J3MbPPlee/F+BTEqhvshDOuK4K/4d1nVsJHkEfRLf2b1BAsPVrfgLQV1EHvcW8L6AMrm jGQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769606935; x=1770211735; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=l7l6hZpxqhowIar9wP3g3p3H24Q2QksV27F6NMf90mY=; b=wvayT3HwxsPVdu7CEjxVoW6EHr5J35rHrTspNxiJl/zEUAVTWjrBjVcQEMaoYchiIy Kp0+Ci5s4WhCvsoCcf5uv5xvSkVd5ML8AD0iE0l8FnRyK3oZQWX/w7x4ySMyt2zrydAW nNG5gX4y5ea6B/KWjOdNZTvC4aIs4cKZcJTQyxA45KrHgnUAXwU0CI8DLDnXKJeQ7gvd aIbJCu5nAYejK6y1RQ55yfenm9qoYbxbL/PHFThmcHXSOpKm2KamElP1CKe90QRTaiXR sMYnfzHrtD2QcLnDn4vikya0Eu/IUbUPNMk4+P3Ydpk4f0YaDs0Az/UdEKKAGovUe6D/ erxw== X-Gm-Message-State: AOJu0YyFFU4XTw72hXEjvCnAK+zQAq8PD45VH4sEsgY6zvkwqxw6/SZI 4FQMwFjsq8kOQPlgcMbJ7gpkReGxC8DMIoxdZjZ+aV5Js1iqR/eLNozUhJghqcy97TM= X-Gm-Gg: AZuq6aLA6882/dJ0jE8wvKwGTyMpsFk0e/rMVx0oWXdS5CSBd/1qvXXioxixce6vn9x Awvd0jGQFQtG3d/J6o+xNnBVlm41Sr9d0J5rb3+nZqYJGJzQIyo4ZGf4Hr4l8DyItDPPpsMHyvx Q1VMxmDZ+sSV7pv4jTOeAJL7kxzbS4APMlDiFnw+uYbvEqQCvRs7nilQtWXxscY7KhaIhBFsrko zAdrvg3lmkDU6pki5QT1TtIGmK+rZqnbz850vvlnMJcugr6n4vEHP2JFxs2swVIBd1oYnSL98QG A7BFfZGjUAOxg6IYjjttB94zOji9KfzJRxYB3ppLEZj+5Lps4gtXqa4csHlEhwrW5Uvk6Oad715 Rkt61eZYCUBNQPEzj8qVl0fhV/s/Hj1vySU9F6yj8eavur0w2c2CfCkzxquEOHO6MKWJx1PV/Hk KNMyd5V1fVpfv39tT4Cz0JwDcIFwaWB1F99bt2EJMxdcFJjSuq/XI= X-Received: by 2002:a05:6820:134f:b0:662:ecc7:7193 with SMTP id 006d021491bc7-662f20d5753mr2863092eaf.54.1769606934872; Wed, 28 Jan 2026 05:28:54 -0800 (PST) Received: from [172.22.22.28] (c-75-72-117-212.hsd1.mn.comcast.net. [75.72.117.212]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-662f994388fsm1374132eaf.4.2026.01.28.05.28.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Jan 2026 05:28:54 -0800 (PST) Message-ID: <5a1825e3-3517-4d17-aa8f-b0261245d9bb@riscstar.com> Date: Wed, 28 Jan 2026 07:28:53 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/4] dt-bindings: mfd: spacemit,p1: Add individual regulator supply properties To: Guodong Xu , Liam Girdwood , Mark Brown , Yixun Lan , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Troy Mitchell , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti Cc: linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, devicetree@vger.kernel.org References: <20260124-spacemit-p1-v2-0-2c86b06694ba@riscstar.com> <20260124-spacemit-p1-v2-2-2c86b06694ba@riscstar.com> Content-Language: en-US From: Alex Elder In-Reply-To: <20260124-spacemit-p1-v2-2-2c86b06694ba@riscstar.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/23/26 6:20 PM, Guodong Xu wrote: > Add supply properties that match the P1 PMIC's actual hardware topology > where each buck converter has its own VIN pin and LDO groups share > common input pins. Supply names are defined according to the pinout > names in the P1 datasheet. > > This allows different boards to describe their actual power tree > connections in devicetree rather than hardcoding supply relationships > in the driver. > > Signed-off-by: Guodong Xu Your additions match what I see in the data sheet. This looks good, thank you. Reviewed-by: Alex Elder > --- > v2: Remove providers from the dts example. > Pass the 'make dt_binding_check' test. > --- > .../devicetree/bindings/mfd/spacemit,p1.yaml | 49 +++++++++++++++++++++- > 1 file changed, 47 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mfd/spacemit,p1.yaml b/Documentation/devicetree/bindings/mfd/spacemit,p1.yaml > index c6593ac6ef6a..c67b1c6e4e4f 100644 > --- a/Documentation/devicetree/bindings/mfd/spacemit,p1.yaml > +++ b/Documentation/devicetree/bindings/mfd/spacemit,p1.yaml > @@ -27,8 +27,41 @@ properties: > interrupts: > maxItems: 1 > > - vin-supply: > - description: Input supply phandle. > + vin1-supply: > + description: > + Power supply for BUCK1. Required if BUCK1 is defined. > + > + vin2-supply: > + description: > + Power supply for BUCK2. Required if BUCK2 is defined. > + > + vin3-supply: > + description: > + Power supply for BUCK3. Required if BUCK3 is defined. > + > + vin4-supply: > + description: > + Power supply for BUCK4. Required if BUCK4 is defined. > + > + vin5-supply: > + description: > + Power supply for BUCK5. Required if BUCK5 is defined. > + > + vin6-supply: > + description: > + Power supply for BUCK6. Required if BUCK6 is defined. > + > + aldoin-supply: > + description: > + Power supply for ALDO1-4. Required if any are defined. > + > + dldoin1-supply: > + description: > + Power supply for DLDO1-4. Required if any are defined. > + > + dldoin2-supply: > + description: > + Power supply for DLDO5-7. Required if any are defined. > > regulators: > type: object > @@ -58,6 +91,10 @@ examples: > compatible = "spacemit,p1"; > reg = <0x41>; > interrupts = <64>; > + vin1-supply = <®_vcc_5v>; > + vin5-supply = <®_vcc_5v>; > + aldoin-supply = <®_vcc_5v>; > + dldoin1-supply = <&buck5>; > > regulators { > buck1 { > @@ -68,6 +105,14 @@ examples: > regulator-always-on; > }; > > + buck5: buck5 { > + regulator-name = "buck5"; > + regulator-min-microvolt = <500000>; > + regulator-max-microvolt = <3450000>; > + regulator-ramp-delay = <5000>; > + regulator-always-on; > + }; > + > aldo1 { > regulator-name = "aldo1"; > regulator-min-microvolt = <500000>; >