From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752337AbdGRUIk (ORCPT ); Tue, 18 Jul 2017 16:08:40 -0400 Received: from mail-pg0-f53.google.com ([74.125.83.53]:36196 "EHLO mail-pg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751510AbdGRUIg (ORCPT ); Tue, 18 Jul 2017 16:08:36 -0400 Subject: Re: [PATCH 1/4] rtc-lib: Add rtc_show_time(const char *prefix_msg) From: Mark Salyzyn To: Alexandre Belloni Cc: linux-kernel@vger.kernel.org, rjw@rjwysocki.net, len.brown@intel.com, pavel@ucw.cz, linux-pm@vger.kernel.org, a.zummo@towertech.it, linux-rtc@vger.kernel.org References: <20170718172525.114514-1-salyzyn@android.com> <20170718175224.xccqnv4zjggn4shu@piout.net> Message-ID: <5a1a1eab-5d5b-b91c-2990-abbd2d17480e@android.com> Date: Tue, 18 Jul 2017 13:08:35 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/18/2017 01:00 PM, Mark Salyzyn wrote: > On 07/18/2017 10:52 AM, Alexandre Belloni wrote: >> Hi, >> >> On 18/07/2017 at 10:25:23 -0700, Mark Salyzyn wrote: >>> . . . >> Apart from using rtc_time_to_tm (and you should probably use >> rtc_time64_to_tm), none of this is actually related to the RTC >> subsystem. I feel like you should find another place to put that, maybe >> timekeeping_debug.c? > Makes a lot of sense! > > -- Mark Ooops, timekeeping_debug.c is currently only to support a debugfs node. Perhaps a _new_ file in that hierarchy like kernel/time/rtc_show_time.c. -- Mark