From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from canpmsgout01.his.huawei.com (canpmsgout01.his.huawei.com [113.46.200.216]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5CC43093DD for ; Thu, 23 Jul 2026 01:54:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=113.46.200.216 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784771698; cv=none; b=OsUy1U5kWlom25sT2PyVsckZGqq6zGh3q6dr/1Ja328Dej7SY97dv+/ci+eAdu0Ofy00uLTzGU0IVPHYw3BCQhHm+pgnrUE4IKpXLClU+L9BBRzEfU9iiGAYGJeFezWAOjVQ6HdpcNSCfEfNxdVFFSef/G+8E1JyRM6saSGGJx0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784771698; c=relaxed/simple; bh=DsCNdK+44yQa7FiMKCGX1YVEL80FS1snSqzW1bu5omU=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=oRY6xiPUDJ4uDE9NdCz4R15uie3ykyD0VA0o3yuikj2I6eseHROwh69hGFrC6rVmiIUMN4jqpSPzBAnFoOKHhDYtEFaP0L2Vn3Z/sgPKfaz/t5heanomeQID8QFeOPmaP7jCcunqxSulS4GsX+Zz8uY610Xxw6igcLW2f0FAu7w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b=Hp2fr+eL; arc=none smtp.client-ip=113.46.200.216 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b="Hp2fr+eL" dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=ywYub6wAD+jWjHOKqOLf/FFBRh9k7vGnHg3v0LBqTPs=; b=Hp2fr+eL8d+7nGr2HKuNoE+794wuVsTucWVzdE40kbsCKHajUrBfqnINVC44taxA3OM1+ccnH 0CNp+pxpyQZhw9sbuJeW4heLU1u9qQ8Vx4+VvWGD0Grb0n15LCa7e0Y0QbIb4AOjvHHPdy8J3KK HAyZ7GPZQBBpASoLXjmfgbY= Received: from mail.maildlp.com (unknown [172.19.163.104]) by canpmsgout01.his.huawei.com (SkyGuard) with ESMTPS id 4h5DTS50dqz1T4MQ; Thu, 23 Jul 2026 09:45:16 +0800 (CST) Received: from dggpemf500011.china.huawei.com (unknown [7.185.36.131]) by mail.maildlp.com (Postfix) with ESMTPS id 436894057F; Thu, 23 Jul 2026 09:54:38 +0800 (CST) Received: from [10.67.109.254] (10.67.109.254) by dggpemf500011.china.huawei.com (7.185.36.131) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 23 Jul 2026 09:54:36 +0800 Message-ID: <5a200b28-d970-462b-ab49-ccb6bbe6c94c@huawei.com> Date: Thu, 23 Jul 2026 09:54:36 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v17 15/15] arm64: vdso: Expose sigreturn address on vdso to the kernel To: Mark Rutland , Linus Walleij CC: , , , , , , , , , , , , , , , , , , , , References: <20260721081858.1169276-1-ruanjinjie@huawei.com> <20260721081858.1169276-16-ruanjinjie@huawei.com> From: Jinjie Ruan In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: kwepems500001.china.huawei.com (7.221.188.70) To dggpemf500011.china.huawei.com (7.185.36.131) 在 2026/7/23 2:18, Mark Rutland 写道: > On Tue, Jul 21, 2026 at 10:55:03AM +0200, Linus Walleij wrote: >> On Tue, Jul 21, 2026 at 10:19 AM Jinjie Ruan wrote: >> >>> Syscall User Dispatch (SUD) must not intercept the signal trampoline >>> code, otherwise returning from a signal with a locked selector may >>> cause infinite recursion into the signal handler. >>> >>> Provide an arm64 implementation of arch_syscall_is_vdso_sigreturn() >>> to exclude these sigreturn syscalls from dispatch. >>> >>> For native 64-bit tasks, check whether the current PC matches the 'svc #0' >>> instruction inside the vDSO sigreturn trampoline (defined in >>> arch/arm64/kernel/vdso/sigreturn.S as below). >>> >>> SYM_CODE_START(__kernel_rt_sigreturn) >>> mov x8, #__NR_rt_sigreturn >>> svc #0 >>> SYM_CODE_END(__kernel_rt_sigreturn) >>> >>> For COMPAT tasks, verify that the instruction falls within the dedicated >>> 'sigpage' range, since compat signal handlers use this architecture- >>> specific page (not the vDSO) for their return trampoline. This prevents >>> SUD from incorrectly dispatching syscalls issued during signal return. >>> >>> Suggested-by: Thomas Weißschuh >>> Suggested-by: Kevin Brodsky >>> Suggested-by: kemal >>> Signed-off-by: Jinjie Ruan >> >> I'm a bit scared about SUD. >> >> Certainly we can merge patches 1-14 first and iron out >> any trouble related to that and split this off so a separate >> series to be applied lated? > > I had already asked Jinie to drop SUD back in v14, and he had agreed: > > https://lore.kernel.org/lkml/akegeU59jSK9t7FX@J2N7QTR9R3/ > https://lore.kernel.org/lkml/3ac6d4be-7c57-44c2-80a0-408e2c6f8136@huawei.com/ > > Jinjie, please drop this for now, as we had _already_ agreed. Ah, sorry about that.I will drop this SUD patch in the next revision. > > I will look over the rest of the series soon. Thank you! I look forward to your review and feedback on the rest of the patches. Thanks, Jinjie > > Mark. >