From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 117CAECE560 for ; Mon, 17 Sep 2018 15:24:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BC8A2206B8 for ; Mon, 17 Sep 2018 15:24:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="pj1ix4bc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC8A2206B8 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729267AbeIQUwc (ORCPT ); Mon, 17 Sep 2018 16:52:32 -0400 Received: from lelv0143.ext.ti.com ([198.47.23.248]:34024 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726885AbeIQUwc (ORCPT ); Mon, 17 Sep 2018 16:52:32 -0400 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id w8HFOaaf050826; Mon, 17 Sep 2018 10:24:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1537197876; bh=8/0ZQRFGW8zpHFo3AHbvL0R6U56q+Ge4VdEnyDC1IiI=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=pj1ix4bcfE9Hc2ZuTh7ZuWsPaG/mf9Ly+soKw5C7mYsteYbPXB6/LsCQ9l2elteGj qRYdLgGMyheJznicj+/vw1DW073aAc7zyEpkBXcHGy9G5tHGZ2DINgSxpcAHX8/7Bc HJz1SXuvvyZKn/BVobQD5YNzEWKfMTvMQ9fUg80M= Received: from DFLE109.ent.ti.com (dfle109.ent.ti.com [10.64.6.30]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id w8HFOZ3Q020866; Mon, 17 Sep 2018 10:24:35 -0500 Received: from DFLE111.ent.ti.com (10.64.6.32) by DFLE109.ent.ti.com (10.64.6.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Mon, 17 Sep 2018 10:24:35 -0500 Received: from dlep33.itg.ti.com (157.170.170.75) by DFLE111.ent.ti.com (10.64.6.32) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1466.3 via Frontend Transport; Mon, 17 Sep 2018 10:24:35 -0500 Received: from [172.22.185.20] (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id w8HFOZGX016542; Mon, 17 Sep 2018 10:24:35 -0500 Subject: Re: [PATCH v7 1/6] dt-bindings: ti-lmu: Remove LM3697 To: Jacek Anaszewski , Pavel Machek CC: , , , , , References: <20180911170825.17789-1-dmurphy@ti.com> <20180911170825.17789-2-dmurphy@ti.com> <20180911200530.GA28290@amd> <85ab3bf4-21d4-dda9-a7c8-5ed68f15c611@ti.com> <20180912214938.GA30654@amd> <7950fa32-c8f9-52bb-06b0-0c1cc93b6bc9@ti.com> <20180914081822.GA21830@amd> <9c14ee7c-f172-bb0c-d9a8-8aeee408f716@gmail.com> <20180914214220.GA2081@amd> From: Dan Murphy Message-ID: <5a249ae3-e3f7-8eff-4022-ed982e364326@ti.com> Date: Mon, 17 Sep 2018 10:24:21 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jacek On 09/15/2018 03:00 PM, Jacek Anaszewski wrote: > Hi Pavel. > > On 09/14/2018 11:42 PM, Pavel Machek wrote: >> Hi! >> >>>> You may want to learn more about device tree and/or talk to the device >>>> tree maintainers. This is an old article. https://lwn.net/Articles/561462/ >>> >>> The article title is "Device trees as ABI". A device tree is defined >>> in the "*.dts" file that is then compiled to a dtb blob, which >>> constitutes the ABI. And this ABI should be kept backwards compatible. >>> >>> What is discussed here is a documentation of bindings, i.e. according >>> to ePAPR: "requirements for how specific types and classes of devices >>> are represented in the device tree". >>> >>> >From the bindings documented in the >>> Documentation/devicetree/bindings/mfd/ti-lmu.txt only >>> ti,lm3532-backlight is used in the mainline dts file >>> (arch/arm/boot/dts/omap4-droid4-xt894.dts). >>> >>> Having the above it seems that there is no risk of breaking any >>> users. >> >> DTBs and bindings are supposed to be portable between operating >> systems. You are right there are no _mainline_ _Linux_ users. > > No mainline users means no users we should care of. > Other people also don't care - see patch [0]. > >>>> NAK on this patch. I see that this binding has problems, but >>>> introducing different binding for subset of devices is _not_ a fix. >>>> >>>>>> What about the multi function devices? They should have same binding. >>>>> >>>>> The MFD devices defined are not in contention here only the SFD. >>>> >>>> I'd like to see common solutions for SFD and MFD, as the hardware is >>>> similar, and that includes the code. Having code that is easier to >>>> maintain is important, and having many drivers are harder to maintain >>>> than one driver. >>>> >>>> Milo's code looks better than yours in that regard. I disagree about >>>> Milo's code being "nightmare" to modify, and care about "easy to >>>> maintain" more than "binary size". >>> >>> Easy to maintain will be a dedicated LED class driver. >> >> You mean, 3 dedicated LED class drivers and 3 MFD drivers with LED >> parts? We'll need complex driver anyway, and I'd really like to have >> just one. > > In the LED subsystem we can wrap common functionalities > into a library object. MFD driver will be able to reuse it then. I am currently working on that code now. I expect a RFC on this this week. Dan > > [0] > https://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap.git/commit/?h=droid4-pending-v4.19&id=d774c7e447ac911e73a1b3c775e6d89f0422218c > -- ------------------ Dan Murphy