From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752664AbcHABXn (ORCPT ); Sun, 31 Jul 2016 21:23:43 -0400 Received: from exsmtp03.microchip.com ([198.175.253.49]:9848 "EHLO email.microchip.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750805AbcHABXl (ORCPT ); Sun, 31 Jul 2016 21:23:41 -0400 Subject: Re: [PATCH v7 2/2] [media] atmel-isc: DT binding for Image Sensor Controller driver To: Rob Herring References: <1469778856-24253-1-git-send-email-songjun.wu@microchip.com> <1469778856-24253-3-git-send-email-songjun.wu@microchip.com> <20160729214454.GA21408@rob-hp-laptop> CC: , , , , , Mark Rutland , From: "Wu, Songjun" Organization: Microchip Message-ID: <5a2cea98-dd8a-159b-7adb-a2533cfde1b0@microchip.com> Date: Mon, 1 Aug 2016 09:23:11 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160729214454.GA21408@rob-hp-laptop> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/30/2016 05:44, Rob Herring wrote: > On Fri, Jul 29, 2016 at 03:54:08PM +0800, Songjun Wu wrote: >> DT binding documentation for ISC driver. >> >> Signed-off-by: Songjun Wu >> --- >> >> Changes in v7: None >> Changes in v6: >> - Add "iscck" and "gck" to clock-names. >> >> Changes in v5: >> - Add clock-output-names. >> >> Changes in v4: >> - Remove the isc clock nodes. >> >> Changes in v3: >> - Remove the 'atmel,sensor-preferred'. >> - Modify the isc clock node according to the Rob's remarks. >> >> Changes in v2: >> - Remove the unit address of the endpoint. >> - Add the unit address to the clock node. >> - Avoid using underscores in node names. >> - Drop the "0x" in the unit address of the i2c node. >> - Modify the description of 'atmel,sensor-preferred'. >> - Add the description for the ISC internal clock. >> >> .../devicetree/bindings/media/atmel-isc.txt | 65 ++++++++++++++++++++++ >> 1 file changed, 65 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/media/atmel-isc.txt > > Please add acks when posting new versions. > > Rob > Hi Rob, Thank you for your reminder. Should I Add 'Acked-by: Rob Herring ' behind 'Signed-off-by: Songjun Wu '? Should I resend this patch?