From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 186112857EF for ; Wed, 19 Nov 2025 15:34:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763566473; cv=none; b=XO3QNm5rE1/vBR4m9GX8YKZyPhYIe+r1u94f/VFV6Y27MjuIAYSk+aQ5entR6iGgZoEIZcCL/2jiXsuBzD4utNZZHXMQGaxvcO/1aE9+/DhKaSX2L/zXhPY/9nYdiZeOa4cv5RtXnCgtZRs8U4meQdXAaCUsoa+b4QGpAUz4jXI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763566473; c=relaxed/simple; bh=RhAcrmn1tmKkAIxPPmF7XAwKmtT4s9HzyWGuAtJshkM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HIsVelMLTfVot/KS7pjGYv7FI7mf08pWhNYg0/wQvkBhCXM6TpAcqsrej/AFE5OqmlsXgENnES2LtXcP3yV0zwBi/6eV13v9c6d+kvRvGEv5kjqb4Ew0RhCkc04pPpy1huTwOh3pBjmKyqxIC0zY8jWwT+powarenl5ACWmfCy0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gaJHCSsx; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YUJtgcsY; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gaJHCSsx"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YUJtgcsY" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AJBLqau536918 for ; Wed, 19 Nov 2025 15:34:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= n/aPrBEjfSdYjQxe0JQvsi2NRwCekFAkXeE0ICKQpWk=; b=gaJHCSsxmiTm/u52 LwYQdR/bF0tQ28cY8EhlzEWqOyBBqCIrvQKq+/o1zO8Vq5tL8RJ8z3TMR6HvL+zz SImeJfbvomzP0iGrquUDZWyc4oZzHqFTMVRzYIH2gCueNNl5yKOHUGwagUco7gVU is7r7IFxi66khlgw2vt7639iT2wdnXHLOsjXnuGk+JnjaTcgIWJ1hqQ9/O1W3E4K nWuJy/pQ1uEcyQPjSvkL6OwVeVu78YeMnu+2MaeTA5tJp7WALudOEQzx4tkjWAAT NJzITZJI2qeF1zQ4qPOIf24sMyogNnF/aLBff1HF76BudWhgoj4mABgdNbCiPA10 43VU9Q== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ah65t20we-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 19 Nov 2025 15:34:31 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4ee0c1c57bcso220010561cf.2 for ; Wed, 19 Nov 2025 07:34:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763566470; x=1764171270; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=n/aPrBEjfSdYjQxe0JQvsi2NRwCekFAkXeE0ICKQpWk=; b=YUJtgcsYs9+DVrXdYGUpyjqvIqM97bNTTxkV0TYtKFTRbkFToPFdz1NwKmhsPx7PBm WHTt03C7ckhesPP7H8UeoHo16iptkM/rGREBg+HPy7s7hOE3LVHPz4vIlYK/KxZzLfEq 3eirISNlcIlIkGguGAHDggmhPFfpxcNKa4EV4DL41lxqm7LyOQxPZM6DdEOmhuQNHJsR FAuxZjz+vn1gLkxBcf5OMq4OYBsPPCOzGgvms9navva56QRDMxSifVGJoussikaVvaSQ CQIo9DrZvFdLRfEwIum4VRMXpqr/1NIhohVkRkCl+WhBk8RfV1SA00VKHPZbDdQ03oP+ vCEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763566470; x=1764171270; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=n/aPrBEjfSdYjQxe0JQvsi2NRwCekFAkXeE0ICKQpWk=; b=K+cmDwUPVXvjqt7LyZ4LNimSsTH6WSZck0I0XQ7Z0s97KMZNh7j41S7K23eV3zx97r rkju3s5yPrbPu7uhoLH+wmgQgEudIHrleT6o6Q8YEhlFGDtQjB9cP0gyPDN9dmNEpfYs UmLkn9L3kk1Y8JTUt6kznhTcc07UOjeA9gstZblmP3vCU2P9o+G16ml7SF6MZxP61n4l 88F5R3X9n8JrIJ/Bsq3TT8RMOpLzIQRKqjBIQl3NlmUxTFPzPXHPJ3vk43Hjw2RCGc+c ZHTpwr3H1JVxCFLbPDW6RWuoBF1KASmt30Mkmbr7XsH86zIblWMjdn7+uA6S+tcwqRxE kYvA== X-Forwarded-Encrypted: i=1; AJvYcCWnj+iPP30KoSr7toMZSrE6O8464vKWqwp2AJX7pZwUrVE2V3MCQIFxNWwP+i2pCJuC2O/jtB5XGDeu5g4=@vger.kernel.org X-Gm-Message-State: AOJu0YzUTAFRcc/w8nEZmZwqfh8TBvLaD2OLBKgawDENIJzBlduFc3X9 +PDXPZyWdTiK17SlckHj35hxscBfkcpeiGej5h75TPRUqSNPypYUA25nR7dMkv6MdFK9Yax8GJh PWu+Q+6drOTMEl0ZOS0bDRCXogY/eZ/qB4Qrp3xS9Fru+Hh069ar4qmAur3FZNQa8nJ8= X-Gm-Gg: ASbGnct181Y+Pal/nKFNNq6A1vX6eeV6TUFxIO78my96sZAXiP+Ga/eu8TGbEJ72yGf PbPvDyU6Joq2Rr4AqVBopCQsWxwFE+oqVXGu9U+Ce9P6tODEA9c7r8i9HTqMoBKKHj2nk2NWweT EJ3zM5/ng/OcaxNbPO+4+idUecSfhVN6/Qs+iSc7CVn3CYHvmQH0xqT5vrbk29Ux1vGNWYHqkoG MyUQ+t8DxvtJ7CluLUJdsqwBvBAPM56CZyMtkHw+asY+u22GfyauWt1Ww16mnCcdSzlZgkTMLP/ mA1qJstfAbzbCPCZvrh0psrGq8cO7gwmMoDz41oNi635Ely7bvl9/+zUXEHZ2hbivu7TKFcVq0B xSKFZv1t/KbiFeF7UZ5ALwsNWwLYM7PB59NDZ X-Received: by 2002:ac8:5dc7:0:b0:4ed:717c:966 with SMTP id d75a77b69052e-4edf21130f0mr240444041cf.62.1763566468710; Wed, 19 Nov 2025 07:34:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IGC2wqmcwzxLXJ7w2hvm89zQu065T7cY1QTr/e/8TU9oCLUE8BxB+Rmll8TWk8CR3A0EBSxlw== X-Received: by 2002:ac8:5dc7:0:b0:4ed:717c:966 with SMTP id d75a77b69052e-4edf21130f0mr240443361cf.62.1763566467893; Wed, 19 Nov 2025 07:34:27 -0800 (PST) Received: from [192.168.68.121] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-477a9dfd643sm41623625e9.14.2025.11.19.07.34.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Nov 2025 07:34:27 -0800 (PST) Message-ID: <5a3001a9-d28a-4df2-b486-832e25b82236@oss.qualcomm.com> Date: Wed, 19 Nov 2025 15:34:25 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/9] ASoC: codecs: lpass-wsa-macro: remove main path event To: Jonathan Marek , linux-arm-msm@vger.kernel.org Cc: Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , "open list:QCOM AUDIO (ASoC) DRIVERS" , open list References: <20251117051523.16462-1-jonathan@marek.ca> <20251117051523.16462-6-jonathan@marek.ca> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: <20251117051523.16462-6-jonathan@marek.ca> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=avK/yCZV c=1 sm=1 tr=0 ts=691de387 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RAbU-raeAAAA:8 a=EUspDBNiAAAA:8 a=shMeLcMbd2GRUaFjQBgA:9 a=0bXxn9q0MV6snEgNplNhOjQmxlI=:19 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 a=JiizpSU_mAIq9zsZDqn2:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTE5MDEyNCBTYWx0ZWRfX1aBZXxoDpBur sxJxak68n9ED7beBU8kRmhX3Ac/VW7p6DZEIDRk+HHvxIcykTPxl43N+wTuDovjFVsp3Z/zBCYW BOwcYB7l4B4UdPyM0LhF5i/M+wLb1C44FBGIQ7pMxYpQMqRt4mE52KQ2jtQ04p2M0QLiG1Yln7F i5TgDtXaG7jAiUhgotawUy5ZPV9ml29VlJ1Gb0cQBxBdLTAoYd+jCm6laWr8NaLrV4UdLPHDqAs vg6o+PcYcl9DokvX2EiWipj0fInVdsLf6PJ4YDteYZSu/ieOfP5Yt78/6wnLD/oxmbj21gbLbZY ATuI0lYq0m/sdYE3j+XGj8/kfQf0QVDCqopI5Xxhwk8VPNodowRhFiwvSCMOYFfvjWlQo+LTiaj jZEJgfBIKJSCi8fM6w5TpFNKwpoWQg== X-Proofpoint-GUID: JsvgmB_ddG7EMRkggGiO3PifxR-pOwym X-Proofpoint-ORIG-GUID: JsvgmB_ddG7EMRkggGiO3PifxR-pOwym X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-19_04,2025-11-18_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 suspectscore=0 phishscore=0 priorityscore=1501 adultscore=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511190124 On 11/17/25 5:15 AM, Jonathan Marek wrote: > The event enables the main path clock when the mux is set to DEC0/DEC1. > My patch ("ASoC: codecs: lpass-wsa-macro: fix path clock dependencies") > makes it depend on the main path clock, so this event is now redundant. > > Signed-off-by: Jonathan Marek > --- Tested-by: Srinivas Kandagatla #on T14s Reviewed-by: Srinivas Kandagatla > sound/soc/codecs/lpass-wsa-macro.c | 59 +----------------------------- > 1 file changed, 2 insertions(+), 57 deletions(-) > > diff --git a/sound/soc/codecs/lpass-wsa-macro.c b/sound/soc/codecs/lpass-wsa-macro.c > index 2a814a5d2d1f0..e2e78ff6dd54e 100644 > --- a/sound/soc/codecs/lpass-wsa-macro.c > +++ b/sound/soc/codecs/lpass-wsa-macro.c > @@ -1726,59 +1726,6 @@ static int wsa_macro_config_softclip(struct snd_soc_component *component, > return 0; > } > > -static bool wsa_macro_adie_lb(struct snd_soc_component *component, > - int interp_idx) > -{ > - struct wsa_macro *wsa = snd_soc_component_get_drvdata(component); > - u16 int_mux_cfg0, int_mux_cfg1; > - u8 int_n_inp0, int_n_inp1, int_n_inp2; > - > - int_mux_cfg0 = CDC_WSA_RX_INP_MUX_RX_INT0_CFG0 + interp_idx * 8; > - int_mux_cfg1 = int_mux_cfg0 + 4; > - > - int_n_inp0 = snd_soc_component_read_field(component, int_mux_cfg0, > - wsa->reg_layout->rx_intx_1_mix_inp0_sel_mask); > - if (int_n_inp0 == INTn_1_INP_SEL_DEC0 || > - int_n_inp0 == INTn_1_INP_SEL_DEC1) > - return true; > - > - int_n_inp1 = snd_soc_component_read_field(component, int_mux_cfg0, > - wsa->reg_layout->rx_intx_1_mix_inp1_sel_mask); > - if (int_n_inp1 == INTn_1_INP_SEL_DEC0 || > - int_n_inp1 == INTn_1_INP_SEL_DEC1) > - return true; > - > - int_n_inp2 = snd_soc_component_read_field(component, int_mux_cfg1, > - wsa->reg_layout->rx_intx_1_mix_inp2_sel_mask); > - if (int_n_inp2 == INTn_1_INP_SEL_DEC0 || > - int_n_inp2 == INTn_1_INP_SEL_DEC1) > - return true; > - > - return false; > -} > - > -static int wsa_macro_enable_main_path(struct snd_soc_dapm_widget *w, > - struct snd_kcontrol *kcontrol, > - int event) > -{ > - struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm); > - u16 reg; > - > - reg = CDC_WSA_RX0_RX_PATH_CTL + WSA_MACRO_RX_PATH_OFFSET * w->shift; > - switch (event) { > - case SND_SOC_DAPM_PRE_PMU: > - if (wsa_macro_adie_lb(component, w->shift)) { > - snd_soc_component_update_bits(component, reg, > - CDC_WSA_RX_PATH_CLK_EN_MASK, > - CDC_WSA_RX_PATH_CLK_ENABLE); > - } > - break; > - default: > - break; > - } > - return 0; > -} > - > static int wsa_macro_interp_get_primary_reg(u16 reg, u16 *ind) > { > u16 prim_int_reg = 0; > @@ -2395,10 +2342,8 @@ static const struct snd_soc_dapm_widget wsa_macro_dapm_widgets[] = { > SND_SOC_DAPM_MIXER("WSA RX_MIX0", SND_SOC_NOPM, 0, 0, NULL, 0), > SND_SOC_DAPM_MIXER("WSA RX_MIX1", SND_SOC_NOPM, 0, 0, NULL, 0), > > - SND_SOC_DAPM_MIXER_E("WSA_RX INT0 MIX", SND_SOC_NOPM, 0, 0, NULL, 0, > - wsa_macro_enable_main_path, SND_SOC_DAPM_PRE_PMU), > - SND_SOC_DAPM_MIXER_E("WSA_RX INT1 MIX", SND_SOC_NOPM, 1, 0, NULL, 0, > - wsa_macro_enable_main_path, SND_SOC_DAPM_PRE_PMU), > + SND_SOC_DAPM_MIXER("WSA_RX INT0 MIX", SND_SOC_NOPM, 0, 0, NULL, 0), > + SND_SOC_DAPM_MIXER("WSA_RX INT1 MIX", SND_SOC_NOPM, 0, 0, NULL, 0), > > SND_SOC_DAPM_MIXER("WSA_RX INT0 SEC MIX", SND_SOC_NOPM, 0, 0, NULL, 0), > SND_SOC_DAPM_MIXER("WSA_RX INT1 SEC MIX", SND_SOC_NOPM, 0, 0, NULL, 0),