From: Krzysztof Kozlowski <krzk@kernel.org>
To: Zhangchao Zhang <ot_zhangchao.zhang@mediatek.com>,
Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Luiz Von Dentz <luiz.dentz@gmail.com>
Cc: Sean Wang <sean.wang@mediatek.com>,
Deren Wu <deren.Wu@mediatek.com>,
Aaron Hou <aaron.hou@mediatek.com>,
Chris Lu <chris.lu@mediatek.com>,
Steve Lee <steve.lee@mediatek.com>,
linux-bluetooth <linux-bluetooth@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-mediatek <linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH] Bluetooth: BT Driver: mediatek: add gpio pin to reset bt
Date: Wed, 28 May 2025 14:07:29 +0200 [thread overview]
Message-ID: <5a430a69-6182-4a34-b5df-5fd557411b68@kernel.org> (raw)
In-Reply-To: <20250528070323.14902-1-ot_zhangchao.zhang@mediatek.com>
On 28/05/2025 09:03, Zhangchao Zhang wrote:
> +
> +static int btmtk_reset_by_gpio(struct hci_dev *hdev)
> +{
> + struct btmtk_data *data = hci_get_priv(hdev);
> + struct btmtk_reset_gpio *reset_gpio_data;
> + struct device_node *node;
> + int reset_gpio_number;
> +
> + node = of_find_compatible_node(NULL, NULL, "mediatek,usb-bluetooth");
There is no such compatible. Just git grep for it.
> + if (node) {
> + reset_gpio_number = of_get_named_gpio(node, "reset-gpios", 0);
Where is the ABI documented? Anyway, you should not pick GPIOs from
random devices.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-05-28 12:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-28 7:03 Zhangchao Zhang
2025-05-28 7:46 ` Paul Menzel
2025-05-28 12:07 ` Krzysztof Kozlowski [this message]
2025-06-25 3:42 ` Chris Lu (陸稚泓)
2025-06-25 5:56 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a430a69-6182-4a34-b5df-5fd557411b68@kernel.org \
--to=krzk@kernel.org \
--cc=aaron.hou@mediatek.com \
--cc=chris.lu@mediatek.com \
--cc=deren.Wu@mediatek.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=ot_zhangchao.zhang@mediatek.com \
--cc=sean.wang@mediatek.com \
--cc=steve.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®