From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0BAAC433E7 for ; Sun, 11 Oct 2020 20:30:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B64EE20776 for ; Sun, 11 Oct 2020 20:30:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729177AbgJKU3m (ORCPT ); Sun, 11 Oct 2020 16:29:42 -0400 Received: from smtprelay0024.hostedemail.com ([216.40.44.24]:59420 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726507AbgJKU3l (ORCPT ); Sun, 11 Oct 2020 16:29:41 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay05.hostedemail.com (Postfix) with ESMTP id CB0C118029122; Sun, 11 Oct 2020 20:29:40 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: eyes15_0304359271f4 X-Filterd-Recvd-Size: 2106 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf05.hostedemail.com (Postfix) with ESMTPA; Sun, 11 Oct 2020 20:29:39 +0000 (UTC) Message-ID: <5a43a8eefcd9ab82a5e29beb7b33491df24a048a.camel@perches.com> Subject: Re: git grep/sed to standardize "/* SPDX-License-Identifier: " From: Joe Perches To: Linus Torvalds Cc: LKML , Jiri Kosina Date: Sun, 11 Oct 2020 13:29:38 -0700 In-Reply-To: References: <307a7581abe24135ac243c3080d4ab9e7c044cbf.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.4-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2020-10-11 at 11:47 -0700, Joe Perches wrote: > On Sun, 2020-10-11 at 11:42 -0700, Linus Torvalds wrote: > > On Tue, Oct 6, 2020 at 4:13 PM Joe Perches wrote: > > > Almost all source files in the kernel use a standardized SPDX header > > > at line 1 with a comment /* initiator and terminator */: > > > > > > /* SPDX-License-Identifier: */ > > > > > > $ git grep -PHn '^/\* SPDX-License-Identifier:.*\*/\s*$' | \ > > > wc -l > > > 17847 > > > > That grep pattern makes zero sense. > > > > Why would */ be special at all? It isn't. > > > > $ git grep SPDX-License-Identifier: | wc -l > > 52418 > > > > and a *LOT* of those are shell scripts and use "#", or are C sources > > and use "//" etc. > > > > So your "standardization" is completely pointless. Anybody who expects > > that pattern just doing something fundamentally wrong, because the > > pattern you want to standardize around is simply not valid. btw: The script would merely change these c90 comments to use the style mandated by/proposed in Documentation/process/license-rules.rst