From: Jolly Shah <jolly.shah@xilinx.com>
To: Michal Simek <michal.simek@xilinx.com>,
Jolly Shah <jolly.shah@xilinx.com>,
ard.biesheuvel@linaro.org, mingo@kernel.org,
gregkh@linuxfoundation.org, matt@codeblueprint.co.uk,
sudeep.holla@arm.com, hkallweit1@gmail.com,
keescook@chromium.org, dmitry.torokhov@gmail.com
Cc: rajanv@xilinx.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Tejas Patel <tejas.patel@xilinx.com>
Subject: Re: [PATCH 2/2] arch: arm64: xilinx: Make zynqmp_firmware driver optional
Date: Tue, 25 Feb 2020 16:12:13 -0800 [thread overview]
Message-ID: <5a48a2f1-e723-62b7-36b2-1cf847f7fc2e@xilinx.com> (raw)
In-Reply-To: <e17afc7e-c070-6134-29cb-9fa7b855bf96@xilinx.com>
Hi Michal,
> ------Original Message------
> From: Michal Simek <michal.simek@xilinx.com>
> Sent: Monday, February 24, 2020 2:43AM
> To: Jolly Shah <jolly.shah@xilinx.com>, Ard.biesheuvel@linaro.org
<ard.biesheuvel@linaro.org>, Mingo@kernel.org <mingo@kernel.org>, 'Greg
Kh' <gregkh@linuxfoundation.org>, Matt@codeblueprint.co.uk
<matt@codeblueprint.co.uk>, Sudeep.holla@arm.com <sudeep.holla@arm.com>,
Hkallweit1@gmail.com <hkallweit1@gmail.com>, Keescook@chromium.org
<keescook@chromium.org>, Dmitry.torokhov@gmail.com
<dmitry.torokhov@gmail.com>, Michal Simek <michal.simek@xilinx.com>
> Cc: Rajan Vaja <rajanv@xilinx.com>,
Linux-arm-kernel@lists.infradead.org
<linux-arm-kernel@lists.infradead.org>, Linux-kernel@vger.kernel.org
<linux-kernel@vger.kernel.org>, Tejas Patel <tejas.patel@xilinx.com>
> Subject: Re: [PATCH 2/2] arch: arm64: xilinx: Make zynqmp_firmware
driver optional
>
> On 09. 01. 20 20:06, Jolly Shah wrote:
>> From: Tejas Patel <tejas.patel@xilinx.com>
>>
>> Zynqmp firmware driver requires firmware to be present in system.
>> Zynqmp firmware driver will crash if firmware is not present in system.
>> For example single arch QEMU, may not have firmware, with such setup
>> Linux booting fails.
>
>
> I think that moving it to firmware Kconfig is good solution. What it is
> wrong is that description above where I agree with Sudeep.
> It means.
> 1. User should have option to disable zynqmp firmware driver which is
> what this patch allows. It means if someone decides to use different
> firmware mechanism it can do it directly by simply y/n option.
>
> 2. Autodetection of PMUFW presence is another feature which could be
> implemented to have this driver enabled but different mechanism can be
> used.
>
> 3. Doing this because of missing feature in QEMU is IMHO wrong. QEMU
> should be fixed and then you don't have any issue if this should be used
> or not.
>
> Just a summary. Remove that QEMU example from commit message and talk to
> Edgar to fix single QEMU solution to have that regs mapped all the time.
Pushed another patch as suggested. Will sync up with Edgar.
Thanks,
Jolly Shah
>
> Thanks,
> Michal
>
next prev parent reply other threads:[~2020-02-26 0:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 19:06 [PATCH 0/2] " Jolly Shah
2020-01-09 19:06 ` [PATCH 1/2] include: linux: firmware: Correct config dependency of zynqmp_eemi_ops Jolly Shah
2020-02-24 10:35 ` Michal Simek
2020-01-09 19:06 ` [PATCH 2/2] arch: arm64: xilinx: Make zynqmp_firmware driver optional Jolly Shah
2020-02-24 10:43 ` Michal Simek
2020-02-26 0:12 ` Jolly Shah [this message]
2020-01-10 11:54 ` [PATCH 0/2] " Sudeep Holla
2020-01-13 6:46 ` Rajan Vaja
2020-01-13 15:13 ` Sudeep Holla
2020-02-24 10:33 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a48a2f1-e723-62b7-36b2-1cf847f7fc2e@xilinx.com \
--to=jolly.shah@xilinx.com \
--cc=ard.biesheuvel@linaro.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hkallweit1@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=michal.simek@xilinx.com \
--cc=mingo@kernel.org \
--cc=rajanv@xilinx.com \
--cc=sudeep.holla@arm.com \
--cc=tejas.patel@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome