Re: [PATCH 1/4] dt-bindings: pinctrl: qcom-pmic-gpio: Add pm7550ba support

[Rohit Agarwal <quic_rohiagar@quicinc.com>]

On 7/6/2023 8:53 PM, Konrad Dybcio wrote:
> On 6.07.2023 17:11, Rohit Agarwal wrote:
>> On 7/6/2023 8:34 PM, Konrad Dybcio wrote:
>>> On 6.07.2023 16:45, Rohit Agarwal wrote:
>>>> On 7/6/2023 8:05 PM, Krzysztof Kozlowski wrote:
>>>>> On 06/07/2023 15:30, Rohit Agarwal wrote:
>>>>>> Add support for the pm7550ba GPIO support to the Qualcomm PMIC GPIO
>>>>>> binding.
>>>>>>
>>>>>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
>>>>>> ---
>>>>>>     Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml | 3 +++
>>>>> I doubt that all your patches here and other patchsets are v1. Otherwise
>>>>> how did you get my Acks and Rbs? Please use proper versioning and
>>>>> provide changelog.
>>>>>
>>>>> What changed here?
>>>> Actually this is part of the original bigger series [1] that as per Bjorn's suggestion need to be broken
>>>> down according to the subsystem/maintainer.
>>>> Since it got broken down into multiple smaller series, I didnt include the versioning.
>>> All of that information should be included in the cover letter, to
>>> limit confusion both for maintainers and patch workflow tools.
>>>
>>> Since these patches all come from a separate series, it would be
>>> good for you to version this one as v(BIG_SERIES_REVISION)+1 because
>>> they've already been on LKML at least once. That would especially hold
>>> true if this revision included any changes.
>> Understood. Will send all the smaller series again with v2 as version with changelog.
> v3, this was essentially a v2.
Okay.

Thanks,
Rohit.
>
> Konrad
>> Thanks,
>> Rohit.
>>> Konrad
>>>> [1] https://lore.kernel.org/all/9de424ca-271a-8ed2-5550-658a828c4ea5@quicinc.com/
>>>>
>>>>> Best regards,
>>>>> Krzysztof
>>>>>