mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
	Miri Korenblit <miriam.rachel.korenblit@intel.com>,
	Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] wifi: iwlwifi: mld: Fix build with CONFIG_PM disabled
Date: Tue, 01 Apr 2025 08:56:40 +0200	[thread overview]
Message-ID: <5a5147038b771980b87761a75be38e1d9d43d1fa.camel@sipsolutions.net> (raw)
In-Reply-To: <20250401032153.2896424-1-linux@roeck-us.net>

On Mon, 2025-03-31 at 20:21 -0700, Guenter Roeck wrote:
> If CONFIG_PM is disabled, the CONFIG_PM symbol is not defined.
> This results in
> 
> drivers/net/wireless/intel/iwlwifi/mld/iface.h:169:5: error:
> 	"CONFIG_PM_SLEEP" is not defined, evaluates to 0
> 
> because the conditional uses #if instead of #ifdef. Using #ifdef
> fixes the problem.
> 
> Fixes: d1e879ec600f9 ("wifi: iwlwifi: add iwlmld sub-driver")
> Cc: Miri Korenblit <miriam.rachel.korenblit@intel.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> Maybe this has already been addressed. If so, sorry, I did not find it.
> I did not see thos fixed in Arnd's patch addressing the other PM_SLEEP
> related issues in the driver.
> 

Hadn't, except internally I'd fixed it a while ago, and now Miri sent my
patch (same as yours) 20 minutes later ;-)

Thanks, I'll start getting things into the wireless tree soon.

johannes

      reply	other threads:[~2025-04-01  6:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-01  3:21 Guenter Roeck
2025-04-01  6:56 ` Johannes Berg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5a5147038b771980b87761a75be38e1d9d43d1fa.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=miriam.rachel.korenblit@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®