From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750778AbdAWJUC (ORCPT ); Mon, 23 Jan 2017 04:20:02 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:35270 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750703AbdAWJUA (ORCPT ); Mon, 23 Jan 2017 04:20:00 -0500 Subject: Re: [PATCH] KVM: s390: Move two error code assignments in kvm_vm_ioctl_get_dirty_log() To: Christian Borntraeger , SF Markus Elfring , kvm@vger.kernel.org, linux-s390@vger.kernel.org, Cornelia Huck , Heiko Carstens , Martin Schwidefsky , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= References: <70f41e59-d8a4-de42-6064-80ecf6acc065@users.sourceforge.net> <35411200-2bd6-1c65-7d7f-21a6353875ea@de.ibm.com> Cc: LKML , kernel-janitors@vger.kernel.org From: Paolo Bonzini Message-ID: <5a595e1d-d59d-9289-2e9b-5bffb6fc6b12@redhat.com> Date: Mon, 23 Jan 2017 10:19:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <35411200-2bd6-1c65-7d7f-21a6353875ea@de.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/01/2017 09:22, Christian Borntraeger wrote: > Patches that changes open coded things to common helpers or things like > kmalloc_array where appropriate or things that make the code more robust > are fine and welcome, but I am not going to take this as it just shuffles > things around. It does not fix anything and it does not improve the code, > but it certainly carries the risk of breaking something (yes in this case > it looks perfectly fine, though). Besides, r = -ESOMETHING; if (...) return r; is the way it's done everywhere else in KVM. Paolo