From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 915DFE573 for ; Wed, 10 Dec 2025 06:46:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765349198; cv=none; b=WX9Gn4YS1qSbh2S0XtN1A9xqBAMbe0tYmF1X8hPHBg78pwSw93o7Kk3neCD76sqjTFK2wHHiUU30KMSjOKrM8U9gdCoI/gXnnj4OnhZJAy4ZdSkzrVxB0rSWQzZThmTGswvnMriVR6W30iFfjcH8t8HVeEyITz7W5jwEsgBMOIk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765349198; c=relaxed/simple; bh=41S1yzf3bUyGSjHbAGyM7fTnwiYcCJyZgF27/5Ro+SQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=A0/Uoa16sopnb7RRthtIgMc4KuiHtwvqbY4tfwiJIox0OhXGD1LxZ7nU+LCvNeQRQCvidLmhi963GzZ6Dir/M+aIvarwHK/SLfCHQQpxfP5z5opWp7oIDfrDsiMJZxdf7O37jw87iKmgz2s1dogoKRf/1ad7lqT6squ2QHB4ZiM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=j66zKzMb; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=f36iSYZq; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="j66zKzMb"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="f36iSYZq" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BA6Dc6x1598096 for ; Wed, 10 Dec 2025 06:46:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= +iRPms9B7iFzeDhFGJSewFfbFC3pyljCFjAM3tAMS7k=; b=j66zKzMbNlzNvZlb oQpMD+EDgFVwMGbouhZyQn+w2HgnbjCtaPG1lJY6+x4rEbRLSFZJUCMMrq/QS7Rx Eo+Xl2Gd4ylXW1GosPNvr2tQqE7aUkYE9Q+zuvs9bEFOWagX9nxEPiyC5Ngo2M6U wa9MOid5WSyRBjomTfP0yEDpdZeeJQB+yDQSzORQU8npP56QsLKFMz0LtAi7g7hI abQqpwpuVjg8znPQR4a21WcLyoycG3rBUz004keGCJyUyBVcBjvPrWsfQ8lgE90p DuziKmcomO993QojIEf8iwuoTA4SkNH0JUEXvfhHBcESQ73MK7WD+XrcEsWP5Efv 7l3jKQ== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ay1xp0aru-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 10 Dec 2025 06:46:35 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-b6ce1b57b9cso7656311a12.1 for ; Tue, 09 Dec 2025 22:46:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765349195; x=1765953995; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+iRPms9B7iFzeDhFGJSewFfbFC3pyljCFjAM3tAMS7k=; b=f36iSYZqgM1xdA/dI0zthkxjWdmLPyA3ydC3eo3LUGtt+JNqt3HDYq3VZDpvrQJy9G nrPeP1lfTMBghAniRdJ0ngWIDYy6JdC4s/RHEC1AjqO/duBw2Tn4KDLEwX7Tcj+6uBKa u0YZE0suFfH6RdOpvHlFtexO9EO2yKo1CCJpdZZh30xtF0bc1t865ALtyNFJkg20nHHc bq1i1lFwNvujdW84PsIGXvJMLqxVjyYZMvSwnpa6nXpXKO93iV7lNFDR9o6rtWbJErk7 dOTUDxpO2B6DXOJM0yO6CniNi6iGPTqegqme7St2Mwl2LKAQ2buF74AqOHHDg16wgoTI FzdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765349195; x=1765953995; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+iRPms9B7iFzeDhFGJSewFfbFC3pyljCFjAM3tAMS7k=; b=gaHPQQwcOpiT5wDM9zz8YqRdNx5LuzR3LSlLRV7RZZrW/8ev6agQ0RmluncHZNIdIU bApWiNVOQb0IKdScGLMJ59hVLX7jyaDdeDJFXMnOj7+RghEPG6yYbbYkD5a3mmcXI2PL iNsR+rzvyfEic8f2Y0aRXI2/K9Lc8rrZkPplNJnuS5wLpfgxja+SmZUoS4B9hd2EWl8J FmYAoLVIe34L92iwp27bwv3gsDB3iTdZQaumeQHjcijVDdTvZM1UOF2aGHdzfhmY1oyw 2mptQbZMHjzrRBTdUgLK7gOTEAD9FkQBID+b8UYPQSowncIFtVbAMSc1Vz7aZ9u0HCbv 9KIw== X-Forwarded-Encrypted: i=1; AJvYcCUuIyf/+LYAIZcGEP/lFV0UuwaIFuv6ddn/UZMF1YXO+UOKRNyCKHzo3Pf8AsgpiRMPeU2xqGL5lOciD18=@vger.kernel.org X-Gm-Message-State: AOJu0Yzrn2lYfcbjzGxqCxuguRB45YOtEU7RD2o5p4dU0tBS9YyEbh8+ BGI+79X/2eTJdFakVBZjvjOpbPSCUJS2LXixcajhbGAbqLe82thNoSwpHmEYSWNXwg7sct1GZ0B I+zxZtF+H2TSX5NQ39vbgcQyS2zvpwEeU5fKNHS//SJxxd8BFym4SIRg5TzM4oFlZ7dI= X-Gm-Gg: ASbGncuFm0fYWzBzpNNW8zC2yF9RRxwLjN2ZEqbCMARoCXmeNzeUnsPOm0AicdWsmI2 oYWTbAeI98iIr3mGCUfOoPVLyxmR/bg7FB5SA48I9Hw19V2M71KifouXzOFD3SAxBjwNLTivNd8 8yi8U1OtpUd3ZyEwzS0H2vOH2L/7Splpe+YKK701HsAcerGQhVZ+jGikuhc6/2+kMugA7hs740e meam2yITk8058Yfxwvr67BgcYlxr9D9BoTWZ2WfzhG/4MsLkShAF3TvWeWS1C2sA1RqPlgbp4fn yMufzvS8TpVWYFgcvKCMGjG/KNHJNjT+g3a9joyrHhOvmSuQt3oNHAsHoWVFlgRg1XUOvgJzX9o mAJ2ERL/SpiEP6tYrGMuy1q+BRDOh6zKieqKlf2O6xO+J0+kcgkM4U+6TOJf9/vk8Xrp0N9bQo7 Bscri/19M= X-Received: by 2002:a05:6a20:7290:b0:35d:be42:92de with SMTP id adf61e73a8af0-366e170cc7amr1362806637.21.1765349195239; Tue, 09 Dec 2025 22:46:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IE65f7VgpKX1toP+VOD+uRyYC2xSY370jW2fBx9NgXa+YET7tXhNnG6VxOvmHuqpf5eJGCdvA== X-Received: by 2002:a05:6a20:7290:b0:35d:be42:92de with SMTP id adf61e73a8af0-366e170cc7amr1362784637.21.1765349194821; Tue, 09 Dec 2025 22:46:34 -0800 (PST) Received: from [10.133.33.160] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-bfa0ad20207sm14737009a12.11.2025.12.09.22.46.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Dec 2025 22:46:34 -0800 (PST) Message-ID: <5a5b4961-904c-45e6-aca6-b58a122e2134@oss.qualcomm.com> Date: Wed, 10 Dec 2025 14:46:31 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] wifi: ath11k: move .max_tx_ring to struct ath11k_hw_hal_params To: Alexandru Gagniuc , ath11k@lists.infradead.org, Jeff Johnson Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251210024036.3965135-1-mr.nuke.me@gmail.com> From: Baochen Qiang Content-Language: en-US In-Reply-To: <20251210024036.3965135-1-mr.nuke.me@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjEwMDA1NyBTYWx0ZWRfXy4rEvNwlKAyq wV0aixnDzcB+Qcz5CR1VCbX4HI8jdX0KAg8w2RtAqjmwXR+F7oqp4hRUe6WBtPerq2hz8Pc0T35 dDLiW9Ko8itt36OWKSXYFpdkrHlJ6fiMsbhXin2qrlAMzMBl/wtlidOD1g7XyUe6EThJt1ATCxi wKyS+6sNpja16dgBv//X2YCND7s/dMQukILUnkwjS/B5cJJ9XibyKkQhaWL4TZqUO7OH+cGlTTp FvrigC3ZgUWgo8/hMrcdh8Wm520kPFgQus7M9MUW3yWKUIZ3TFFn9UEGgyptj+YeeJSKWPSSCHA jgubjl41a16a9UAZrv3rcTsdJZdKIz/C3w4I3TfEiILqqhePNVDXwsExZGhOkdEbSnysHC9AJSo ukiCJzpJXtbAYJQs57YLp8tpTZROTw== X-Proofpoint-ORIG-GUID: eBNqVcHHzkbW55c_DjFWJ5TPfL-S6uWp X-Proofpoint-GUID: eBNqVcHHzkbW55c_DjFWJ5TPfL-S6uWp X-Authority-Analysis: v=2.4 cv=A/Zh/qWG c=1 sm=1 tr=0 ts=6939174b cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=UC6oHK_YC1xWRw2yuZ8A:9 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-09_05,2025-12-09_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 adultscore=0 spamscore=0 malwarescore=0 bulkscore=0 lowpriorityscore=0 phishscore=0 suspectscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512100057 On 12/10/2025 10:40 AM, Alexandru Gagniuc wrote: > ".max_tx_ring" is an upper bounds to indexing ".tcl2wbm_rbm_map". It > is initialized in, core.c, a different file than the array init. This > spaghetti-like relation is fragile and not obvious. Accidentally > setting ".max_tx_ring" too high leads to a hard to track out-of- > bounds access and memory corruption. > > Clarify this dependency by moving ".max_tx_ring" adjacent to the array > ".tcl2wbm_rbm_map". Use ARRAY_SIZE() instead of #defines to initialize > the length field. Remove DP_TCL_NUM_RING_MAX_QCA6390, as it is no > longer required. > > The intent is to make the code easier to understand rather than fix > an existing bug. > Even the code chane works, I am not sure whether we should do this. Because, logically max_tx_ring represents hardware capability which is static. However the change actually implies max_tx_ring varies on tcl2wbm_rbm_map definition. If we are going to add something to avoid the potential out-of-bound access or to improve code readability, how about something like ASSERT(hw_params.max_tx_ring <= ARRAR_SIZE(tcl2wbm_rbm_map))