From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E9753A2E33 for ; Wed, 10 Jun 2026 08:22:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781079724; cv=none; b=TuQ5EZ7ISH8Z3Jx0GMbQ0tHkv9WbfHi8p+bcoUVqs5+qq808s9u0kiYrCiUXQ4n1VBJ2KfiHstVC9/rhvnQoFn8CbQg5jYzkPFJpQmil5UQhltUPre57ANIouzetOinWmxg3+LAP+wajQRS98CCRl3hdmxhLF3W+qrwFYC+Brdk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781079724; c=relaxed/simple; bh=nE8gNuplIhw6p4dYDUNxSa5zUE0zr4R5hqpSrc/T3vQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HmZpeYsTb0DkVIqr1VEadl69Oa/nYP5n+gYdrXzgtfvdg61Gg7p/k8yDTaytUAaJ9Kdcg6XZGLmurxKaFMrwKdgOvQGRCrPAifgD+3PoRIrPKQuxwqWK074E1WDhfrDeg1qSxpy7aqJrSWf9D7eaaqagNMF9089eTyp2oJjpysM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=VgIleMGE; arc=none smtp.client-ip=209.85.208.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VgIleMGE" Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-3967720c093so5312991fa.1 for ; Wed, 10 Jun 2026 01:22:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1781079721; x=1781684521; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=0ujN0Hk27ShmSn5usfdP+E/0ZsnXl4co2IQGGfBFpB8=; b=VgIleMGExBkSnjjOc4t/4oVkLqb/wW3BDN5gIuV0n2IIkmcqVs7bs/K2pgOMleaNJg u45VT7CMx65c7dLyf9a+tV6DOAs+zCehwZLk10kvE6gFedHTrHjez3IzToivnbzWF8Cx JzywrjkAkjLo3bLgXtfEOxQfpdDb7NrYyc/ojjSFqKv+y3XAL1Lcil51ayZ6935mnYv8 5+cdCICEdaSuUjHh/fY2319gL3ApNFFTM0w4KNS3U5Wn+E8UGKMBurtjgsxrgS6hUJQj BEFxvDFrnqS/u6IY6E93HpqrHDiqOsAWHhD42FSIdVvRPS3/EpkCArXN/q+u3Q1WcD61 pEHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781079721; x=1781684521; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=0ujN0Hk27ShmSn5usfdP+E/0ZsnXl4co2IQGGfBFpB8=; b=fKrvIBea5ca2Jz42MMEvzE9NzGebrzrJfY7UegHgwP/3hbfLFhjPdVuEzRWF1Qjs7Y mGfQRGBwcTnazBlf+looGrt9/C+BXU9/57mFfYX+70hBqfv1d4lgc1YDZZtVGv3kORDn jkdl8ZyAyiHipXQmtPHKA1gFmaObF2vYRJdJfjDuaXegVu4EMS6bl1jxJoexBO9M4clO RpqoB3DhmYy94o3ctvgZtUDn7WOMtWzyyMgTkBQ7LI5nbybIMow48iWx2iZ7SMSGFjPD /0Qsc6PgObyvfsSEjKkVNEKBNCLZk3XzeokucLVYDrBeWmacTK+s5NPFLKE5f9eMTL6m HRrQ== X-Forwarded-Encrypted: i=1; AFNElJ84G+5OoDOYP6t4VGIXdXOBoheAVzqu8yfJ0ceA9d7HzsoJZ4vE2SIwAhj2/U2Xeapn3d29tSc5Zx9RZBA=@vger.kernel.org X-Gm-Message-State: AOJu0YyJs2kldW8hzZqoPc/ttZGiMw+YWP9O8Qghfm6ZoclzDW6x86Yy XptMuW6daE/VauvmbKHB2UiO3ZhMtnwJymwN8oNEwZpOZYlhOYrThThGLZYonDXvmgg= X-Gm-Gg: Acq92OHq5LI/tAEyA6VtehIhNa88RXx5+gvGO9oBQdvyei/14aSxAF2/G6lUkFyJw4k WRCCUwi0NY25ugTQWAwkptayltLGhoiqdQQeqRP3ot5iOSjcglvaGFsp1nXLAsLWhK6qmsLcHNL ZCUbM7olvy8awOLoXsyKo/RV6e6+DzChXBpwYEzEoFjF7hxhId1S6/OjgAC69FMmBkCG29Emosh F22wYDtcHlNGIAbWhTdzo1Dn+L18u3gkNSFHwbNwkoZ2f+9RgDzKNuRXeePICN+3P/245bWWAoO E32cr0OQDZXV4OUC2WrCbAU3/y1UAGfRST67ci+JBVN2Mj8E55rN5ni4F4rtFTXpiyJQU1c2HYw 6p2QXpAty2HdT56jpMX6cBO4pv4FN63wxxIpyAeb4jLQNl9U/aWIOL/F80ir4+eRXHMRy4GO9aF Zwl+Wos8vebrRK0dg4RY9GKbvtUkkxWr0rc/Fcp43LuQFAOoxSk1tw5sHDqvGcBSeXF7LjHC9Hp swsDCtgdeT1hRS+ X-Received: by 2002:a05:651c:1a2c:b0:396:7eba:a8 with SMTP id 38308e7fff4ca-397f78270bbmr7911561fa.8.1781079721231; Wed, 10 Jun 2026 01:22:01 -0700 (PDT) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-396ac2be04esm63290161fa.25.2026.06.10.01.22.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Jun 2026 01:22:00 -0700 (PDT) Message-ID: <5a5cbf8f-07ef-419a-8d30-c1b0b2786312@linaro.org> Date: Wed, 10 Jun 2026 11:21:53 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] arm64: dts: qcom: sm8550: add SDHC4 controller node To: William Bright Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Ram Boukobza , Tendai Makumire References: <20260427-sm8550-sdhc4-support-v2-1-a4241f43ecd5@imd-tec.com> From: Vladimir Zapolskiy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/9/26 19:21, William Bright wrote: > On Thu, Jun 04, 2026 at 07:01:22PM +0300, Vladimir Zapolskiy wrote: >> >> How do you know that these modes are broken in hardware and not >> caused by something else? >> >> It was stated before, but it was proven to be invalid as the statement. >> > Thanks Vladimir for your feedback. > > I copied this statement from when these modes were also masked out on > sdhc_2. I see that there was progress since then and the caps mask has > been dropped so I agree that I shouldn't have this comment that these > modes are broken due to hardware. Well, it might be broken due to hardware, but not necessarily due to Qualcomm SoC IP, there is a chance of a PCB design flaw. > > I have tested this patch after rebasing onto the latest tree with the > recent changes that allowed for the caps mask to be dropped for sdhc_2 > and I still see dll tuning failing. To progress, I need some guidance > from qcom as to what dll-config value should be used as I am uncertain > about this. I noticed that ftbl_gcc_sdcc4_apps_clk_src only goes up to > 75MHz so perhaps this needs modifying for DLL-tuning to pass and maybe > there needs to be schematic/routing guidance that needs to be strictly > followed as-well besides the usual 50 ohm impedance rules? >>> - Forbid SDR104/SDR50 via sdhci-caps-mask, matching the previously >>> existing sdhc_2 workaround in the same file. >>> The SDHCI capabilities register on this SoC advertises SDR50/SDR104 >>> modes that are broken on sdhc_4; without masking them the MMC >>> core selects SDR50 and fails DLL tuning with >>> -ETIMEDOUT during SDIO card initialisation. >> >> Which one SDIO card do you test? >> > My apologies, I made a mistake in the cover letter, I wasn't testing with > an SDIO card, I was testing with an NXP IW416 which is hard-wired to > sdhc_4. FWIW due to https://www.nxp.com/docs/en/data-sheet/IW416.pdf "10.7.1 VIO_SD DC characteristics" SDR104 speed mode is not supported by the module, thus the selection of the SDR50 speed mode on the host side sounds to be correct in your case. In SDR50 speed mode gcc_sdcc4_apps_clk clock frequency should be exactly 100MHz, and since it differs, it has an impact during the tuning phase. Definitely clk/qcom/gcc-sm8550.c says that the maximum supported frequency is 75MHz, the same is found in the downstream v5.15 kernel: static const struct freq_tbl ftbl_gcc_sdcc4_apps_clk_src[] = { F(400000, P_BI_TCXO, 12, 1, 4), F(25000000, P_GCC_GPLL0_OUT_EVEN, 12, 0, 0), F(37500000, P_GCC_GPLL0_OUT_EVEN, 8, 0, 0), F(75000000, P_GCC_GPLL0_OUT_EVEN, 4, 0, 0), { } }; Can you dump CAPS1 register value of SM8550 SDHC4? What does it say about SDR50 mode support and need for SDR50 mode tuning? -- Best wishes, Vladimir