Re: [PATCH] wifi: iwlwifi: mvm: fix power save for MLD

["Greenman, Gregory" <gregory.greenman@intel.com>]

Hi,

On Mon, 2023-08-21 at 21:07 -0700, Sultan Alsawaf wrote:
> From: Sultan Alsawaf <sultan@kerneltoast.com>
> 
> The conversion from bss_info_changed() to vif_cfg/link_info_changed()
> removed a call to iwl_mvm_bss_info_changed_station_common() from what
> became the vif_cfg_changed() path. As a result, BSS_CHANGED_PS and other
> power save changes sent via ieee80211_vif_cfg_change_notify() are ignored
> for MLD, which breaks power save entirely. This has a noticeable impact on
> power consumption, causing idle package power to hover at 10 W on my
> i9-13980HX laptop with an AX210 while connected to WiFi.
> 
> Add the missing iwl_mvm_bss_info_changed_station_common() call to the
> vif_cfg_changed() path to fix power save for MLD. This brings idle package
> power down to 1 W on my laptop, a 9 W improvement.
> 
> Fixes: 22c588343529 ("wifi: iwlwifi: mvm: replace bss_info_changed() with vif_cfg/link_info_changed()")
> Signed-off-by: Sultan Alsawaf <sultan@kerneltoast.com>
> ---
>  drivers/net/wireless/intel/iwlwifi/mvm/mld-mac80211.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mld-mac80211.c b/drivers/net/wireless/intel/iwlwifi/mvm/mld-mac80211.c
> index 8b6c641772ee..6abc05976870 100644
> --- a/drivers/net/wireless/intel/iwlwifi/mvm/mld-mac80211.c
> +++ b/drivers/net/wireless/intel/iwlwifi/mvm/mld-mac80211.c
> @@ -731,6 +731,8 @@ static void iwl_mvm_mld_vif_cfg_changed_station(struct iwl_mvm *mvm,
>  
>         mvmvif->associated = vif->cfg.assoc;
>  
> +       iwl_mvm_bss_info_changed_station_common(mvm, vif, &vif->bss_conf,
> +                                               changes);
>         if (!(changes & BSS_CHANGED_ASSOC))
>                 return;
>  

I agree that it looks like the call to iwl_mvm_bss_info_changed_station_common() is missing here, but
I think if is is added here then the call to iwl_mvm_power_update_mac() at the end of this function
is not needed anymore?