From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 259D712D210 for ; Tue, 9 Jul 2024 10:25:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720520756; cv=none; b=F4Y7gHbAZfECoU1n3obwONnadYK+5JsiP5z2Xqx3Z6meABAGVv+TiEJHdmT28P+65T4Bx+alxNTIrt+MJ1G9dNhDXca4eCNDPzSmWQ85S1bJEJ51ANZil/oipXEMROXJXzlsDBQw4Hrt5aoxzd1eVQc4W76n8XfrCMrLAA/fmL0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720520756; c=relaxed/simple; bh=A6pd2XpYR/VxdLWZQRqvnoyExu02xN7pHANL4n43oi0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GMH8rztVyXaL0B7p74k8mpAqgAQm7cMhgTFDYfz9t2lS0CB3ffaZYAPgs71W8FRhcWVogDjjz19BYQN0mDdyfO0T9/TmApNtNsWDKksycK9FMqbJ5RApEtsL1dLPRH5awJC1XiQrN47OHhUZc8uBoQMasaUA0IiU1W7FOpuerW8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=FPZKfoqv; arc=none smtp.client-ip=209.85.208.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="FPZKfoqv" Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-58c947a6692so6124952a12.0 for ; Tue, 09 Jul 2024 03:25:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720520753; x=1721125553; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=GdyTrVsoTN9O7NSdA88oWiFu9OfV95HskzoQpLb15Z4=; b=FPZKfoqvw+z3hsAHPVpMY4VwmvToOOJYXIC1/MEcVe9/JGLj/773nOQglrVoeQA/h8 hpDftKB5UsHhyzbG8nrlVRQvYI5VWzWpdSHcJoHZH4DJoOPVzeVVJL67TL0o2RptYAQg Llard+NtcAPX5JVgltXP4EfMRwZQLaFq92leuInRlthtfwDb0Db49/klF5tFhSiezpGy 14CtezL5vta2qJRD78J9NxuyrMgONWbJGcwnHTxBkQyd8BUyGqc2YqmTRliQRSWu3kZM JKzZ7qXfW8G5NIwsPmLqJyepsLNRzZO+mxUoS2Uc6eRo3Da/y5HjkIdvfLBe66fLqlGP CXwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720520753; x=1721125553; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GdyTrVsoTN9O7NSdA88oWiFu9OfV95HskzoQpLb15Z4=; b=nVQj5OCYpbQ+Yzg2q2ZfLzXDWTDnbpymMPDdH6IaMUbrw7ZgnEbdyx91hTsC6ynd7l H+GcHQsaQwSvagGvxpKKGXxhNYrbtJ6bEi053FuSm8JYeHaqQJMfawC4e8SdO1F4tdIw f2hNyVpvSMf9XDR6O+E6S/fdPVkuWxTBtVuO4gzp+dHLL6Wa77rjowIVv7kRjn2rzl/c wIUJiyZ8V9gzx+k4ztZ1lGQPoTFigw9hzcUQpP49RBFjVNtuyBBlpv0hP8LRl+rwS9UH y1DPI08AGY58YE13hBxVREOweVtWrs1Ivs6jmHcsZ473W4I8X6jAFW29awmhdBvXJ5Ic UW2Q== X-Forwarded-Encrypted: i=1; AJvYcCVKBSl2EjbBGu2LLb9nfPXR+3WwaDwtIQ4kPHAnpqMsvK0MdrZ2hgt4YLtqySWFkXQATo1j+aeiFBY6N2oan2HDYIBwZB65vD0SS7+n X-Gm-Message-State: AOJu0YxyXotOkxP5csKorU4KRtsIAw4ZwD5RHwuF98suxywmxJNE8Ejt sVB41HigzqIYpZYXZtz0AUVkoPfXMP5MdUH0QYaZIhj7HLKXG39265vbtg5aR3E= X-Google-Smtp-Source: AGHT+IFuotZgYfU6wVxhSbZdkYxhEmD3ZRvEboyJqHtucWZwusYkQ9GJldTmncLxCN3+0FO4rv+qFg== X-Received: by 2002:aa7:c918:0:b0:58a:ffc3:cea5 with SMTP id 4fb4d7f45d1cf-594bbe2ba54mr1263864a12.35.1720520753419; Tue, 09 Jul 2024 03:25:53 -0700 (PDT) Received: from [192.168.105.194] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-594bda308efsm883514a12.81.2024.07.09.03.25.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jul 2024 03:25:53 -0700 (PDT) Message-ID: <5a622896-6ce3-4e73-9383-15793b2536bc@linaro.org> Date: Tue, 9 Jul 2024 12:25:50 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/5] drm/msm/adreno: Implement SMEM-based speed bin To: Akhil P Oommen Cc: Rob Clark , Sean Paul , Abhinav Kumar , Dmitry Baryshkov , David Airlie , Daniel Vetter , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Marijn Suijten , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20240625-topic-smem_speedbin-v4-0-f6f8493ab814@linaro.org> <20240625-topic-smem_speedbin-v4-1-f6f8493ab814@linaro.org> <20240630102524.talnb3qx5jfmcj5y@hu-akhilpo-hyd.qualcomm.com> Content-Language: en-US From: Konrad Dybcio Autocrypt: addr=konrad.dybcio@linaro.org; keydata= xsFNBF9ALYUBEADWAhxdTBWrwAgDQQzc1O/bJ5O7b6cXYxwbBd9xKP7MICh5YA0DcCjJSOum BB/OmIWU6X+LZW6P88ZmHe+KeyABLMP5s1tJNK1j4ntT7mECcWZDzafPWF4F6m4WJOG27kTJ HGWdmtO+RvadOVi6CoUDqALsmfS3MUG5Pj2Ne9+0jRg4hEnB92AyF9rW2G3qisFcwPgvatt7 TXD5E38mLyOPOUyXNj9XpDbt1hNwKQfiidmPh5e7VNAWRnW1iCMMoKqzM1Anzq7e5Afyeifz zRcQPLaqrPjnKqZGL2BKQSZDh6NkI5ZLRhhHQf61fkWcUpTp1oDC6jWVfT7hwRVIQLrrNj9G MpPzrlN4YuAqKeIer1FMt8cq64ifgTzxHzXsMcUdclzq2LTk2RXaPl6Jg/IXWqUClJHbamSk t1bfif3SnmhA6TiNvEpDKPiT3IDs42THU6ygslrBxyROQPWLI9IL1y8S6RtEh8H+NZQWZNzm UQ3imZirlPjxZtvz1BtnnBWS06e7x/UEAguj7VHCuymVgpl2Za17d1jj81YN5Rp5L9GXxkV1 aUEwONM3eCI3qcYm5JNc5X+JthZOWsbIPSC1Rhxz3JmWIwP1udr5E3oNRe9u2LIEq+wH/toH kpPDhTeMkvt4KfE5m5ercid9+ZXAqoaYLUL4HCEw+HW0DXcKDwARAQABzShLb25yYWQgRHli Y2lvIDxrb25yYWQuZHliY2lvQGxpbmFyby5vcmc+wsGOBBMBCAA4FiEEU24if9oCL2zdAAQV R4cBcg5dfFgFAmQ5bqwCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQR4cBcg5dfFjO BQ//YQV6fkbqQCceYebGg6TiisWCy8LG77zV7DB0VMIWJv7Km7Sz0QQrHQVzhEr3trNenZrf yy+o2tQOF2biICzbLM8oyQPY8B///KJTWI2khoB8IJSJq3kNG68NjPg2vkP6CMltC/X3ohAo xL2UgwN5vj74QnlNneOjc0vGbtA7zURNhTz5P/YuTudCqcAbxJkbqZM4WymjQhe0XgwHLkiH 5LHSZ31MRKp/+4Kqs4DTXMctc7vFhtUdmatAExDKw8oEz5NbskKbW+qHjW1XUcUIrxRr667V GWH6MkVceT9ZBrtLoSzMLYaQXvi3sSAup0qiJiBYszc/VOu3RbIpNLRcXN3KYuxdQAptacTE mA+5+4Y4DfC3rUSun+hWLDeac9z9jjHm5rE998OqZnOU9aztbd6zQG5VL6EKgsVXAZD4D3RP x1NaAjdA3MD06eyvbOWiA5NSzIcC8UIQvgx09xm7dThCuQYJR4Yxjd+9JPJHI6apzNZpDGvQ BBZzvwxV6L1CojUEpnilmMG1ZOTstktWpNzw3G2Gis0XihDUef0MWVsQYJAl0wfiv/0By+XK mm2zRR+l/dnzxnlbgJ5pO0imC2w0TVxLkAp0eo0LHw619finad2u6UPQAkZ4oj++iIGrJkt5 Lkn2XgB+IW8ESflz6nDY3b5KQRF8Z6XLP0+IEdLOOARkOW7yEgorBgEEAZdVAQUBAQdAwmUx xrbSCx2ksDxz7rFFGX1KmTkdRtcgC6F3NfuNYkYDAQgHwsF2BBgBCAAgFiEEU24if9oCL2zd AAQVR4cBcg5dfFgFAmQ5bvICGwwACgkQR4cBcg5dfFju1Q//Xta1ShwL0MLSC1KL1lXGXeRM 8arzfyiB5wJ9tb9U/nZvhhdfilEDLe0jKJY0RJErbdRHsalwQCrtq/1ewQpMpsRxXzAjgfRN jc4tgxRWmI+aVTzSRpywNahzZBT695hMz81cVZJoZzaV0KaMTlSnBkrviPz1nIGHYCHJxF9r cIu0GSIyUjZ/7xslxdvjpLth16H27JCWDzDqIQMtg61063gNyEyWgt1qRSaK14JIH/DoYRfn jfFQSC8bffFjat7BQGFz4ZpRavkMUFuDirn5Tf28oc5ebe2cIHp4/kajTx/7JOxWZ80U70mA cBgEeYSrYYnX+UJsSxpzLc/0sT1eRJDEhI4XIQM4ClIzpsCIN5HnVF76UQXh3a9zpwh3dk8i bhN/URmCOTH+LHNJYN/MxY8wuukq877DWB7k86pBs5IDLAXmW8v3gIDWyIcgYqb2v8QO2Mqx YMqL7UZxVLul4/JbllsQB8F/fNI8AfttmAQL9cwo6C8yDTXKdho920W4WUR9k8NT/OBqWSyk bGqMHex48FVZhexNPYOd58EY9/7mL5u0sJmo+jTeb4JBgIbFPJCFyng4HwbniWgQJZ1WqaUC nas9J77uICis2WH7N8Bs9jy0wQYezNzqS+FxoNXmDQg2jetX8en4bO2Di7Pmx0jXA4TOb9TM izWDgYvmBE8= In-Reply-To: <20240630102524.talnb3qx5jfmcj5y@hu-akhilpo-hyd.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 30.06.2024 12:25 PM, Akhil P Oommen wrote: > On Tue, Jun 25, 2024 at 08:28:06PM +0200, Konrad Dybcio wrote: >> On recent (SM8550+) Snapdragon platforms, the GPU speed bin data is >> abstracted through SMEM, instead of being directly available in a fuse. >> >> Add support for SMEM-based speed binning, which includes getting >> "feature code" and "product code" from said source and parsing them >> to form something that lets us match OPPs against. >> >> Due to the product code being ignored in the context of Adreno on >> production parts (as of SM8650), hardcode it to SOCINFO_PC_UNKNOWN. >> >> Signed-off-by: Konrad Dybcio >> --- [...] > > This value is exposed to userspace via MSM_PARAM_CHIP_ID. 16 bits are > reserved for speedbin, so we should ensure somewhere that we don't > accidently use more than that. The "real" chip id is 32b, leaving the other 32 for speedbin, so it's fine > > Also, what is the the max value of fcode? I think we should leave some > space for pcode too. We never know for sure if that won't be required in > future. As of today it seems to be 0xff. Worst case scenario we'll add a new param, but hopefully the people that are in charge won't randomly change things.. Konrad