From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9ED036DA1B for ; Thu, 11 Jun 2026 07:49:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781164163; cv=none; b=UnemVtAhBGl6PYmvAXesYWSmlzZoYaHWUMJ9Xq4B4v+UPBDRkKYIqoMIpFEwSkgmD1thELxgFPwdgfuagBkqhzbVC7+iHMFE1PeOtsdTqnDdOQSjV8JJEj5wWRk2T+hiLhESHX/u0TfFYpEaSDiR8Kn05fR+CxAw0kURPx5nHPk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781164163; c=relaxed/simple; bh=r4u7525wBMTu2CXxDilTPdQiU4seuStXSxr4mhu0jLM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hTDy2bRI2fozKn/H7ljdLZ+uRBHCsXnU2/vyo0BfsjI7Nu7wckqcKKbMLIXAHWLF2DO63fle/rUvCzB+8IkaSkZqsM9h3p4DtV6Bzyl8FAPIGWCsbR+KPA9ua7QDTWKWVT6UZPZP0BWAWrRapSadast0SiSpMuk70G/5aYNkMIA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=aopiqepx; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=X8QiSpa4; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="aopiqepx"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="X8QiSpa4" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65B5GOnM3835120 for ; Thu, 11 Jun 2026 07:49:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= p/tvkY8zr/P0A/+5aGOPJMzczHUrqigU/gDVfyTBh4A=; b=aopiqepxGMr0v6Qz 5bdcQmuZTbH3BPUe42QZj8F/adRBZX87r0PDDnrVFHZVnDgxqX+UJDkYYO2gTPqL +hhqmr/NbxW6EaB8deAOFa68kyGfn+mOGt7eG3L0gbCqwE1BFmyeawY65u5a7J8k S4CHxrZuigRepsCLyo5CFPlxv3CuMLWrmss133BptG8nyZQ/da9XixEgivv3jI7j 8Dte9XGqr3tz12lkCWDQPRKPeDbDdfQfDdL/f8ZYHFGvPjF3wDxwDHrk13Tb/cbv 7ypU/HzN64nsYhhatDbpIUcO3hzVEOTGZO0BGRDFNHHdNqGx7bPUbNNUYSvxgqaw qGso3w== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eqe6tjac9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 11 Jun 2026 07:49:22 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-8cce360a385so17453876d6.3 for ; Thu, 11 Jun 2026 00:49:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781164161; x=1781768961; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=p/tvkY8zr/P0A/+5aGOPJMzczHUrqigU/gDVfyTBh4A=; b=X8QiSpa449p3UfkYtoMYeCT6dDXl8hWgE/EcDAoh39T22W+PWRHcNwqTUlXEuN9u/B Zn/fytUd0lFq1hh7814TfWiUqPmtnHgdL4OpN2/1pwl7orL1jLzKDm754mrDimN+owiv CqQb9fN5PGKSkk7DwV/P43cp3jgUjodTzP38qiRXz37rEBuNELiYjlHppvGuDonorXxo hl1pr/BoTlSZKyuapKODXGSXL8mOBBtPSGJKvHI2egUEcxxOSZv30eC924yC2yqDMAI1 ew30JejfbY/hvBsU8Al/y1km0cGnemXE7jTtUHEG6J65q1Sgh1K9AJckpyjQK7emeJzc P5ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781164161; x=1781768961; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=p/tvkY8zr/P0A/+5aGOPJMzczHUrqigU/gDVfyTBh4A=; b=iqOW0EmNGhcwJKEvzkAlMX2DerVYyvAPLJH25cJBOimqoa2QWgkbaK+Jh+mkwQFdPI I3dCesybVn3e+nI1+2wEJHBX6piOSU7rjl0hsEr9ZdVI5KumH7fZ/KKcJpZeaXMEzdQu V+8Yy5YB+u3fLo5yaLF29cYZQ8vIjm3eTuh9hyRlu51Yazsc2Rlgg1I/gy/EzFwQlbRh GTjTt2yOkmpO98QQ1J3aE9UQ2Z4dxLN3NgbG6dWHky8IvOrxggZvOl/edurI5Q6JZkT9 ggVHNLQD/acYRD2xyYXgFoYx+w8IOoGw1gOM8MzxSaen6Qgc+paw+iJqvzh/YQJz4Uwq i0Ug== X-Forwarded-Encrypted: i=1; AFNElJ/6GnA+0ozp/WMwDm2DhSYoFUrCYmcZukohwVvNBJA5FGItkMyKX6knTl4Du6gdwZPIU3FLh2Oe1ZURyBE=@vger.kernel.org X-Gm-Message-State: AOJu0Yz9B78qLHYEhKvIeBYqr6qRatqrxttDnUh6XubwEs/XfM/QiobJ IDfJ2aA0Nn23DAhOUsCUOdozbRqWuEV7JSk7YIdY1r0yYQX/OjDnX7jf6MY30x4x9u4jADMCxYS rgCVNUMQPzKohJUI3npX2vy5Qbe06n2D78rQ3i6opwAfdYslIlauTSgoCh7dWHKA9lMc= X-Gm-Gg: Acq92OHue/fVNee5LKXkLVG2h2e1PvDmfRO2PWYXlaOMgTtADQm0dIGAL4fpxS0TiRL vCyP/2euRDD8UWFI9Kuphjw0QYtuWo9nxgtDU4UbsWdaDDKe2li0G2IZIbUyHrFOxonU+wQsa9C Ac4dFs/PXZjMf+5hvvHVXX7P3/QFoNszNbtVIDeUl6tcKca3Lo/SZWkTknXgw21u6LuRZ/gMh/y thxxpUpu1T3P2EU5ktShyGE+G+WRBQ9uwqeEcHtQKFO1wlv7ZWLz8N233A5IAsWyjohBwHi5WGD nMI110vV2z0S6t9A/T/2/L+vyB0wOn9QtoPLvXh9scTjvtJqgB4Z3b8BA7dEJZUKZWTTLlixjEx CED3mK02B6R6Cj9FOXoocBkRVIIja27Idd3+1m21cbewmcLAmDvMhR/h6 X-Received: by 2002:a05:620a:1a09:b0:911:dfb8:37c9 with SMTP id af79cd13be357-9160ad62db3mr134148285a.3.1781164160961; Thu, 11 Jun 2026 00:49:20 -0700 (PDT) X-Received: by 2002:a05:620a:1a09:b0:911:dfb8:37c9 with SMTP id af79cd13be357-9160ad62db3mr134146585a.3.1781164160505; Thu, 11 Jun 2026 00:49:20 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bfcb0f1439esm24362666b.1.2026.06.11.00.49.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jun 2026 00:49:19 -0700 (PDT) Message-ID: <5a65ea59-b38d-4cc0-901a-01c239381d91@oss.qualcomm.com> Date: Thu, 11 Jun 2026 09:49:17 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 26/37] arm64: dts: qcom: sc8180x: Move PCIe phy and GPIOs to root port node To: Krishna Chaitanya Chundru , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , cros-qcom-dts-watchers@chromium.org, Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krishna Chaitanya Chundru References: <20260611-wake-v2-0-2744251b1181@oss.qualcomm.com> <20260611-wake-v2-26-2744251b1181@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260611-wake-v2-26-2744251b1181@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjExMDA3NiBTYWx0ZWRfXwa6N25hn08DE qC58b5Vee+qc5KBOYyH9ismrrOlHnot/s2ycc+ZlrgJUaJVmvAs0D/GPcnhfCOOWKI6TjfNtleB +RPRCyh8KXkJJGf4EGleXYESwXKskFoXifg+WGDum8ek3QIGMm/e54f/Udb9nAG8qARo5gis7PT pbDdUxRrd/n/MlsHOhSttjSPa64bsaf6yGx1CUAufDEgRj70MxIpqR5eCJnluFrFNgA8rWKSEdO oNNdo/1jiV0/XkyGzBTaJEdOhsAlhw3bwEEsScUaYGXAvXigkgNprp+89dmgB+WxvP7RheEK1hp yfaFTHGJ1MYoUQEyz4eKM8VZzTuld5L56TuXnntT9VOsjDgcyyeoMtpYuwodkiw3EHyrVE8zuuQ kKxpalhv/WYi9Xy13eelm4WIl3SoWcR2dbJNDhLKUz0iEd40EI7NueTlTM/ufA9meLSnGfFMcrM aOT9dCJkDBnc1jL0c8A== X-Proofpoint-Spam-Info: AW1haW4tMjYwNjExMDA3NiBTYWx0ZWRfXwE0wzfMGEndO nmAbJ9XCxA3Tvto83MZT/Jfw4E6jI55KCnocgWSB6CaR58n1Yv10/EGy1+kQmrXDAAKYEAyL0s6 I8SyodmpWmTaMBykNI4Poaj9jnkjRNk= X-Authority-Analysis: v=2.4 cv=AaiB2XXG c=1 sm=1 tr=0 ts=6a2a6882 cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=Pp3Y-cPEr_PWQjmyE4QA:9 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 X-Proofpoint-ORIG-GUID: RPjnq5JrcstkdjQNX1RNbbYHgAhIpBov X-Proofpoint-GUID: RPjnq5JrcstkdjQNX1RNbbYHgAhIpBov X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-11_01,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 impostorscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 adultscore=0 suspectscore=0 lowpriorityscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606110076 On 6/11/26 6:59 AM, Krishna Chaitanya Chundru wrote: > The PCIe phy reference and the perst/wake GPIO properties are > per root port and belong in the root port node (pcie@0), not in the > RC controller node. Move phys and phy-names from the controller to > pcie0_port0, pcie1_port0, pcie2_port0, and pcie3_port0, adding > labels to these nodes to allow board-level overrides. Move > perst-gpios/wake-gpios from the controller overrides to the > respective port nodes in the board files, renaming perst-gpios to > reset-gpios to match the binding used in the root port context. > > Signed-off-by: Krishna Chaitanya Chundru > --- [...] > @@ -1779,13 +1779,11 @@ pcie0: pcie@1c00000 { > <&gem_noc MASTER_AMPSS_M0 0 &config_noc SLAVE_PCIE_0 0>; > interconnect-names = "pcie-mem", "cpu-pcie"; > > - phys = <&pcie0_phy>; > - phy-names = "pciephy"; > dma-coherent; > > status = "disabled"; > > - pcie@0 { > + pcie0_port0: pcie@0 { > device_type = "pci"; > reg = <0x0 0x0 0x0 0x0 0x0>; > bus-range = <0x01 0xff>; > @@ -1793,6 +1791,8 @@ pcie@0 { > #address-cells = <3>; > #size-cells = <2>; > ranges; > + > + phys = <&pcie0_phy>; Other DTs put this between bus-range and address-cells, e.g. hamoa: pcie3_port0: pcie@0 { device_type = "pci"; compatible = "pciclass,0604"; reg = <0x0 0x0 0x0 0x0 0x0>; bus-range = <0x01 0xff>; phys = <&pcie3_phy>; #address-cells = <3>; #size-cells = <2>; ranges; }; Please follow this style Konrad